From: Jaehoon Chung <jh80.chung@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com,
kgene@kernel.org, javier@osg.samsung.com, kishon@ti.com,
will.deacon@arm.com, catalin.marinas@arm.com, cpgs@samsung.com
Subject: Re: [RFC PATCH 5/6] Documentation: pci: add the exynos5433-pcie binding
Date: Wed, 28 Dec 2016 08:03:41 +0900 [thread overview]
Message-ID: <d723ec48-af3c-6012-4f76-e8e73ad9af58@samsung.com> (raw)
In-Reply-To: <20161227161916.nb6yf3n2kmkzkeg2@kozik-lap>
On 12/28/2016 01:19 AM, Krzysztof Kozlowski wrote:
> On Mon, Dec 26, 2016 at 02:20:28PM +0900, Jaehoon Chung wrote:
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>> .../devicetree/bindings/pci/exynos5433-pcie.txt | 36 ++++++++++++++++++++++
>> 1 file changed, 36 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/pci/exynos5433-pcie.txt
>>
>> diff --git a/Documentation/devicetree/bindings/pci/exynos5433-pcie.txt b/Documentation/devicetree/bindings/pci/exynos5433-pcie.txt
>> new file mode 100644
>> index 0000000..932a847
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pci/exynos5433-pcie.txt
>> @@ -0,0 +1,36 @@
>> +* Samsung Exynos5433 PCIe interface
>> +
>> +This PCIe host controller is based on the Synopsis Designware PCIe IP
>
> Synopsys.
Will fix.
>
>> +and thus inherits all the common properties defined in designware-pcie.txt.
>> +
>> +Required properties:
>> +- compatible: "samsung,exynos5433-pcie"
>> +- reg: base addresses and lengths of the pcie controller,
>> + the phy controller, additional register for the phy controller.
>
> You mentioned three regs but the example contains four of them. Is the
> config comming from snps,dw-pcie?
Oops..It's my mistake. Just needs to put three reg.
Elbi : External local Bus interface register.
Dbi : Data bus interface register.(Control register.)
Config : for configuration space.
"config" can be removed. Because it's not Exynos specific, synopsys's Required property.
>
>> +- reg-names: Must be "elbi", "phy" and "dbi" for each regs
>
> Again, three here, four in example.
Will fix.
>
>> +- interrupt-names: Must be "intr" for legacy interrupt pin.
>> +
>> +Other common properites refer to
>> + Documentation/devicetree/binding/pci/designware-pcie.txt
>> +
>> +Example:
>> +
>> + pcie: pcie@15700000 {
>> + compatible ="samsung,exynos5433-pcie", "snps,dw-pcie";
> ^
> space needed
>> + #address-cells = <3>;
>> + #size-cells = <2>;
>> + device_type = "pci";
>> + interrupts = <GIC_SPI 245 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "intr";
>> + clocks = <&cmu_fsys CLK_PCIE>, <&cmu_fsys CLK_PCLK_PCIE_PHY>;
>> + clock-names = "pcie", "pcie_bus";
>> + num-lanes = <1>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pcie_bus>;
>> + reg = <0x156b0000 0x1000>, <0x15680000 0x1000>,
>> + <0x15700000 0x1000>, <0x0c000000 0x1000>;
>
> Indentation here looks wrong. You indented it with spaces after tabs...
> but not to align with line before.
Will fix.
Best Regards,
Jaehoon Chung
>
> Beside that, fine with me:
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Best regards,
> Krzysztof
>
>
>> + reg-names = "elbi", "phy", "dbi", "config";
>> + ranges = <0x81000000 0 0 0x0c001000 0 0x00010000
>> + 0x82000000 0 0x0c011000 0x0c011000 0 0x3feefff>;
>> + status = "disabled";
>> + };
>> --
>> 2.10.2
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
next prev parent reply other threads:[~2016-12-27 23:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161226052030epcas1p45f543765960d14ccf9cd40c2b9cca84b@epcas1p4.samsung.com>
2016-12-26 5:20 ` [RFC PATCH 0/6] Support the PCIe for TM2(exynos5433) Jaehoon Chung
[not found] ` <CGME20161226052030epcas5p4ea673fc4ee5c0b2664e80f53d4758553@epcas5p4.samsung.com>
2016-12-26 5:20 ` [RFC PATCH 1/6] phy: exynos-pcie: Add support for Exynos PCIe phy Jaehoon Chung
2016-12-27 5:53 ` Vivek Gautam
2016-12-28 2:49 ` Jaehoon Chung
2016-12-28 8:58 ` Vivek Gautam
2016-12-28 9:35 ` Jaehoon Chung
2016-12-28 10:12 ` Vivek Gautam
[not found] ` <CGME20161226052030epcas1p40f87c865223a9ad8cd0cd1d6e4d54b32@epcas1p4.samsung.com>
2016-12-26 5:20 ` [RFC PATCH 2/6] Documetation: samsung-phy: add the exynos-pcie-phy binding Jaehoon Chung
[not found] ` <CGME20161226052031epcas5p451b1352d6c8c5205a69246c2994b9506@epcas5p4.samsung.com>
2016-12-26 5:20 ` [RFC PATCH 3/6] ARM64: dts: exynos5433: add the pcie_phy node for PCIe Jaehoon Chung
2016-12-27 16:11 ` Krzysztof Kozlowski
2016-12-27 22:57 ` Jaehoon Chung
[not found] ` <CGME20161226052031epcas1p4d238d16e55984dcf905daf1ad132ccca@epcas1p4.samsung.com>
2016-12-26 5:20 ` [RFC PATCH 4/6] PCI: exynos5433: Add new exynos pci host controller for Exynos5433 Jaehoon Chung
2016-12-26 11:49 ` Joao Pinto
2016-12-27 1:43 ` Jaehoon Chung
[not found] ` <CGME20161226052031epcas5p4f151c41189f7b3811979ca1e10aab1be@epcas5p4.samsung.com>
2016-12-26 5:20 ` [RFC PATCH 5/6] Documentation: pci: add the exynos5433-pcie binding Jaehoon Chung
2016-12-27 16:19 ` Krzysztof Kozlowski
2016-12-27 23:03 ` Jaehoon Chung [this message]
[not found] ` <CGME20161226052031epcas1p43a300fe9e59c2af410c48861cd8554d1@epcas1p4.samsung.com>
2016-12-26 5:20 ` [RFC PATCH 6/6] ARM64: exynos: add the pcie node for TM2 Jaehoon Chung
2016-12-27 16:32 ` Krzysztof Kozlowski
2016-12-27 16:33 ` Krzysztof Kozlowski
2016-12-27 23:05 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d723ec48-af3c-6012-4f76-e8e73ad9af58@samsung.com \
--to=jh80.chung@samsung.com \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=cpgs@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=kishon@ti.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).