From: Pierre Yves MORDRET <pierre-yves.mordret@foss.st.com>
To: Alain Volmat <alain.volmat@foss.st.com>, <wsa@kernel.org>
Cc: <alexandre.torgue@foss.st.com>, <linux-i2c@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <fabrice.gasnier@foss.st.com>,
<amelie.delaunay@foss.st.com>
Subject: Re: [PATCH 2/4] i2c: stm32f7: recover the bus on access timeout
Date: Thu, 23 Sep 2021 10:37:16 +0200 [thread overview]
Message-ID: <d75186a2-af03-5c81-fd33-706dcf5fe5f0@foss.st.com> (raw)
In-Reply-To: <1632151292-18503-3-git-send-email-alain.volmat@foss.st.com>
Hi Alain
Look good to me
Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@foss.st.com>
Regards
On 9/20/21 5:21 PM, Alain Volmat wrote:
> When getting an access timeout, ensure that the bus is in a proper
> state prior to returning the error.
>
> Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver")
>
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index ed977b6f7ab6..ad3459a3bc5e 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -1712,6 +1712,7 @@ static int stm32f7_i2c_xfer(struct i2c_adapter *i2c_adap,
> i2c_dev->msg->addr);
> if (i2c_dev->use_dma)
> dmaengine_terminate_all(dma->chan_using);
> + stm32f7_i2c_wait_free_bus(i2c_dev);
> ret = -ETIMEDOUT;
> }
>
> @@ -1769,6 +1770,7 @@ static int stm32f7_i2c_smbus_xfer(struct i2c_adapter *adapter, u16 addr,
> dev_dbg(dev, "Access to slave 0x%x timed out\n", f7_msg->addr);
> if (i2c_dev->use_dma)
> dmaengine_terminate_all(dma->chan_using);
> + stm32f7_i2c_wait_free_bus(i2c_dev);
> ret = -ETIMEDOUT;
> goto pm_free;
> }
>
--
--
~ Py MORDRET
--
next prev parent reply other threads:[~2021-09-23 8:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 15:21 [PATCH 0/4] i2c: stm32: various fixes & dmaengine updates Alain Volmat
2021-09-20 15:21 ` [PATCH 1/4] i2c: stm32f7: flush TX FIFO upon transfer errors Alain Volmat
2021-09-23 8:35 ` Pierre Yves MORDRET
2021-11-29 12:12 ` Wolfram Sang
2021-09-20 15:21 ` [PATCH 2/4] i2c: stm32f7: recover the bus on access timeout Alain Volmat
2021-09-23 8:37 ` Pierre Yves MORDRET [this message]
2021-11-29 12:17 ` Wolfram Sang
2021-11-29 12:33 ` Alain Volmat
2021-11-29 12:52 ` Wolfram Sang
2021-11-30 8:56 ` Alain Volmat
2021-11-30 9:27 ` Wolfram Sang
2021-11-30 9:27 ` Wolfram Sang
2021-09-20 15:21 ` [PATCH 3/4] i2c: stm32f7: stop dma transfer in case of NACK Alain Volmat
2021-09-23 8:37 ` Pierre Yves MORDRET
2021-11-30 9:27 ` Wolfram Sang
2021-09-20 15:21 ` [PATCH 4/4] i2c: stm32f7: use proper DMAENGINE API for termination Alain Volmat
2021-09-23 8:38 ` Pierre Yves MORDRET
2021-11-30 9:28 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d75186a2-af03-5c81-fd33-706dcf5fe5f0@foss.st.com \
--to=pierre-yves.mordret@foss.st.com \
--cc=alain.volmat@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).