From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
"zhuchangchun@cvte.com" <zhuchangchun@cvte.com>
Cc: "andriy.shevchenko" <andriy.shevchenko@linux.intel.com>,
"linus.walleij" <linus.walleij@linaro.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
hendychu <hendychu@aliyun.com>
Subject: Re: [PATCH] pinctrl: intel: Implements gpio free function
Date: Fri, 22 Mar 2019 19:35:42 +0100 [thread overview]
Message-ID: <d752cd9b-59f2-4524-e989-92bd0dba6b4f@metux.net> (raw)
In-Reply-To: <20190321135642.GK3622@lahna.fi.intel.com>
On 21.03.19 14:56, Mika Westerberg wrote:
> I checked it and you do this:> > + value |= PADCFG0_GPIORXDIS;> + value &=
~PADCFG0_GPIOTXDIS;> > which pretty much turns the pin GPIO output
unconditionally. I don't> really think it is good idea. May work in your
case but may cause> problems with others.
Uh, please don't do this. In some cases it could be even dangerous.
In general, I'd question whether such an gpio should be userland-
controlled in the first place. Better write a driver for it, which
also handles the reset properly.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
prev parent reply other threads:[~2019-03-22 18:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 2:35 [PATCH] pinctrl: intel: Implements gpio free function zhuchangchun
2019-03-21 8:44 ` Mika Westerberg
2019-03-21 9:23 ` Andy Shevchenko
2019-03-22 18:32 ` Enrico Weigelt, metux IT consult
2019-03-22 19:06 ` Andy Shevchenko
2019-03-25 9:36 ` Enrico Weigelt, metux IT consult
2019-03-25 11:45 ` Andy Shevchenko
2019-04-03 4:13 ` Linus Walleij
2019-04-04 10:51 ` Enrico Weigelt, metux IT consult
2019-04-04 11:52 ` Andy Shevchenko
2019-04-04 16:03 ` Linus Walleij
[not found] ` <2019032119195575582546@cvte.com>
2019-03-21 12:03 ` Mika Westerberg
[not found] ` <2019032120213955866649@cvte.com>
2019-03-21 12:36 ` Mika Westerberg
[not found] ` <2019032121342663125658@cvte.com>
2019-03-21 13:56 ` Mika Westerberg
[not found] ` <2019032211131426883268@cvte.com>
2019-03-22 10:42 ` Mika Westerberg
[not found] ` <2019032314505202825175@cvte.com>
2019-03-23 16:48 ` andriy.shevchenko
[not found] ` <2019032517511048990383@cvte.com>
2019-03-25 11:48 ` andriy.shevchenko
2019-03-22 18:35 ` Enrico Weigelt, metux IT consult [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d752cd9b-59f2-4524-e989-92bd0dba6b4f@metux.net \
--to=lkml@metux.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hendychu@aliyun.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=zhuchangchun@cvte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).