From: Lars-Peter Clausen <lars@metafoo.de>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dmitry.torokhov@gmail.com
Subject: Re: [PATCH v2 3/3] Input: adp5589-keys - add basic devicetree support
Date: Tue, 24 Nov 2020 09:43:05 +0100 [thread overview]
Message-ID: <d8265d12-0269-a7ed-1f02-ee5679ee1db2@metafoo.de> (raw)
In-Reply-To: <20201124082255.13427-3-alexandru.ardelean@analog.com>
On 11/24/20 9:22 AM, Alexandru Ardelean wrote:
> error = devm_add_action_or_reset(&client->dev, adp5589_clear_config,
> @@ -1078,6 +1098,13 @@ static int __maybe_unused adp5589_resume(struct device *dev)
>
> static SIMPLE_DEV_PM_OPS(adp5589_dev_pm_ops, adp5589_suspend, adp5589_resume);
>
> +static const struct of_device_id adp5589_of_match[] = {
> + { .compatible = "adi,adp5585", .data = &adp5589_chip_info_tbl[ADP5585_01] },
> + { .compatible = "adi,adp5585-02", .data = &adp5589_chip_info_tbl[ADP5585_02] },
> + { .compatible = "adi,adp5589", .data = &adp5589_chip_info_tbl[ADP5589] },
I think we need to add these to
Documentation/devicetree/bindings/trivial-devices.yaml
next prev parent reply other threads:[~2020-11-24 8:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 8:22 [PATCH v2 1/3] Input: adp5589-keys - add default platform data Alexandru Ardelean
2020-11-24 8:22 ` [PATCH v2 2/3] Input: adp5589-keys - wrap device probing into chip info struct Alexandru Ardelean
2020-11-24 8:22 ` [PATCH v2 3/3] Input: adp5589-keys - add basic devicetree support Alexandru Ardelean
2020-11-24 8:43 ` Lars-Peter Clausen [this message]
2020-11-25 5:29 ` Ardelean, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8265d12-0269-a7ed-1f02-ee5679ee1db2@metafoo.de \
--to=lars@metafoo.de \
--cc=alexandru.ardelean@analog.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).