From: Lukasz Luba <lukasz.luba@arm.com>
To: Amit Kucheria <amit.kucheria@linaro.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
swboyd@chromium.org, mka@chromium.org, daniel.lezcano@linaro.org,
Amit Kucheria <amit.kucheria@verdurent.com>,
Zhang Rui <rui.zhang@intel.com>
Cc: Rob Herring <robh@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: thermal: Add yaml bindings for thermal sensors
Date: Wed, 1 Apr 2020 13:40:00 +0100 [thread overview]
Message-ID: <da9860cf-0c2e-b7ff-47c2-19c79b06ad55@arm.com> (raw)
In-Reply-To: <146b5dfebf23321c1eed8190ada957e2264ffe65.1585738725.git.amit.kucheria@linaro.org>
On 4/1/20 12:15 PM, Amit Kucheria wrote:
> As part of moving the thermal bindings to YAML, split it up into 3
> bindings: thermal sensors, cooling devices and thermal zones.
>
> The property #thermal-sensor-cells is required in each device that acts
> as a thermal sensor. It is used to uniquely identify the instance of the
> thermal sensor inside the system.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/thermal/thermal-sensor.yaml | 72 +++++++++++++++++++
> 1 file changed, 72 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/thermal-sensor.yaml
>
> diff --git a/Documentation/devicetree/bindings/thermal/thermal-sensor.yaml b/Documentation/devicetree/bindings/thermal/thermal-sensor.yaml
> new file mode 100644
> index 0000000000000..920ee7667591d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/thermal-sensor.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: (GPL-2.0)
> +# Copyright 2020 Linaro Ltd.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/thermal-sensor.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Thermal sensor binding
> +
> +maintainers:
> + - Amit Kucheria <amitk@kernel.org>
> +
> +description: |
> + Thermal management is achieved in devicetree by describing the sensor hardware
> + and the software abstraction of thermal zones required to take appropriate
> + action to mitigate thermal overloads.
> +
> + The following node types are used to completely describe a thermal management
> + system in devicetree:
> + - thermal-sensor: device that measures temperature, has SoC-specific bindings
> + - cooling-device: device used to dissipate heat either passively or artively
s/artively/actively
> + - thermal-zones: a container of the following node types used to describe all
> + thermal data for the platform
> +
> + This binding describes the thermal-sensor.
> +
> + Thermal sensor devices provide temperature sensing capabilities on thermal
> + zones. Typical devices are I2C ADC converters and bandgaps. Thermal sensor
> + devices may control one or more internal sensors.
> +
> +properties:
> + "#thermal-sensor-cells":
> + description:
> + Used to uniquely identify a thermal sensor instance within an IC. Will be
> + 0 on sensor nodes with only a single sensor and at least 1 on nodes
> + containing several internal sensors.
> + enum: [0, 1]
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + // Example 1: SDM845 TSENS
> + soc: soc@0 {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + /* ... */
> +
> + tsens0: thermal-sensor@c263000 {
> + compatible = "qcom,sdm845-tsens", "qcom,tsens-v2";
> + reg = <0 0x0c263000 0 0x1ff>, /* TM */
> + <0 0x0c222000 0 0x1ff>; /* SROT */
> + #qcom,sensors = <13>;
> + interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 508 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "uplow", "critical";
> + #thermal-sensor-cells = <1>;
> + };
> +
> + tsens1: thermal-sensor@c265000 {
> + compatible = "qcom,sdm845-tsens", "qcom,tsens-v2";
> + reg = <0 0x0c265000 0 0x1ff>, /* TM */
> + <0 0x0c223000 0 0x1ff>; /* SROT */
> + #qcom,sensors = <8>;
> + interrupts = <GIC_SPI 507 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 509 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "uplow", "critical";
> + #thermal-sensor-cells = <1>;
> + };
> + };
> +...
>
Apart from the above, looks good.
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Regards,
Lukasz
next prev parent reply other threads:[~2020-04-01 12:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 11:15 [PATCH v4 0/3] Convert thermal bindings to yaml Amit Kucheria
2020-04-01 11:15 ` [PATCH v4 1/3] dt-bindings: thermal: Add yaml bindings for thermal sensors Amit Kucheria
2020-04-01 12:40 ` Lukasz Luba [this message]
2020-04-01 13:38 ` Amit Kucheria
2020-04-01 11:15 ` [PATCH v4 2/3] dt-bindings: thermal: Add yaml bindings for thermal cooling-devices Amit Kucheria
2020-04-01 12:34 ` Lukasz Luba
2020-04-01 11:15 ` [PATCH v4 3/3] dt-bindings: thermal: Add yaml bindings for thermal zones Amit Kucheria
2020-04-01 12:26 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da9860cf-0c2e-b7ff-47c2-19c79b06ad55@arm.com \
--to=lukasz.luba@arm.com \
--cc=amit.kucheria@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).