From: Chao Yu <yuchao0@huawei.com>
To: Jason Yan <yanaijie@huawei.com>, <jaegeuk@kernel.org>,
<chao@kernel.org>, <linux-f2fs-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>
Cc: <kernel-hardening@lists.openwall.com>, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] f2fs: Eliminate usage of uninitialized_var() macro
Date: Mon, 15 Jun 2020 17:04:36 +0800 [thread overview]
Message-ID: <daff3367-a486-0514-99a7-567b9b549e47@huawei.com> (raw)
In-Reply-To: <20200615085132.166470-1-yanaijie@huawei.com>
On 2020/6/15 16:51, Jason Yan wrote:
> This is an effort to eliminate the uninitialized_var() macro[1].
>
> The use of this macro is the wrong solution because it forces off ANY
> analysis by the compiler for a given variable. It even masks "unused
> variable" warnings.
>
> Quoted from Linus[2]:
>
> "It's a horrible thing to use, in that it adds extra cruft to the
> source code, and then shuts up a compiler warning (even the _reliable_
> warnings from gcc)."
>
> Fix it by remove this variable since it is not needed at all.
>
> [1] https://github.com/KSPP/linux/issues/81
> [2] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/
>
> Cc: Kees Cook <keescook@chromium.org>
> Suggested-by: Chao Yu <yuchao0@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
next prev parent reply other threads:[~2020-06-15 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 8:51 [PATCH] f2fs: Eliminate usage of uninitialized_var() macro Jason Yan
2020-06-15 9:04 ` Chao Yu [this message]
2020-06-15 20:11 ` Kees Cook
-- strict thread matches above, loose matches on Subject: below --
2020-06-15 4:02 Jason Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daff3367-a486-0514-99a7-567b9b549e47@huawei.com \
--to=yuchao0@huawei.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).