From: Hans Verkuil <hverkuil@xs4all.nl>
To: Hugues Fruchet <hugues.fruchet@st.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Yannick Fertre <yannick.fertre@st.com>
Subject: Re: [PATCH v5 2/8] [media] stm32-dcmi: STM32 DCMI camera interface driver
Date: Sat, 6 May 2017 10:54:20 +0200 [thread overview]
Message-ID: <dd4a1ec1-b84a-81cb-51b6-c2e53b5efcc5@xs4all.nl> (raw)
In-Reply-To: <1493998287-5828-3-git-send-email-hugues.fruchet@st.com>
Hi Hugues,
On 05/05/2017 05:31 PM, Hugues Fruchet wrote:
> This V4L2 subdev driver enables Digital Camera Memory Interface (DCMI)
> of STMicroelectronics STM32 SoC series.
>
> Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
> Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
> ---
> drivers/media/platform/Kconfig | 12 +
> drivers/media/platform/Makefile | 2 +
> drivers/media/platform/stm32/Makefile | 1 +
> drivers/media/platform/stm32/stm32-dcmi.c | 1403 +++++++++++++++++++++++++++++
> 4 files changed, 1418 insertions(+)
> create mode 100644 drivers/media/platform/stm32/Makefile
> create mode 100644 drivers/media/platform/stm32/stm32-dcmi.c
>
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index ac026ee..de6e18b 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -114,6 +114,18 @@ config VIDEO_S3C_CAMIF
> To compile this driver as a module, choose M here: the module
> will be called s3c-camif.
>
> +config VIDEO_STM32_DCMI
> + tristate "Digital Camera Memory Interface (DCMI) support"
Is it OK with you if I change this to:
tristate "STM32 Digital Camera Memory Interface (DCMI) support"
Right now the text gives no indication that this driver is for an STM32 platform.
No need to spin a new patch, just let me know you're OK with it and I'll make
the change.
Regards,
Hans
> + depends on VIDEO_V4L2 && OF && HAS_DMA
> + depends on ARCH_STM32 || COMPILE_TEST
> + select VIDEOBUF2_DMA_CONTIG
> + ---help---
> + This module makes the STM32 Digital Camera Memory Interface (DCMI)
> + available as a v4l2 device.
> +
> + To compile this driver as a module, choose M here: the module
> + will be called stm32-dcmi.
> +
> source "drivers/media/platform/soc_camera/Kconfig"
> source "drivers/media/platform/exynos4-is/Kconfig"
> source "drivers/media/platform/am437x/Kconfig"
next prev parent reply other threads:[~2017-05-06 8:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 15:31 [PATCH v5 0/8] Add support for DCMI camera interface of STMicroelectronics STM32 SoC series Hugues Fruchet
2017-05-05 15:31 ` [PATCH v5 1/8] dt-bindings: Document STM32 DCMI bindings Hugues Fruchet
2017-05-05 15:31 ` [PATCH v5 2/8] [media] stm32-dcmi: STM32 DCMI camera interface driver Hugues Fruchet
2017-05-06 8:54 ` Hans Verkuil [this message]
2017-05-09 7:36 ` Hugues FRUCHET
2017-05-05 15:31 ` [PATCH v5 3/8] ARM: dts: stm32: Enable DCMI support on STM32F429 MCU Hugues Fruchet
2017-05-05 15:31 ` [PATCH v5 4/8] ARM: dts: stm32: Enable DCMI camera interface on STM32F429-EVAL board Hugues Fruchet
2017-05-05 15:31 ` [PATCH v5 5/8] ARM: dts: stm32: Enable STMPE1600 gpio expander of " Hugues Fruchet
2017-05-05 15:31 ` [PATCH v5 6/8] ARM: dts: stm32: Enable OV2640 camera support " Hugues Fruchet
2017-05-05 15:31 ` [PATCH v5 7/8] ARM: configs: stm32: STMPE1600 GPIO expander Hugues Fruchet
2017-05-05 15:31 ` [PATCH v5 8/8] ARM: configs: stm32: DCMI + OV2640 camera support Hugues Fruchet
2017-06-12 10:03 ` [PATCH v5 0/8] Add support for DCMI camera interface of STMicroelectronics STM32 SoC series Alexandre Torgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd4a1ec1-b84a-81cb-51b6-c2e53b5efcc5@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hugues.fruchet@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).