From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org,
gregory.clement@bootlin.com, thomas.petazzoni@free-electrons.com,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/4] clk: mvebu: Fix some error handling paths + do some clean-up
Date: Fri, 23 Apr 2021 10:49:49 +0200 [thread overview]
Message-ID: <dd6f8b77-ac24-0339-0b38-4f62b004dc9c@wanadoo.fr> (raw)
In-Reply-To: <20210423092700.6a857460@windsurf>
Le 23/04/2021 à 09:27, Thomas Petazzoni a écrit :
> Hello,
>
> On Fri, 23 Apr 2021 08:24:52 +0200
> Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
>
>> Also, I wonder if the drivers in drivers/clk/mvebu are used by anyone.
>> In order to compile-test the changes, I also had to change the 'bool' in Kconfig
>> by 'bool "blah"'. Without this change, it was not possible to set
>> CONFIG_MVEBU_CLK_CPU required by Makefile.
>
> CONFIG_MVEBU_CLK_CPU is selected by ARMADA_370_CLK and ARMADA_XP_CLK,
> which themselves are selected by MACH_ARMADA_370 and MACH_ARMADA_XP
> respectively.
Hi, thanks for the clarification.
Usually, only slightly modifying dependencies in Kconfig is enough for
me to trigger a built, even if I don't have the correct toolchain for
this architecture. In this case, the tweak I had to do was "spurious"
and Kconfig "looked strange" to me, hence my comment.
Glad to here that this code is still alive. So, my patches may make
sense :).
CJ
>
> So unless I'm missing something, this code is definitely reachable and
> compiled. You can use the mvebu_v7_defconfig of ARM32, and the code
> will be built.
>
> Best regards,
>
> Thomas
>
next prev parent reply other threads:[~2021-04-23 8:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 6:24 [PATCH 0/4] clk: mvebu: Fix some error handling paths + do some clean-up Christophe JAILLET
2021-04-23 6:25 ` [PATCH 1/4] clk: mvebu: Fix a memory leak in an error handling path Christophe JAILLET
2021-04-23 11:42 ` AW: " Walter Harms
2021-04-23 12:02 ` Christophe JAILLET
2021-04-23 15:34 ` Walter Harms
2021-04-23 6:25 ` [PATCH 2/4] clk: mvebu: Fix a another " Christophe JAILLET
2021-04-23 6:25 ` [PATCH 3/4] clk: mvebu: Add a missing space Christophe JAILLET
2021-04-23 6:25 ` [PATCH 4/4] clk: mvebu: Remove an unneeded include Christophe JAILLET
2021-04-23 7:27 ` [PATCH 0/4] clk: mvebu: Fix some error handling paths + do some clean-up Thomas Petazzoni
2021-04-23 8:49 ` Christophe JAILLET [this message]
2021-05-22 6:51 ` Christophe JAILLET
2021-05-22 7:17 ` Marion & Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd6f8b77-ac24-0339-0b38-4f62b004dc9c@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=gregory.clement@bootlin.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).