From: Randy Dunlap <rdunlap@infradead.org>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Subject: Re: net/wan: hostess_sv11 + z85230 problems
Date: Mon, 15 Oct 2018 15:24:28 -0700 [thread overview]
Message-ID: <dfa87c53-3b26-4473-5166-180760004f1e@infradead.org> (raw)
In-Reply-To: <m34ldnd3ju.fsf@t19.piap.pl>
On 10/15/18 1:20 AM, Krzysztof Hałasa wrote:
> Hi,
>
> Randy Dunlap <rdunlap@infradead.org> writes:
>
>> kernel 4.19-rc7, on i386, with NO wan/hdlc/hostess/z85230 hardware:
>>
>> modprobe hostess_sv11 + autoload of z85230 give:
>
> BTW Hostess SV11 is apparently an ISA card, with all those problems.
Yeah.
>> [ 3162.511877] Call Trace:
...
>
> Not sure about z8530 internals (driver and hw), but I guess the sv11
> driver should initialize the hw first, and only then request_irq().
> Perhaps there should be no "default address" either? The user would
> have to provide the hardware parameters explicitly.
>
> How about this (totally untested):
> Fix the Hostess SV11 driver trying to use the hardware before its
> existence is detected.
>
> Signed-off-by: Krzysztof Halasa <khalasa@piap.pl>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
or you can just rm it, like Alan suggested.
thanks.
--
~Randy
prev parent reply other threads:[~2018-10-15 22:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-14 18:09 net/wan: hostess_sv11 + z85230 problems Randy Dunlap
2018-10-15 8:20 ` Krzysztof Hałasa
2018-10-15 10:29 ` Alan Cox
2018-10-15 12:41 ` Krzysztof Hałasa
2018-10-15 22:24 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfa87c53-3b26-4473-5166-180760004f1e@infradead.org \
--to=rdunlap@infradead.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=khalasa@piap.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).