From: Martin Vuille <jpmv27@aim.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf annotate: Don't prepend symfs path to build_id_filename
Date: Tue, 13 Mar 2018 11:24:17 -0400 [thread overview]
Message-ID: <e036d7fc-7787-3005-93f5-19ebfa339882@aim.com> (raw)
In-Reply-To: <20180309190715.GB25111@kernel.org>
On 03/09/18 14:07, Arnaldo Carvalho de Melo wrote:
> Em Sun, Feb 11, 2018 at 02:19:37PM -0500, Martin Vuille escreveu:
>> build_id_filename already contains symfs path if applicable, so
>> don't prepend it a second time.
> Where is the analysis that shows that that is the case? I looked here at
> the implementation for dso__build_id_filename() and couldn't find where
> was it that the symfs would be appended, can you clarify?
>
> - Arnaldo
>
Patch resubmitted with additional details in commit message:
https://patchwork.kernel.org/patch/10279077/
Regards,
MV
prev parent reply other threads:[~2018-03-13 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-11 19:19 [PATCH] perf annotate: Don't prepend symfs path to build_id_filename Martin Vuille
2018-03-09 19:07 ` Arnaldo Carvalho de Melo
2018-03-09 19:26 ` Martin Vuille
2018-03-13 15:24 ` Martin Vuille [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e036d7fc-7787-3005-93f5-19ebfa339882@aim.com \
--to=jpmv27@aim.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).