From: Adrian Hunter <adrian.hunter@intel.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Michal Simek <michal.simek@xilinx.com>,
Kevin Liu <kliu5@marvell.com>,
Suneel Garapati <suneel.garapati@xilinx.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 4/7] mmc: sdhci: move SDHCI_QUIRK2_CLOCK_DIV_ZERO_BROKEN frequency limit
Date: Thu, 16 Apr 2020 10:43:08 +0300 [thread overview]
Message-ID: <e038a984-2f6d-4940-8d28-e39e060b36c2@intel.com> (raw)
In-Reply-To: <20200415161657.GC19897@qmqm.qmqm.pl>
On 15/04/20 7:16 pm, Michał Mirosław wrote:
> On Wed, Apr 15, 2020 at 04:16:04PM +0300, Adrian Hunter wrote:
>> On 2/04/20 2:54 pm, Michał Mirosław wrote:
>>> Move clock frequency limit for SDHCI_QUIRK2_CLOCK_DIV_ZERO_BROKEN where
>>> it belongs.
>>
>> Did you consider getting rid of SDHCI_QUIRK2_CLOCK_DIV_ZERO_BROKEN and
>> handling it in sdhci-of-arasan instead?
>
> I'm expecting to use this quirk for DDR mode support in other host drivers,
> but I can't test this, yet.
I didn't mean get rid of the functionality. I meant implement it in
sdhci-of-arasan. In general we want to reduce the quirks in sdhci.c and
implement them instead in vendor drivers.
next prev parent reply other threads:[~2020-04-16 7:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 11:54 [PATCH 0/7] SDHCI clock handling fixes and cleanups Michał Mirosław
2020-04-02 11:54 ` [PATCH 3/7] mmc: sdhci: fix SDHCI_QUIRK2_CLOCK_DIV_ZERO_BROKEN Michał Mirosław
2020-04-15 13:06 ` Adrian Hunter
2020-04-15 16:03 ` Michał Mirosław
2020-04-16 7:40 ` Adrian Hunter
2020-04-02 11:54 ` [PATCH 2/7] mmc: sdhci: fix programmable clock config from preset value Michał Mirosław
2020-04-15 12:44 ` Adrian Hunter
2020-04-02 11:54 ` [PATCH 1/7] mmc: sdhci: fix base clock usage in " Michał Mirosław
2020-04-15 12:25 ` Adrian Hunter
2020-04-15 16:28 ` Michał Mirosław
2020-04-16 8:26 ` Adrian Hunter
2020-04-17 13:55 ` Alan Cooper
2020-04-20 5:31 ` Adrian Hunter
2020-04-02 11:54 ` [PATCH 4/7] mmc: sdhci: move SDHCI_QUIRK2_CLOCK_DIV_ZERO_BROKEN frequency limit Michał Mirosław
2020-04-15 13:16 ` Adrian Hunter
2020-04-15 16:16 ` Michał Mirosław
2020-04-16 7:43 ` Adrian Hunter [this message]
2020-04-02 11:54 ` [PATCH 6/7] mmc: sdhci: squash v2/v3+ clock calculation differences Michał Mirosław
2020-04-02 11:54 ` [PATCH 5/7] mmc: sdhci: simplify clock frequency calculation Michał Mirosław
2020-04-03 13:02 ` kbuild test robot
2020-04-03 16:15 ` Michał Mirosław
2020-04-15 13:54 ` Adrian Hunter
2020-04-15 16:45 ` Michał Mirosław
2020-04-02 11:54 ` [PATCH 7/7] mmc: sdhci: respect non-zero div quirk in programmable clock mode Michał Mirosław
2020-04-03 16:03 ` kbuild test robot
2020-04-15 8:52 ` [PATCH 0/7] SDHCI clock handling fixes and cleanups Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e038a984-2f6d-4940-8d28-e39e060b36c2@intel.com \
--to=adrian.hunter@intel.com \
--cc=kliu5@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=suneel.garapati@xilinx.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).