From: "David E. Box" <david.e.box@linux.intel.com>
To: Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Randy Dunlap <rdunlap@infradead.org>,
lee.jones@linaro.org, dvhart@infradead.org, andy@infradead.org,
bhelgaas@google.com
Cc: linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH V3 1/3] PCI: Add defines for Designated Vendor-Specific Capability
Date: Thu, 16 Jul 2020 11:31:25 -0700 [thread overview]
Message-ID: <e051971b327d870476dad209ddf27055d001b9b4.camel@linux.intel.com> (raw)
In-Reply-To: <dc459a96-1434-16bf-80d2-06b0680f9fda@linux.intel.com>
On Thu, 2020-07-16 at 10:18 -0700, Alexander Duyck wrote:
>
> On 7/15/2020 7:55 PM, Randy Dunlap wrote:
> > On 7/13/20 11:23 PM, David E. Box wrote:
> > > Add PCIe DVSEC extended capability ID and defines for the header
> > > offsets.
> > > Defined in PCIe r5.0, sec 7.9.6.
> > >
> > > Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> > > Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> > > ---
> > > include/uapi/linux/pci_regs.h | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/include/uapi/linux/pci_regs.h
> > > b/include/uapi/linux/pci_regs.h
> > > index f9701410d3b5..09daa9f07b6b 100644
> > > --- a/include/uapi/linux/pci_regs.h
> > > +++ b/include/uapi/linux/pci_regs.h
> > > @@ -720,6 +720,7 @@
> > > +#define PCI_EXT_CAP_ID_DVSEC 0x23 /* Designated Vendor-
> > > Specific */
> > > @@ -1062,6 +1063,10 @@
> > > +/* Designated Vendor-Specific (DVSEC, PCI_EXT_CAP_ID_DVSEC) */
> > > +#define PCI_DVSEC_HEADER1 0x4 /* Vendor-Specific
> > > Header1 */
> > > +#define PCI_DVSEC_HEADER2 0x8 /* Vendor-Specific
> > > Header2 */
These comments I'll fix to say "Designated Vendor-Specific"
> >
> > Just a little comment: It would make more sense to me to
> > s/DVSEC/DVSPEC/g.
> >
> > But then I don't have the PCIe documentation.
>
> Arguably some of the confusion might be from the patch title. DVSEC
> is
> acronym for Designated Vendor-Specific Extended Capability if I
> recall
> correctly. It would probably be best to call that out since the
> extended
> implies it lives in the config space accessible via the memory
> mapped
> config.
I'll change the patch title as well, but agree DVSEC is better as it's
consistent with the spec.
Thanks
David
next prev parent reply other threads:[~2020-07-16 18:31 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 1:32 [PATCH 0/3] Intel Platform Monitoring Technology David E. Box
2020-05-05 1:32 ` [PATCH 1/3] pci: Add Designated Vendor Specific Capability David E. Box
2020-05-05 8:49 ` Andy Shevchenko
2020-05-05 15:00 ` David E. Box
2020-05-05 16:34 ` Bjorn Helgaas
2020-05-05 2:31 ` [PATCH 2/3] mfd: Intel Platform Monitoring Technology support David E. Box
2020-05-05 2:31 ` [PATCH 3/3] platform/x86: Intel PMT Telemetry capability driver David E. Box
2020-05-05 13:49 ` Andy Shevchenko
2020-05-05 21:09 ` David E. Box
2020-05-08 2:33 ` David E. Box
2020-05-05 2:53 ` [PATCH 2/3] mfd: Intel Platform Monitoring Technology support Randy Dunlap
2020-05-05 14:55 ` David E. Box
2020-05-05 9:02 ` Andy Shevchenko
2020-05-05 15:15 ` David E. Box
2020-05-08 2:18 ` [PATCH v2 0/3] Intel Platform Monitoring Technology David E. Box
2020-05-08 9:59 ` Andy Shevchenko
2020-07-14 6:23 ` [PATCH V3 " David E. Box
2020-07-17 19:06 ` [PATCH V4 " David E. Box
2020-07-27 10:23 ` Andy Shevchenko
2020-07-27 16:29 ` David E. Box
2020-07-29 21:37 ` [PATCH V5 " David E. Box
2020-08-10 14:15 ` David E. Box
2020-08-10 14:42 ` Umesh A
2020-08-11 8:04 ` Lee Jones
2020-08-11 14:50 ` David E. Box
2020-07-29 21:37 ` [PATCH V5 1/3] PCI: Add defines for Designated Vendor-Specific Extended Capability David E. Box
2020-07-29 21:37 ` [PATCH V5 2/3] mfd: Intel Platform Monitoring Technology support David E. Box
2020-07-29 21:37 ` [PATCH V5 3/3] platform/x86: Intel PMT Telemetry capability driver David E. Box
2020-07-17 19:06 ` [PATCH V4 1/3] PCI: Add defines for Designated Vendor-Specific Extended Capability David E. Box
2020-07-17 20:11 ` Andy Shevchenko
2020-07-17 19:06 ` [PATCH V4 2/3] mfd: Intel Platform Monitoring Technology support David E. Box
2020-07-28 7:58 ` Lee Jones
2020-07-28 20:35 ` David E. Box
2020-07-29 22:59 ` Mark D Rustad
2020-07-30 17:53 ` David E. Box
2020-07-31 6:19 ` Lee Jones
2020-07-17 19:06 ` [PATCH V4 3/3] platform/x86: Intel PMT Telemetry capability driver David E. Box
2020-07-14 6:23 ` [PATCH V3 1/3] PCI: Add defines for Designated Vendor-Specific Capability David E. Box
2020-07-14 8:40 ` Andy Shevchenko
2020-07-16 2:55 ` Randy Dunlap
2020-07-16 15:07 ` Bjorn Helgaas
2020-07-16 15:07 ` Randy Dunlap
2020-07-16 17:18 ` Alexander Duyck
2020-07-16 18:31 ` David E. Box [this message]
2020-07-14 6:23 ` [PATCH V3 2/3] mfd: Intel Platform Monitoring Technology support David E. Box
2020-07-15 5:09 ` kernel test robot
2020-07-14 6:23 ` [PATCH V3 3/3] platform/x86: Intel PMT Telemetry capability driver David E. Box
2020-07-14 8:51 ` Andy Shevchenko
2020-07-15 7:39 ` Alexey Budankov
2020-07-15 23:59 ` David E. Box
2020-07-16 5:57 ` Alexey Budankov
2020-07-16 2:57 ` Randy Dunlap
2020-05-08 2:18 ` [PATCH v2 1/3] PCI: Add defines for Designated Vendor-Specific Capability David E. Box
2020-05-08 2:18 ` [PATCH v2 2/3] mfd: Intel Platform Monitoring Technology support David E. Box
2020-05-08 9:15 ` Andy Shevchenko
2020-05-08 2:18 ` [PATCH v2 3/3] platform/x86: Intel PMT Telemetry capability driver David E. Box
2020-05-08 9:57 ` Andy Shevchenko
2020-05-09 16:27 ` David E. Box
2020-05-20 18:06 [PATCH V3 0/3] PCI: Add basic Compute eXpress Link DVSEC decode Sean V Kelley
2020-05-20 18:06 ` [PATCH V3 1/3] PCI: Add defines for Designated Vendor-Specific Capability Sean V Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e051971b327d870476dad209ddf27055d001b9b4.camel@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=andy@infradead.org \
--cc=bhelgaas@google.com \
--cc=dvhart@infradead.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).