From: Li Tuo <islituo@gmail.com>
To: thomas@winischhofer.net
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, baijiaju1990@gmail.com
Subject: [BUG] video: fbdev: sis: possible uninitialized-variable access in SiS_SetCRT2FIFO_300()
Date: Sat, 31 Jul 2021 14:28:39 +0800 [thread overview]
Message-ID: <e0f988f3-f010-6299-d000-5c035e5f2e2e@gmail.com> (raw)
Hello,
Our static analysis tool finds a possible uninitialized-variable access
in the sis driver in Linux 5.14.0-rc3:
At the beginning of the function SiS_SetCRT2FIFO_300(), the variable
modeidindex is not initialized.
If the following conditions are false, it remains uninitialized.
5346: if(!SiS_Pr->CRT1UsesCustomMode)
5438: if(!SiS_Pr->UseCustomMode)
But it is accessed at:
5466: colorth = SiS_GetColorDepth(SiS_Pr,CRT2ModeNo,modeidindex) >> 1;
I am not quite sure whether this possible uninitialized-variable access
is real and how to fix it if it is real.
Any feedback would be appreciated, thanks!
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Best wishes,
Tuo Li
reply other threads:[~2021-07-31 6:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0f988f3-f010-6299-d000-5c035e5f2e2e@gmail.com \
--to=islituo@gmail.com \
--cc=baijiaju1990@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).