From: Florian Fainelli <f.fainelli@gmail.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
bhelgaas@google.com, robh+dt@kernel.org,
tsbogend@alpha.franken.de, lorenzo.pieralisi@arm.com,
p.zabel@pengutronix.de, jiaxun.yang@flygoat.com,
paulburton@kernel.org, info@metux.net, allison@lohutok.net,
kstewart@linuxfoundation.org, tglx@linutronix.de,
jonas.gorski@gmail.com, bcm-kernel-feedback-list@broadcom.com,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: Document BCM6328 PCIe Host Controller
Date: Wed, 17 Jun 2020 14:50:35 -0700 [thread overview]
Message-ID: <e4831ec7-dfe7-ce4d-585f-bf11a1cb1baa@gmail.com> (raw)
In-Reply-To: <20200617102556.3792821-3-noltari@gmail.com>
On 6/17/2020 3:25 AM, Álvaro Fernández Rojas wrote:
> BCM6328 PCIe host controller is found on BCM6328, BCM6362 and BCM63268 SoCs.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
> .../bindings/pci/brcm,bcm6328-pcie.yaml | 109 ++++++++++++++++++
> 1 file changed, 109 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pci/brcm,bcm6328-pcie.yaml
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,bcm6328-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,bcm6328-pcie.yaml
> new file mode 100644
> index 000000000000..d2bd4933a5fa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pci/brcm,bcm6328-pcie.yaml
> @@ -0,0 +1,109 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pci/brcm,bcm6328-pcie.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: BCM6328 PCIe Host Controller Device Tree Bindings
> +
> +maintainers:
> + - Álvaro Fernández Rojas <noltari@gmail.com>
> +
> +allOf:
> + - $ref: /schemas/pci/pci-bus.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - brcm,bcm6328-pcie
> + - brcm,bcm6362-pcie
> + - brcm,bcm63268-pcie
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: pcie
> +
> + "#interrupt-cells":
> + const: 1
> +
> + interrupt-map-mask:
> + maxItems: 1
> +
> + interrupt-map:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + ranges:
> + maxItems: 1
> +
> + reg:
> + maxItems: 1
> +
> + resets:
> + maxItems: 4
> +
> + reset-names:
> + items:
> + - const: pcie
> + - const: pcie-core
> + - const: pcie-ext
> + - const: pcie-hard
> +
> +required:
> + - brcm,serdes
> + - clocks
> + - clock-names
> + - "#interrupt-cells"
> + - interrupt-map-mask
> + - interrupt-map
> + - ranges
> + - reg
> + - resets
> + - reset-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + serdes_cntl: syscon@10001800 {
> + compatible = "syscon";
> + reg = <0x10001800 0x4>;
> + native-endian;
> + };
I believe you could be modelling the SerDes as generic PHY driver which
would be a little cleaner than the syscon approach. In newer chips like
6318 it looks like you should be able to use pcie-brcmstb.c since the
controller appears to be nearly the same and the PHY abstraction would
work nicely there.
--
Florian
next prev parent reply other threads:[~2020-06-17 21:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 10:25 [PATCH 0/3] mips: bmips: add BCM6328 PCIe support Álvaro Fernández Rojas
2020-06-17 10:25 ` [PATCH 1/3] mips: bmips: add PCI support Álvaro Fernández Rojas
2020-06-17 11:09 ` Thomas Bogendoerfer
2020-06-17 10:25 ` [PATCH 2/3] dt-bindings: Document BCM6328 PCIe Host Controller Álvaro Fernández Rojas
2020-06-17 17:07 ` Rob Herring
2020-06-17 21:50 ` Florian Fainelli [this message]
2020-06-17 10:25 ` [PATCH 3/3] pci: add BCM6328 PCIe controller support Álvaro Fernández Rojas
2020-06-17 15:50 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4831ec7-dfe7-ce4d-585f-bf11a1cb1baa@gmail.com \
--to=f.fainelli@gmail.com \
--cc=allison@lohutok.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=info@metux.net \
--cc=jiaxun.yang@flygoat.com \
--cc=jonas.gorski@gmail.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=noltari@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=paulburton@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).