From: Dave Hansen <dave.hansen@intel.com>
To: Ashok Raj <ashok.raj@intel.com>, Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>, X86-kernel <x86@kernel.org>,
LKML Mailing List <linux-kernel@vger.kernel.org>,
Tony Luck <tony.luck@intel.com>, Ingo Molnar <mingo@kernel.org>,
alison.schofield@intel.com, reinette.chatre@intel.com,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH v4 6/6] x86/microcode/intel: Print when early microcode loading fails
Date: Tue, 17 Jan 2023 08:29:28 -0800 [thread overview]
Message-ID: <e491fe87-2c2a-e9d2-3cd9-dfc7535f7c27@intel.com> (raw)
In-Reply-To: <Y8bI4BBst78qrApD@a4bf019067fa.jf.intel.com>
On 1/17/23 08:12, Ashok Raj wrote:
> On Sun, Jan 15, 2023 at 08:05:14PM +0100, Borislav Petkov wrote:
>> On Mon, Jan 09, 2023 at 07:35:55AM -0800, Ashok Raj wrote:
>>> Currently when early microcode loading fails there is no way for the
>>> user to know that the update failed.
>> Of course there is - there's no early update message in dmesg.
> Sorry Boris, didn't comprehend.
>
> Without user making some additional steps to check the revision in the
> default location and the current rev reported to find the update failed.
>
> Maybe that's what you meant.
I think a better changelog might help here. The original was a bit too
absolute. There is, as Boris pointed out, a way to tell if a failure
occurred. But, that method is a bit unfriendly to our users.
--
When early microcode loading succeeds, the kernel prints a message via
print_ucode_info() that starts with 'early update:'. If loading fails,
apply_microcode_early() returns before that message is printed. This
means that users must know to go looking for that message. They can
infer a early microcode loading failure if they do not see the message.
That's not great for users. Instead of expecting them to infer this, be
more explicit about it. Instead of bailing out and returning from
apply_microcode_early(), stash the error code off and plumb it down to
print_ucode_info().
This ensures that a message of some kind is printed on all early loads:
successes *and* failures. This should make it easier for our hapless
users to figure out when a failure occurred.
next prev parent reply other threads:[~2023-01-17 16:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 15:35 [PATCH v4 0/6] Some fixes and cleanups for microcode Ashok Raj
2023-01-09 15:35 ` [PATCH v4 1/6] x86/microcode: Add a parameter to microcode_check() to store CPU capabilities Ashok Raj
2023-01-21 14:54 ` [tip: x86/microcode] " tip-bot2 for Ashok Raj
2023-01-09 15:35 ` [PATCH v4 2/6] x86/microcode/core: Take a snapshot before and after applying microcode Ashok Raj
2023-01-21 14:54 ` [tip: x86/microcode] x86/microcode: Check CPU capabilities after late microcode update correctly tip-bot2 for Ashok Raj
2023-01-09 15:35 ` [PATCH v4 3/6] x86/microcode: Display revisions only when update is successful Ashok Raj
2023-01-09 15:35 ` [PATCH v4 4/6] x86/microcode/intel: Use a plain revision argument for print_ucode_rev() Ashok Raj
2023-01-15 19:25 ` Borislav Petkov
2023-01-15 19:39 ` Borislav Petkov
2023-01-17 16:05 ` Ashok Raj
2023-01-17 18:16 ` Borislav Petkov
2023-01-09 15:35 ` [PATCH v4 5/6] x86/microcode/intel: Print old and new rev during early boot Ashok Raj
2023-01-09 15:35 ` [PATCH v4 6/6] x86/microcode/intel: Print when early microcode loading fails Ashok Raj
2023-01-15 19:05 ` Borislav Petkov
2023-01-17 16:12 ` Ashok Raj
2023-01-17 16:29 ` Dave Hansen [this message]
2023-01-17 18:21 ` Borislav Petkov
2023-01-17 18:32 ` Dave Hansen
2023-01-17 18:40 ` Borislav Petkov
2023-01-17 20:40 ` Ashok Raj
2023-01-17 20:58 ` Luck, Tony
2023-01-19 17:59 ` Ashok Raj
2023-01-20 12:03 ` Borislav Petkov
2023-01-20 16:52 ` Ashok Raj
2023-01-17 21:00 ` Dave Hansen
2023-01-17 21:06 ` Borislav Petkov
2023-01-17 21:34 ` Ashok Raj
2023-01-17 19:10 ` Ashok Raj
2023-01-17 16:35 ` Dave Hansen
2023-01-17 17:59 ` Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e491fe87-2c2a-e9d2-3cd9-dfc7535f7c27@intel.com \
--to=dave.hansen@intel.com \
--cc=alison.schofield@intel.com \
--cc=ashok.raj@intel.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).