From: Vivek Gautam <vivek.gautam@codeaurora.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Evan Green <evgreen@chromium.org>, Rob Herring <robh@kernel.org>,
Andy Gross <andy.gross@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Stephen Boyd <swboyd@chromium.org>,
cang@codeaurora.org, LKML <linux-kernel@vger.kernel.org>,
Manu Gautam <mgautam@codeaurora.org>
Subject: Re: [PATCH v4 2/5] phy: qcom-qmp: Utilize fully-specified DT registers
Date: Thu, 25 Oct 2018 11:45:59 +0530 [thread overview]
Message-ID: <e4b227a63e8c803e4758c7bb8fd62d9f@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=VoBLh+SFmo8NieRT6LrOopkKRE86xiEMt_ap2gyDZXWw@mail.gmail.com>
On 2018-10-25 02:06, Doug Anderson wrote:
> Hi,
>
> On Wed, Oct 24, 2018 at 11:29 AM Vivek Gautam
> <vivek.gautam@codeaurora.org> wrote:
>> Thanks for the patch.
>> I am starting to think that the driver is heavily relying on the
>> resource indices to request
>> all these areas ioremapped. Is it a good way forward that driver and
>> the
>> dt bindings are
>> chained together?
>> Should we rather switch to requesting these resources by some names?
>>
>> Rob can comment on this possibly.
>
> I thought about suggesting that but I know that Rob really doesn't
> like accessing register ranges by name [1]. Even in cases where you
> reference things by name Rob likes there to be a fully defined order
> and once you have a fully defined order you don't really need the
> names unless you have more than one optional register range.
Right, I second that. I was looking for options. :)
>
> In any case, Rob already gave his review to Evan's bindings change.
> See:
>
> https://lore.kernel.org/r/20181023002903.GA16854@bogus
Yea, I saw that too.
Best regards
Vivek
>
> ...so my vote would be to keep it as Evan's patch series has it and
> not try to bikeshed it.
>
>
>> Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org>
>
> Thanks for the review!
>
>
> [1]
> https://lkml.kernel.org/r/CAL_Jsq+MMunmVWqeW9v2RyzsMKP+=kMzeTHNMG4JDHM7Fy0HBg@mail.gmail.com
>
> -Doug
next prev parent reply other threads:[~2018-10-25 6:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 17:27 [PATCH v4 0/5] arm64: dts: qcom: sdm845: Add UFS DT nodes Evan Green
2018-10-24 17:27 ` [PATCH v4 1/5] dt-bindings: phy-qcom-qmp: Fix register underspecification Evan Green
2018-10-24 17:27 ` [PATCH v4 2/5] phy: qcom-qmp: Utilize fully-specified DT registers Evan Green
2018-10-24 18:29 ` Vivek Gautam
2018-10-24 20:36 ` Doug Anderson
2018-10-25 6:15 ` Vivek Gautam [this message]
2018-10-24 17:27 ` [PATCH v4 3/5] arm64: dts: qcom: sdm845: add UFS controller Evan Green
2018-10-24 17:27 ` [PATCH v4 4/5] arm64: dts: qcom: sdm845: Add UFS nodes for sdm845-mtp Evan Green
2018-10-24 17:27 ` [PATCH v4 5/5] arm64: dts: qcom: sdm845: Add USB PHY lane two Evan Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4b227a63e8c803e4758c7bb8fd62d9f@codeaurora.org \
--to=vivek.gautam@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=cang@codeaurora.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).