From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Ansuel Smith <ansuelsmth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v6 09/18] clk: qcom: krait-cc: drop pr_info and register qsb only if needed
Date: Wed, 13 Apr 2022 22:40:39 +0300 [thread overview]
Message-ID: <e50de775-731b-d8e5-ad0f-794903fbed92@linaro.org> (raw)
In-Reply-To: <20220321231548.14276-10-ansuelsmth@gmail.com>
On 22/03/2022 02:15, Ansuel Smith wrote:
> Replace pr_info() with dev_info() to provide better diagnostics.
> Register qsb fixed clk only if it's not declared in DTS.
This can be split into two patches
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> drivers/clk/qcom/krait-cc.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/clk/qcom/krait-cc.c b/drivers/clk/qcom/krait-cc.c
> index 645ad9e8dd73..e9508e3104ea 100644
> --- a/drivers/clk/qcom/krait-cc.c
> +++ b/drivers/clk/qcom/krait-cc.c
> @@ -308,7 +308,9 @@ static int krait_cc_probe(struct platform_device *pdev)
> return -ENODEV;
>
> /* Rate is 1 because 0 causes problems for __clk_mux_determine_rate */
> - clk = clk_register_fixed_rate(dev, "qsb", NULL, 0, 1);
> + if (IS_ERR(clk_get(dev, "qsb")))
> + clk = clk_register_fixed_rate(dev, "qsb", NULL, 0, 1);
> +
> if (IS_ERR(clk))
> return PTR_ERR(clk);
>
> @@ -363,25 +365,25 @@ static int krait_cc_probe(struct platform_device *pdev)
> cur_rate = clk_get_rate(l2_pri_mux_clk);
> aux_rate = 384000000;
> if (cur_rate == 1) {
> - pr_info("L2 @ QSB rate. Forcing new rate.\n");
> + dev_info(dev, "L2 @ QSB rate. Forcing new rate.\n");
> cur_rate = aux_rate;
> }
> clk_set_rate(l2_pri_mux_clk, aux_rate);
> clk_set_rate(l2_pri_mux_clk, 2);
> clk_set_rate(l2_pri_mux_clk, cur_rate);
> - pr_info("L2 @ %lu KHz\n", clk_get_rate(l2_pri_mux_clk) / 1000);
> + dev_info(dev, "L2 @ %lu KHz\n", clk_get_rate(l2_pri_mux_clk) / 1000);
> for_each_possible_cpu(cpu) {
> clk = clks[cpu];
> cur_rate = clk_get_rate(clk);
> if (cur_rate == 1) {
> - pr_info("CPU%d @ QSB rate. Forcing new rate.\n", cpu);
> + dev_info(dev, "CPU%d @ QSB rate. Forcing new rate.\n", cpu);
> cur_rate = aux_rate;
> }
>
> clk_set_rate(clk, aux_rate);
> clk_set_rate(clk, 2);
> clk_set_rate(clk, cur_rate);
> - pr_info("CPU%d @ %lu KHz\n", cpu, clk_get_rate(clk) / 1000);
> + dev_info(dev, "CPU%d @ %lu KHz\n", cpu, clk_get_rate(clk) / 1000);
> }
>
> of_clk_add_provider(dev->of_node, krait_of_get, clks);
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-04-13 19:40 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 23:15 [PATCH v6 00/18] Modernize rest of the krait drivers Ansuel Smith
2022-03-21 23:15 ` [PATCH v6 01/18] clk: introduce clk_hw_get_index_of_parent new API Ansuel Smith
2022-03-25 1:21 ` Stephen Boyd
2022-03-21 23:15 ` [PATCH v6 02/18] clk: qcom: gcc-ipq806x: skip pxo/cxo fixed clk if already present Ansuel Smith
2022-03-25 1:11 ` Stephen Boyd
2022-03-21 23:15 ` [PATCH v6 03/18] clk: qcom: gcc-ipq806x: add PXO_SRC in clk table Ansuel Smith
2022-03-25 1:10 ` Stephen Boyd
2022-03-25 1:13 ` Ansuel Smith
2022-03-25 1:22 ` Stephen Boyd
2022-04-13 17:00 ` Ansuel Smith
2022-04-13 17:32 ` Dmitry Baryshkov
2022-04-13 17:54 ` Ansuel Smith
2022-04-13 20:01 ` Dmitry Baryshkov
2022-03-21 23:15 ` [PATCH v6 04/18] clk: qcom: clk-hfpll: use poll_timeout macro Ansuel Smith
2022-03-25 1:09 ` Stephen Boyd
2022-03-21 23:15 ` [PATCH v6 05/18] clk: qcom: kpss-xcc: convert to parent data API Ansuel Smith
2022-03-25 1:06 ` Stephen Boyd
2022-03-25 1:10 ` Ansuel Smith
2022-04-13 19:38 ` Dmitry Baryshkov
2022-03-21 23:15 ` [PATCH v6 06/18] clk: qcom: clk-krait: unlock spin after mux completion Ansuel Smith
2022-03-25 1:04 ` Stephen Boyd
2022-03-21 23:15 ` [PATCH v6 07/18] clk: qcom: clk-krait: add hw_parent check for div2_round_rate Ansuel Smith
2022-03-21 23:15 ` [PATCH v6 08/18] clk: qcom: krait-cc: convert to parent_data API Ansuel Smith
2022-03-21 23:15 ` [PATCH v6 09/18] clk: qcom: krait-cc: drop pr_info and register qsb only if needed Ansuel Smith
2022-04-13 19:40 ` Dmitry Baryshkov [this message]
2022-03-21 23:15 ` [PATCH v6 10/18] clk: qcom: krait-cc: drop hardcoded safe_sel Ansuel Smith
2022-04-13 17:25 ` Dmitry Baryshkov
2022-04-13 17:35 ` Ansuel Smith
2022-04-13 18:24 ` Dmitry Baryshkov
2022-03-21 23:15 ` [PATCH v6 11/18] clk: qcom: krait-cc: force sec_mux to QSB Ansuel Smith
2022-03-21 23:15 ` [PATCH v6 12/18] clk: qcom: clk-krait: add apq/ipq8064 errata workaround Ansuel Smith
2022-03-21 23:15 ` [PATCH v6 13/18] clk: qcom: clk-krait: add enable disable ops Ansuel Smith
2022-04-13 17:28 ` Dmitry Baryshkov
2022-03-21 23:15 ` [PATCH v6 14/18] dt-bindings: clock: Convert qcom,krait-cc to yaml Ansuel Smith
2022-03-21 23:15 ` [PATCH v6 15/18] dt-bindings: clock: Add L2 clocks to qcom,krait-cc Documentation Ansuel Smith
2022-03-23 15:27 ` Rob Herring
2022-03-21 23:15 ` [PATCH v6 16/18] dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml Ansuel Smith
2022-03-22 10:11 ` Krzysztof Kozlowski
2022-03-21 23:15 ` [PATCH v6 17/18] dt-bindings: arm: msm: Convert kpss-gcc " Ansuel Smith
2022-03-22 1:50 ` Rob Herring
2022-03-23 10:29 ` Ansuel Smith
2022-03-23 13:19 ` Rob Herring
2022-03-22 10:07 ` Krzysztof Kozlowski
2022-03-22 13:26 ` Ansuel Smith
2022-03-23 9:59 ` Krzysztof Kozlowski
2022-03-23 11:03 ` Ansuel Smith
2022-03-23 14:19 ` Krzysztof Kozlowski
2022-03-21 23:15 ` [PATCH v6 18/18] ARM: dts: qcom: qcom-ipq8064: add missing krait-cc compatible and clocks Ansuel Smith
2022-03-22 10:01 ` Krzysztof Kozlowski
2022-03-22 1:56 ` [PATCH v6 00/18] Modernize rest of the krait drivers Rob Herring
2022-03-22 13:43 ` Ansuel Smith
2022-04-13 17:31 ` Dmitry Baryshkov
2022-04-13 17:48 ` Ansuel Smith
2022-04-13 19:49 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e50de775-731b-d8e5-ad0f-794903fbed92@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).