From: Waiman Long <longman@redhat.com>
To: kernel test robot <oliver.sang@intel.com>
Cc: oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org, aubrey.li@linux.intel.com,
yu.c.chen@intel.com, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Phil Auld <pauld@redhat.com>, Brent Rowsell <browsell@redhat.com>,
Peter Hunt <pehunt@redhat.com>
Subject: Re: [PATCH v2] sched/core: Use empty mask to reset cpumasks in sched_setaffinity()
Date: Thu, 3 Aug 2023 12:03:00 -0400 [thread overview]
Message-ID: <e603b6cc-35ee-f22e-ba50-73bd5caefa20@redhat.com> (raw)
In-Reply-To: <202307251613.4f2de1be-oliver.sang@intel.com>
On 7/25/23 09:07, kernel test robot wrote:
>
> Hello,
>
> kernel test robot noticed "kernel-selftests.vDSO.vdso_test_correctness.fail" on:
>
> commit: 8bd21fae1e37284f0f78fa42fb4d20a6cadfa68a ("[PATCH v2] sched/core: Use empty mask to reset cpumasks in sched_setaffinity()")
> url: https://github.com/intel-lab-lkp/linux/commits/Waiman-Long/sched-core-Use-empty-mask-to-reset-cpumasks-in-sched_setaffinity/20230718-194823
> base: https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git 2ae2fb98b77339277a2c2f18dfec605dfd8dd321
> patch link: https://lore.kernel.org/all/20230717180243.3607603-1-longman@redhat.com/
> patch subject: [PATCH v2] sched/core: Use empty mask to reset cpumasks in sched_setaffinity()
>
> in testcase: kernel-selftests
> version: kernel-selftests-x86_64-60acb023-1_20230329
> with following parameters:
>
> group: group-03
>
>
>
> compiler: gcc-12
> test machine: 36 threads 1 sockets Intel(R) Core(TM) i9-10980XE CPU @ 3.00GHz (Cascade Lake) with 32G memory
>
> (please refer to attached dmesg/kmsg for entire log/backtrace)
> # [OK] CPU 34: syscall: cpu 34, node 0 vdso: cpu 34, node 0 vsyscall: cpu 34, node 0
> # [OK] CPU 35: syscall: cpu 35, node 0 vdso: cpu 35, node 0 vsyscall: cpu 35, node 0
> # [FAIL] CPU 36: syscall: cpu 35, node 0 vdso: cpu 35, node 0 vsyscall: cpu 35, node 0
> not ok 6 selftests: vDSO: vdso_test_correctness # exit=1
I have figured out what this fail. The vdso_test_correctness.c test
calls sched_setaffinity() from cpu 0 and up until it hits an error
return. There are 36 CPUs in the test system and once the CPU number hit
36, the cpumask_empty() test in sched_setaffinity() returns true causing
a non-error return.
It seems like I need to always return an error code to not break
existing test program, but perhaps with a different error code to
indicate some action is done.
Cheers,
Longman
prev parent reply other threads:[~2023-08-03 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 18:02 [PATCH v2] sched/core: Use empty mask to reset cpumasks in sched_setaffinity() Waiman Long
2023-07-21 9:42 ` Peter Zijlstra
2023-08-03 17:43 ` Waiman Long
2023-07-25 13:07 ` kernel test robot
2023-08-03 16:03 ` Waiman Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e603b6cc-35ee-f22e-ba50-73bd5caefa20@redhat.com \
--to=longman@redhat.com \
--cc=aubrey.li@linux.intel.com \
--cc=bristot@redhat.com \
--cc=browsell@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=pauld@redhat.com \
--cc=pehunt@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).