From: Egil Hjelmeland <privat@egil-hjelmeland.no>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 2/6] net: dsa: return after mdb prepare phase
Date: Thu, 9 Nov 2017 09:48:40 +0100 [thread overview]
Message-ID: <e7712b0f-538e-e2d6-b091-c3dc7be359e7@egil-hjelmeland.no> (raw)
In-Reply-To: <20171108171917.5965-3-vivien.didelot@savoirfairelinux.com>
On 08. nov. 2017 18:19, Vivien Didelot wrote:
> The current code does not return after successfully preparing the MDB
> addition on every ports member of a multicast group. Fix this.
>
> Fixes: a1a6b7ea7f2d ("net: dsa: add cross-chip multicast support")
> Reported-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---
> net/dsa/switch.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/dsa/switch.c b/net/dsa/switch.c
> index 04e8ad2c3d5d..0041aba5c339 100644
> --- a/net/dsa/switch.c
> +++ b/net/dsa/switch.c
> @@ -133,6 +133,8 @@ static int dsa_switch_mdb_add(struct dsa_switch *ds,
> if (err)
> return err;
> }
> +
> + return 0;
> }
>
> for_each_set_bit(port, group, ds->num_ports)
>
Hi Vivien!
Will this cause a merge-conflict with the "net" patch you sent, when
"net" is merged to "net-next"? Perhaps more polite to hold on to this
(and following patches) until "net" patch has trickled through the system?
Regards
Egil
next prev parent reply other threads:[~2017-11-09 8:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 17:19 [PATCH net-next 0/6] net: dsa: simplify switchdev prepare phase Vivien Didelot
2017-11-08 17:19 ` [PATCH net-next 1/6] net: dsa: remove trans argument from mdb ops Vivien Didelot
2017-11-09 9:04 ` Egil Hjelmeland
2017-11-09 15:06 ` Vivien Didelot
2017-11-08 17:19 ` [PATCH net-next 2/6] net: dsa: return after mdb prepare phase Vivien Didelot
2017-11-09 8:48 ` Egil Hjelmeland [this message]
2017-11-08 17:19 ` [PATCH net-next 3/6] net: dsa: add switch mdb bitmap functions Vivien Didelot
2017-11-08 17:19 ` [PATCH net-next 4/6] net: dsa: remove trans argument from vlan ops Vivien Didelot
2017-11-08 17:49 ` Joe Perches
2017-11-08 19:05 ` Vivien Didelot
2017-11-08 17:19 ` [PATCH net-next 5/6] net: dsa: return after vlan prepare phase Vivien Didelot
2017-11-08 17:19 ` [PATCH net-next 6/6] net: dsa: add switch vlan bitmap functions Vivien Didelot
2017-11-11 6:50 ` [PATCH net-next 0/6] net: dsa: simplify switchdev prepare phase David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7712b0f-538e-e2d6-b091-c3dc7be359e7@egil-hjelmeland.no \
--to=privat@egil-hjelmeland.no \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).