From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
mkarthik@nvidia.com, smohammed@nvidia.com, talho@nvidia.com
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH V2 1/4] i2c: tegra: Sort all the include headers alphabetically
Date: Fri, 25 Jan 2019 00:31:34 +0300 [thread overview]
Message-ID: <e896f4af-1c20-3188-f1f8-253ce4893a50@gmail.com> (raw)
In-Reply-To: <1548363113-25969-1-git-send-email-skomatineni@nvidia.com>
24.01.2019 23:51, Sowjanya Komatineni пишет:
> This patch sorts all the include headers alphabetically for the
> I2C tegra driver
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> ---
> [V2] : Added this in V2 to sort the headers in tegra I2C
>
> drivers/i2c/busses/i2c-tegra.c | 21 ++++++++++-----------
> 1 file changed, 10 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index e417ebf7628c..ef854be4c837 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -6,24 +6,23 @@
> * Author: Colin Cross <ccross@android.com>
> */
>
> -#include <linux/kernel.h>
> -#include <linux/init.h>
> -#include <linux/platform_device.h>
> +#include <asm/unaligned.h>
What about to clean up the includes as well? Seems <asm/unaligned.h> is not needed by the code.
> #include <linux/clk.h>
> +#include <linux/delay.h>
> #include <linux/err.h>
> #include <linux/i2c.h>
> -#include <linux/io.h>
> +#include <linux/init.h>
> #include <linux/interrupt.h>
> -#include <linux/delay.h>
> -#include <linux/slab.h>
> -#include <linux/of_device.h>
> +#include <linux/io.h>
> +#include <linux/iopoll.h>
> +#include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/reset.h>
> +#include <linux/of_device.h>
> #include <linux/pinctrl/consumer.h>
> +#include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> -#include <linux/iopoll.h>
> -
> -#include <asm/unaligned.h>
> +#include <linux/reset.h>
> +#include <linux/slab.h>
>
> #define TEGRA_I2C_TIMEOUT (msecs_to_jiffies(1000))
> #define BYTES_PER_FIFO_WORD 4
>
prev parent reply other threads:[~2019-01-24 21:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 20:51 [PATCH V2 1/4] i2c: tegra: Sort all the include headers alphabetically Sowjanya Komatineni
2019-01-24 20:51 ` [PATCH V2 2/4] i2c: tegra: Update I2C transfer using buffer Sowjanya Komatineni
2019-01-25 19:55 ` Dmitry Osipenko
2019-01-25 20:20 ` Sowjanya Komatineni
2019-01-25 21:25 ` Dmitry Osipenko
2019-01-25 23:22 ` Dmitry Osipenko
2019-01-25 23:26 ` Sowjanya Komatineni
2019-01-24 20:51 ` [PATCH V2 3/4] i2c: tegra: Add DMA Support Sowjanya Komatineni
2019-01-25 19:34 ` Dmitry Osipenko
2019-01-25 20:31 ` Sowjanya Komatineni
2019-01-25 20:40 ` Dmitry Osipenko
2019-01-25 21:11 ` Sowjanya Komatineni
2019-01-25 21:49 ` Dmitry Osipenko
2019-01-25 22:09 ` Dmitry Osipenko
2019-01-25 22:22 ` Sowjanya Komatineni
2019-01-25 23:10 ` Thierry Reding
2019-01-25 23:29 ` Sowjanya Komatineni
2019-01-25 22:03 ` Dmitry Osipenko
2019-01-25 22:35 ` Dmitry Osipenko
2019-01-26 0:28 ` Dmitry Osipenko
2019-01-26 0:49 ` Dmitry Osipenko
2019-01-26 1:51 ` Sowjanya Komatineni
2019-01-24 20:51 ` [PATCH V2 4/4] i2c: tegra: Update transfer timeout Sowjanya Komatineni
2019-01-24 21:31 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e896f4af-1c20-3188-f1f8-253ce4893a50@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkarthik@nvidia.com \
--cc=skomatineni@nvidia.com \
--cc=smohammed@nvidia.com \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).