From: Jens Axboe <axboe@kernel.dk>
To: Tejun Heo <tj@kernel.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH 2/2] blkcg: don't offline parent blkcg first
Date: Wed, 1 Apr 2020 14:57:59 -0600 [thread overview]
Message-ID: <e9ffddda-80e4-2759-e518-99def5ed8156@kernel.dk> (raw)
In-Reply-To: <20200401203551.GV162390@mtj.duckdns.org>
On 4/1/20 2:35 PM, Tejun Heo wrote:
> On Wed, Jul 24, 2019 at 10:37:55AM -0700, Tejun Heo wrote:
>> blkcg->cgwb_refcnt is used to delay blkcg offlining so that blkgs
>> don't get offlined while there are active cgwbs on them. However, it
>> ends up making offlining unordered sometimes causing parents to be
>> offlined before children.
>>
>> Let's fix this by making child blkcgs pin the parents' online states.
>>
>> Note that pin/unpin names are chosen over get/put intentionally
>> because css uses get/put online for something different.
>>
>> Signed-off-by: Tejun Heo <tj@kernel.org>
>
> Jens, these two patches slipped through the cracks. Can you please take a look
> at them?
Huh indeed, looks fine to me. I'll add for 5.7, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-04-01 20:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 17:35 [PATCH 1/2] blkcg: rename blkcg->cgwb_refcnt to ->online_pin and always use it Tejun Heo
2019-07-24 17:37 ` [PATCH RESEND " Tejun Heo
2019-07-24 17:37 ` [PATCH 2/2] blkcg: don't offline parent blkcg first Tejun Heo
2020-04-01 20:35 ` Tejun Heo
2020-04-01 20:57 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9ffddda-80e4-2759-e518-99def5ed8156@kernel.dk \
--to=axboe@kernel.dk \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).