From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3662CC43143 for ; Sat, 29 Sep 2018 17:40:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE94A20895 for ; Sat, 29 Sep 2018 17:40:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jiTYga9Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE94A20895 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728566AbeI3AJy (ORCPT ); Sat, 29 Sep 2018 20:09:54 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:38684 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728377AbeI3AJy (ORCPT ); Sat, 29 Sep 2018 20:09:54 -0400 Received: by mail-wm1-f65.google.com with SMTP id 193-v6so3538541wme.3; Sat, 29 Sep 2018 10:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Yl3+17qjZbQKNaFz//PVUbiQnlLnq7JD/co8P/q47Kk=; b=jiTYga9Yfp1fiECmI0oSopK8YihdyzY2Oc96rCkoNRxRShb68mHXunb+7dYJxxUCwk 6GoRm15LTnxIB/dTvGMFbr1aU+jIc5/k9hnbhPIFfnwrWS77swbCmBEiS/28l9wHqXRQ w8c3gQFjCJ5Mki8ABEPyuhkVG2+Kb7jW1r9YSTCrRw8NSwK438JLIKfE4r3YKTaYM3np wRSOGKhBNNqvSENxxodT3YuG+R3MisuJCYuaRPDxrsMgS7t48vA+cDkZezxn00nLeMHR dgzWNijKHQ/c1k2y7rwoIht1LwxQQUVp81JayjGo7dLIGD/eeJyoov4Rcast3RYmStW1 0YsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Yl3+17qjZbQKNaFz//PVUbiQnlLnq7JD/co8P/q47Kk=; b=uFgSmK8nYyXsI1qVU7GoFhL/qU4oufXQ5HR1XYvX7WW4IRogXFoH2f7vhNiVy8uuyl 2VTCbnn2XUV6PblvgpPKdKa7UH2/cx8WZJMKerxa7SgYeOgRlhvYPp59g2BZm/R3qMUR zxERs5nyPyLaTI7eGYocoB62QSx9XGp94BcXcPja+uGG7CKh4LJrez0HW0qdvCOuHqrn zqYaMLxM5stNenhDVzfebqbAtPLrM6GEd1brH86VbQc/oWVzWekxcwJEpqCGo8LkFwJj uM+uSD/bU6eX6j/FNo04lsx3JQQx4NVyfVxPsnIDb2GtDpRTY4r9SPZemJ48STLXvyAs j40A== X-Gm-Message-State: ABuFfohyTA2eEyteatYb6y0WcLNuCIAFs+1VkjRJQuaFPKOxK+wevqK0 wTLD1sfbrVNcOr63kUxpKTof5t5O X-Google-Smtp-Source: ACcGV607Ej10REe8qpAIA+I9HYD7FvaCg2BvRZq4vENhUTn0YChdAcI7De3SrCNFoMxPMFWf5pUFxQ== X-Received: by 2002:a1c:2bc3:: with SMTP id r186-v6mr5018723wmr.71.1538242834558; Sat, 29 Sep 2018 10:40:34 -0700 (PDT) Received: from [172.30.1.236] (nat-wv.mentorg.com. [192.94.38.34]) by smtp.gmail.com with ESMTPSA id i131-v6sm4728203wmg.26.2018.09.29.10.40.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Sep 2018 10:40:33 -0700 (PDT) Subject: Re: [PATCH v6 02/17] media: v4l2: async: Allow searching for asd of any type To: Sakari Ailus , Steve Longerbeam Cc: Sakari Ailus , Mauro Carvalho Chehab , linux-media@vger.kernel.org, Mauro Carvalho Chehab , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Hans Verkuil , Sebastian Reichel , open list References: <1531175957-1973-1-git-send-email-steve_longerbeam@mentor.com> <1531175957-1973-3-git-send-email-steve_longerbeam@mentor.com> <20180924140604.23e2b56f@coco.lan> <20180925192045.59c83e3d@coco.lan> <36fd43b2-695d-b990-bec2-c4d88ccb8e88@mentor.com> <20180926063335.3c3b863d@coco.lan> <20180926104038.tc3u7vzojumcthen@kekkonen.localdomain> <89ff305e-4b0a-b59d-bb4f-99e8e6cfde90@mentor.com> <20180928121631.6nobkbegwnfeerpb@valkosipuli.retiisi.org.uk> From: Steve Longerbeam Message-ID: Date: Sat, 29 Sep 2018 10:40:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180928121631.6nobkbegwnfeerpb@valkosipuli.retiisi.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sakari, On 09/28/2018 05:16 AM, Sakari Ailus wrote: > On Wed, Sep 26, 2018 at 10:49:18AM -0700, Steve Longerbeam wrote: >> Hi Mauro, Sakari, >> >> >> On 09/26/2018 03:40 AM, Sakari Ailus wrote: >>> Hi Mauro, Steve, >>> >>> On Wed, Sep 26, 2018 at 06:33:35AM -0300, Mauro Carvalho Chehab wrote: >>>> Em Tue, 25 Sep 2018 18:05:36 -0700 >>>> Steve Longerbeam escreveu: >>>> >>>>> On 09/25/2018 03:20 PM, Mauro Carvalho Chehab wrote: >>>>>> Em Tue, 25 Sep 2018 14:04:21 -0700 >>>>>> Steve Longerbeam escreveu: >>>>>>>>> @@ -392,12 +406,11 @@ static int __v4l2_async_notifier_register(struct v4l2_async_notifier *notifier) >>>>>>>>> case V4L2_ASYNC_MATCH_CUSTOM: >>>>>>>>> case V4L2_ASYNC_MATCH_DEVNAME: >>>>>>>>> case V4L2_ASYNC_MATCH_I2C: >>>>>>>>> - break; >>>>>>>>> case V4L2_ASYNC_MATCH_FWNODE: >>>>>>>>> - if (v4l2_async_notifier_fwnode_has_async_subdev( >>>>>>>>> - notifier, asd->match.fwnode, i)) { >>>>>>>>> + if (v4l2_async_notifier_has_async_subdev( >>>>>>>>> + notifier, asd, i)) { >>>>>>>>> dev_err(dev, >>>>>>>>> - "fwnode has already been registered or in notifier's subdev list\n"); >>>>>>>>> + "asd has already been registered or in notifier's subdev list\n"); >>>>>>>> Please, never use "asd" on messages printed to the user. While someone >>>>>>>> may understand it while reading the source code, for a poor use, >>>>>>>> "asd" is just a random sequence of 3 characters. >>>>>>> I will change the message to read: >>>>>>> >>>>>>> "subdev descriptor already listed in this or other notifiers". >>>>>> Perfect! >>>>> But the error message is removed in the subsequent patch >>>>> "[PATCH 03/17] media: v4l2: async: Add v4l2_async_notifier_add_subdev". >>>>> >>>>> I could bring it back as a dev_dbg() in v4l2_async_notifier_asd_valid(), but >>>>> this shouldn't be a dev_err() anymore since it is up to the media platform >>>>> to decide whether an already existing subdev descriptor is an error. >>>> Hmm... that's an interesting discussion... what cases do you think it >>>> would be fine to try to register twice an asd notifier? >> It should be a fairly common case that a sub-device has multiple fwnode >> output ports. In that case it's possible multiple sub-devices downstream >> from it will each encounter it when parsing the fwnode graph, and attempt >> to add it to their notifiers asd_list multiple times. That isn't an error, >> any >> attempt to add it after the first add should be ignored. >> >> imx-media is an example, there is a CSI-2 transmitter with four fwnode >> output ports for each CSI-2 virtual channel. Those channels each go to >> one of four Camera Sensor Interface in the imx6 IPU. So each CSI will >> encounter the CSI-2 transmitter when parsing its fwnode ports. >> >> >>> Only the error message is removed; this case is still considered an error. >>> I think it'd be better to keep this error message; it helps debugging. >> Ok I will add it back, but it should be a dev_dbg(). > Fine for me. > > Could you address especially the author vs. SoB line difference in the set, > and re-post to the list, please? Will do! > > I've pushed the latest set including my fwnode patches (which you can > ignore) to my linuxtv.org tree v4l2-fwnode branch; feel free to use these > as the basis. I've fixed a few conflicts in there in rebasing on current > media tree master. Yes in drivers/media/platform/ti-vpe/cal.c, due to 58513d4849 (" media: platform: remove redundant null pointer check before of_node_put") I fixed that conflict too, but in a different way that retains the above change. Since my conflict fix is different from yours, I will push v7 against current media tree master. Let me know if the fixup looks ok to you. Steve