From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Jakub Kicinski <kuba@kernel.org>, Breno Leitao <leitao@debian.org>
Cc: <davem@davemloft.net>, <pabeni@redhat.com>, <edumazet@google.com>,
<elder@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>, <nbd@nbd.name>,
<sean.wang@mediatek.com>, <Mark-MC.Lee@mediatek.com>,
<lorenzo@kernel.org>, <taras.chornyi@plvision.eu>,
<ath11k@lists.infradead.org>, <ath10k@lists.infradead.org>,
<linux-wireless@vger.kernel.org>, <geomatsi@gmail.com>,
<kvalo@kernel.org>, <quic_jjohnson@quicinc.com>,
<leon@kernel.org>, <dennis.dalessandro@cornelisnetworks.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<bpf@vger.kernel.org>, <idosch@idosch.org>,
Ido Schimmel <idosch@nvidia.com>, Jiri Pirko <jiri@resnulli.us>,
Simon Horman <horms@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH net-next v6 03/10] net: create a dummy net_device allocator
Date: Wed, 17 Apr 2024 12:51:12 +0200 [thread overview]
Message-ID: <ebe80c29-4884-488d-ab83-c020f9c3bc81@intel.com> (raw)
In-Reply-To: <20240412191626.2e9bfb4a@kernel.org>
From: Jakub Kicinski <kuba@kernel.org>
Date: Fri, 12 Apr 2024 19:16:26 -0700
> On Thu, 11 Apr 2024 06:59:27 -0700 Breno Leitao wrote:
>> +/**
>> + * alloc_netdev_dummy - Allocate and initialize a dummy net device.
>> + * @sizeof_priv: size of private data to allocate space for
>> + */
>> +struct net_device *alloc_netdev_dummy(int sizeof_priv)
>
> Sorry, one more round :)
>
> We started using -Wall for kdoc (./scripts/kernel-doc -Wall $files)
> recently and it now complains about missing return values...
Just FYI: kdoc accepts only this pattern:
* @last_param: blah
*
* Return: blah
NOT
* Returns: blah
neither
* Returns blah
Only "Return: blah" with a blank newline between it and the last
argument (or extended description).
Thanks,
Olek
next prev parent reply other threads:[~2024-04-17 10:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 13:59 [PATCH net-next v6 00/10] allocate dummy device dynamically Breno Leitao
2024-04-11 13:59 ` [PATCH net-next v6 01/10] net: core: Fix documentation Breno Leitao
2024-04-11 13:59 ` [PATCH net-next v6 02/10] net: free_netdev: exit earlier if dummy Breno Leitao
2024-04-11 13:59 ` [PATCH net-next v6 03/10] net: create a dummy net_device allocator Breno Leitao
2024-04-13 2:16 ` Jakub Kicinski
2024-04-17 10:51 ` Alexander Lobakin [this message]
2024-04-17 11:11 ` Johannes Berg
2024-04-17 11:19 ` Alexander Lobakin
2024-04-17 15:29 ` Randy Dunlap
2024-04-11 13:59 ` [PATCH net-next v6 04/10] net: marvell: prestera: allocate dummy net_device dynamically Breno Leitao
2024-04-11 13:59 ` [PATCH net-next v6 05/10] net: mediatek: mtk_eth_sock: " Breno Leitao
2024-04-11 13:59 ` [PATCH net-next v6 06/10] net: ipa: " Breno Leitao
2024-04-11 13:59 ` [PATCH net-next v6 07/10] net: ibm/emac: " Breno Leitao
2024-04-11 13:59 ` [PATCH net-next v6 08/10] wifi: qtnfmac: Use netdev dummy allocator helper Breno Leitao
2024-04-11 13:59 ` [PATCH net-next v6 09/10] wifi: ath10k: allocate dummy net_device dynamically Breno Leitao
2024-04-11 13:59 ` [PATCH net-next v6 10/10] wifi: ath11k: " Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebe80c29-4884-488d-ab83-c020f9c3bc81@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=Mark-MC.Lee@mediatek.com \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=geomatsi@gmail.com \
--cc=horms@kernel.org \
--cc=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=leitao@debian.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_jjohnson@quicinc.com \
--cc=sean.wang@mediatek.com \
--cc=taras.chornyi@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).