From: "Srivatsa S. Bhat" <srivatsa@csail.mit.edu>
To: Thomas Gleixner <tglx@linutronix.de>,
Igor Mammedov <imammedo@redhat.com>
Cc: linux-kernel@vger.kernel.org, amakhalov@vmware.com,
ganb@vmware.com, ankitja@vmware.com, bordoloih@vmware.com,
keerthanak@vmware.com, blamoreaux@vmware.com, namit@vmware.com,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Wyes Karny <wyes.karny@amd.com>,
Lewis Caroll <lewis.carroll@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Juergen Gross <jgross@suse.com>,
x86@kernel.org,
VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] x86/hotplug: Do not put offline vCPUs in mwait idle state
Date: Fri, 20 Jan 2023 05:55:11 -0800 [thread overview]
Message-ID: <ecb9a22e-fd6e-67f0-d916-ad16033fc13c@csail.mit.edu> (raw)
In-Reply-To: <87bkmui5z4.ffs@tglx>
Hi Igor and Thomas,
Thank you for your review!
On 1/19/23 1:12 PM, Thomas Gleixner wrote:
> On Mon, Jan 16 2023 at 15:55, Igor Mammedov wrote:
>> "Srivatsa S. Bhat" <srivatsa@csail.mit.edu> wrote:
>>> Fix this by preventing the use of mwait idle state in the vCPU offline
>>> play_dead() path for any hypervisor, even if mwait support is
>>> available.
>>
>> if mwait is enabled, it's very likely guest to have cpuidle
>> enabled and using the same mwait as well. So exiting early from
>> mwait_play_dead(), might just punt workflow down:
>> native_play_dead()
>> ...
>> mwait_play_dead();
>> if (cpuidle_play_dead()) <- possible mwait here
>> hlt_play_dead();
>>
>> and it will end up in mwait again and only if that fails
>> it will go HLT route and maybe transition to VMM.
>
> Good point.
>
>> Instead of workaround on guest side,
>> shouldn't hypervisor force VMEXIT on being uplugged vCPU when it's
>> actually hot-unplugging vCPU? (ex: QEMU kicks vCPU out from guest
>> context when it is removing vCPU, among other things)
>
> For a pure guest side CPU unplug operation:
>
> guest$ echo 0 >/sys/devices/system/cpu/cpu$N/online
>
> the hypervisor is not involved at all. The vCPU is not removed in that
> case.
>
Agreed, and this is indeed the scenario I was targeting with this patch,
as opposed to vCPU removal from the host side. I'll add this clarification
to the commit message.
> So to ensure that this ends up in HLT something like the below is
> required.
>
> Note, the removal of the comment after mwait_play_dead() is intentional
> because the comment is completely bogus. Not having MWAIT is not a
> failure. But that wants to be a seperate patch.
>
Sounds good, will do and post a new version.
Thank you!
Regards,
Srivatsa
VMware Photon OS
> Thanks,
>
> tglx
> ---
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index 55cad72715d9..3f1f20f71ec5 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -1833,7 +1833,10 @@ void native_play_dead(void)
> play_dead_common();
> tboot_shutdown(TB_SHUTDOWN_WFS);
>
> - mwait_play_dead(); /* Only returns on failure */
> + if (this_cpu_has(X86_FEATURE_HYPERVISOR))
> + hlt_play_dead();
> +
> + mwait_play_dead();
> if (cpuidle_play_dead())
> hlt_play_dead();
> }
>
>
>
>
next prev parent reply other threads:[~2023-01-20 13:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 6:01 [PATCH v2] x86/hotplug: Do not put offline vCPUs in mwait idle state Srivatsa S. Bhat
2023-01-16 8:38 ` Juergen Gross
2023-01-16 14:55 ` Igor Mammedov
2023-01-19 21:12 ` Thomas Gleixner
2023-01-20 13:55 ` Srivatsa S. Bhat [this message]
2023-01-20 15:37 ` Igor Mammedov
2023-01-20 18:35 ` Sean Christopherson
2023-01-26 2:14 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecb9a22e-fd6e-67f0-d916-ad16033fc13c@csail.mit.edu \
--to=srivatsa@csail.mit.edu \
--cc=amakhalov@vmware.com \
--cc=ankitja@vmware.com \
--cc=blamoreaux@vmware.com \
--cc=bordoloih@vmware.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=ganb@vmware.com \
--cc=hpa@zytor.com \
--cc=imammedo@redhat.com \
--cc=jgross@suse.com \
--cc=keerthanak@vmware.com \
--cc=kvm@vger.kernel.org \
--cc=lewis.carroll@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namit@vmware.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=pv-drivers@vmware.com \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wyes.karny@amd.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).