From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 03/16] dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl example
Date: Thu, 8 Dec 2022 09:07:53 +0100 [thread overview]
Message-ID: <edd39013-af5f-5868-6c78-173d8f163754@linaro.org> (raw)
In-Reply-To: <20221207055405.30940-4-hayashi.kunihiko@socionext.com>
On 07/12/2022 06:53, Kunihiko Hayashi wrote:
> Rename the parent node to the generic node name "syscon".
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> index 14a8c0215cc6..186fc550af4c 100644
> --- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> @@ -69,7 +69,7 @@ examples:
> - |
> // The UniPhier pinctrl should be a subnode of a "syscon" compatible node.
>
> - soc-glue@5f800000 {
> + syscon@5f800000 {
> compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd", "syscon";
> reg = <0x5f800000 0x2000>;
>
Not visible in the diff but this is a poor example. It has only
compatible! Drop the parent node instead and extend the pinctrl node to
show complete picture of pinctrl.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-08 8:08 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 01/16] dt-bindings: clock: Fix node descriptions in uniphier-clock example Kunihiko Hayashi
2022-12-08 8:06 ` Krzysztof Kozlowski
2022-12-08 15:09 ` Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 02/16] dt-bindings: reset: Fix node descriptions in uniphier-reset example Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 03/16] dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl example Kunihiko Hayashi
2022-12-08 8:07 ` Krzysztof Kozlowski [this message]
2022-12-08 15:09 ` Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 04/16] dt-bindings: watchdog: Fix node descriptions in uniphier-wdt example Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 05/16] dt-bindings: thermal: Fix node descriptions in uniphier-thermal example Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 06/16] dt-bindings: phy: Fix node descriptions in uniphier-phy example Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 07/16] dt-bindings: nvmem: Fix node descriptions in uniphier-efuse example Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 08/16] dt-bindings: soc: socionext: Add UniPhier system controller Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-08 6:37 ` Kunihiko Hayashi
2022-12-08 8:15 ` Krzysztof Kozlowski
2022-12-08 15:09 ` Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic Kunihiko Hayashi
2022-12-07 15:35 ` Rob Herring
2022-12-08 6:37 ` Kunihiko Hayashi
2022-12-08 8:16 ` Krzysztof Kozlowski
2022-12-08 15:11 ` Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 10/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-08 8:18 ` Krzysztof Kozlowski
2022-12-08 15:11 ` Kunihiko Hayashi
2022-12-07 5:54 ` [PATCH v2 11/16] dt-bindings: soc: socionext: Add UniPhier peripheral block Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-07 5:54 ` [PATCH v2 12/16] dt-bindings: soc: socionext: Add UniPhier media I/O block Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-07 5:54 ` [PATCH v2 13/16] dt-bindings: soc: socionext: Add UniPhier SD interface block Kunihiko Hayashi
2022-12-07 5:54 ` [PATCH v2 14/16] dt-bindings: soc: socionext: Add UniPhier ADAMV block Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-07 5:54 ` [PATCH v2 15/16] dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-08 8:23 ` Krzysztof Kozlowski
2022-12-08 15:11 ` Kunihiko Hayashi
2022-12-07 5:54 ` [PATCH v2 16/16] dt-bindings: soc: socionext: Add UniPhier AHCI " Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-08 8:24 ` Krzysztof Kozlowski
2022-12-08 15:11 ` Kunihiko Hayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edd39013-af5f-5868-6c78-173d8f163754@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).