From: icenowy@aosc.io
To: Chen-Yu Tsai <wens@csie.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, linux-gpio@vger.kernel.org,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [linux-sunxi] [PATCH] pinctrl: sunxi: fix V3s pinctrl driver IRQ bank base
Date: Fri, 04 Aug 2017 11:48:25 +0800 [thread overview]
Message-ID: <ee6eccabe2e9279278430013c943bbd9@aosc.io> (raw)
In-Reply-To: <CAGb2v64BBJrr+yo-7n1DkZjYvdB2ws+0OHD_Dwt_MCS85-U19Q@mail.gmail.com>
在 2017-08-04 10:23，Chen-Yu Tsai 写道：
> On Tue, Aug 1, 2017 at 10:54 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
>> The V3s pin controller doesn't have the bank 0 (starts at address
>> 0x200), which is like A33. However, this is not workarounded when
>
> was not worked around
>
> "Work around" is a verb phrase. "Workaround" is a noun.
>
>> developing the driver, which makes IRQ not working.
>
> broke the IRQs.
>
>>
>> Fix the IRQ bank base.
>>
>> Fixes: 56d9e4a76039 ("pinctrl: sunxi: add driver for V3s SoC")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>
> Confirmed this is the same thing we saw on A33.
> The fix is the same.
>
> Apart from the typo / grammar errors above,
>
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Should I send a v2 now to fix the language errors?
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-08-04 3:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 14:54 [PATCH] pinctrl: sunxi: fix V3s pinctrl driver IRQ bank base Icenowy Zheng
2017-08-04 2:23 ` [linux-sunxi] " Chen-Yu Tsai
2017-08-04 3:48 ` icenowy [this message]
2017-08-07 13:09 ` Linus Walleij
2017-08-07 13:18 ` icenowy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee6eccabe2e9279278430013c943bbd9@aosc.io \
--to=icenowy@aosc.io \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=stable@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).