linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tianxianting <xianting.tian@linux.alibaba.com>
To: Jason Wang <jasowang@redhat.com>,
	Xianting Tian <tianxianting.txt@linux.alibaba.com>,
	stefanha@redhat.com, sgarzare@redhat.com, davem@davemloft.net,
	kuba@kernel.org
Cc: kvm@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()
Date: Tue, 20 Jul 2021 15:05:36 +0800	[thread overview]
Message-ID: <ef3f559f-7093-aae7-1fa7-d58bf9ac87c9@linux.alibaba.com> (raw)
In-Reply-To: <73d486dd-17d9-a3b3-c1e9-39a1138c0084@redhat.com>

thanks ,

I will sent V2 patch.

在 2021/7/20 下午2:28, Jason Wang 写道:
>
> 在 2021/7/20 上午11:42, Xianting Tian 写道:
>> From: Xianting Tian <xianting.tian@linux.alibaba.com>
>>
>> Add the missed virtio_device_ready() to set vsock frontend ready.
>>
>> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
>> ---
>>   net/vmw_vsock/virtio_transport.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/net/vmw_vsock/virtio_transport.c 
>> b/net/vmw_vsock/virtio_transport.c
>> index e0c2c992a..eb4c607c4 100644
>> --- a/net/vmw_vsock/virtio_transport.c
>> +++ b/net/vmw_vsock/virtio_transport.c
>> @@ -637,6 +637,8 @@ static int virtio_vsock_probe(struct 
>> virtio_device *vdev)
>>       vdev->priv = vsock;
>>       rcu_assign_pointer(the_virtio_vsock, vsock);
>>   +    virtio_device_ready(vdev);
>> +
>>       mutex_unlock(&the_virtio_vsock_mutex);
>
>
> It's better to do this after the mutex_lock().
>
> Thanks
>
>
>>         return 0;

  reply	other threads:[~2021-07-20  7:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20  3:42 [PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe() Xianting Tian
2021-07-20  3:44 ` tianxianting
2021-07-20  6:28 ` Jason Wang
2021-07-20  7:05   ` tianxianting [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-07-20  3:40 Xianting Tian
2021-07-20  6:25 ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef3f559f-7093-aae7-1fa7-d58bf9ac87c9@linux.alibaba.com \
    --to=xianting.tian@linux.alibaba.com \
    --cc=davem@davemloft.net \
    --cc=jasowang@redhat.com \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sgarzare@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=tianxianting.txt@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).