From: Guenter Roeck <linux@roeck-us.net>
To: Shawn Guo <shawnguo@kernel.org>,
Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
kernel@savoirfairelinux.com, robh@kernel.org,
linus.walleij@linaro.org, fabio.estevam@nxp.com,
mark@embeddedarm.com, kris@embeddedarm.com
Subject: Re: [PATCH v3 6/6] watchdog: ts4600: add driver for TS-4600 watchdog
Date: Sun, 14 May 2017 07:39:33 -0700 [thread overview]
Message-ID: <ef75bcab-e179-1891-83f6-d26d057f8758@roeck-us.net> (raw)
In-Reply-To: <20170511072231.GD5833@dragon>
On 05/11/2017 12:22 AM, Shawn Guo wrote:
> On Fri, May 05, 2017 at 03:32:59PM -0400, Sebastien Bourdelin wrote:
>> This watchdog is instantiated in a FPGA and can only be access using a
>> GPIOs bit-banged bus, called the NBUS by Technologic Systems.
>> The watchdog is made of only one register, called the feed register.
>> Writing to this register will re-arm the watchdog for a given time (and
>> enable it if it was disable). It can be disabled by writing a special
>> value into it.
>>
>> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
>> ---
>> Changes v2 -> v3:
>> - rebase on master
>> - remove the timeout table to simplify the logic (suggested by
>> Guenter Roeck)
>> - fix the set_timeout function (suggested by Guenter Roeck)
>> - hardcode the max_hw_heartbeat_ms value based on the ts4600 max
>> timeout value supported (suggested by Guenter Roeck)
>> - remove the max_timeout usage and set a default timeout value
>> (suggested by Guenter Roeck)
>> - use the devm_watchdog_register_device function instead of
>> watchdog_register_device (suggested by Guenter Roeck)
>>
>> Changes v1 -> v2:
>> - rebase on master
>> - retrieve the ts_nbus instantiated by the parent node (suggested by
>> Linus Walleij)
>> - rename the wdt by watchdog in the device tree and in the
>> documentation (suggested by Rob Herring)
>> - add a dependency to the TS_NBUS driver in the Kconfig (suggested by
>> Guenter Roeck)
>> - simplify the set_timeout function (suggested by Guenter Roeck)
>> - use the max_hw_heartbeat_ms callback instead of the max_timeout
>> callback (suggested by Guenter Roeck)
>> ---
>> .../devicetree/bindings/watchdog/ts4600-wdt.txt | 16 ++
>> arch/arm/boot/dts/imx28-ts4600-common.dtsi | 5 +
>
> The dts change shouldn't be mixed within driver patch.
>
Maybe, but Rob Acked the devicetree changes, so I don't see a reason
for splitting it up now.
Guenter
> Shawn
>
>> drivers/watchdog/Kconfig | 11 ++
>> drivers/watchdog/Makefile | 1 +
>> drivers/watchdog/ts4600_wdt.c | 185 +++++++++++++++++++++
>> 5 files changed, 218 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/watchdog/ts4600-wdt.txt
>> create mode 100644 drivers/watchdog/ts4600_wdt.c
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2017-05-14 14:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 19:32 [PATCH v3 0/6] Add board support for TS-4600 Sebastien Bourdelin
2017-05-05 19:32 ` [PATCH v3 1/6] of: documentation: add bindings documentation " Sebastien Bourdelin
2017-05-05 19:32 ` [PATCH v3 2/6] ARM: dts: TS-4600: add basic device tree Sebastien Bourdelin
2017-05-05 19:32 ` [PATCH v3 3/6] dt-bindings: bus: Add documentation for the Technologic Systems NBUS Sebastien Bourdelin
2017-05-11 13:50 ` Linus Walleij
2017-05-12 15:17 ` Rob Herring
2017-05-05 19:32 ` [PATCH v3 4/6] bus: add driver " Sebastien Bourdelin
2017-05-11 13:56 ` Linus Walleij
2017-05-05 19:32 ` [PATCH v3 5/6] ARM: dts: TS-4600: add NBUS support Sebastien Bourdelin
2017-05-11 13:56 ` Linus Walleij
2017-05-05 19:32 ` [PATCH v3 6/6] watchdog: ts4600: add driver for TS-4600 watchdog Sebastien Bourdelin
2017-05-08 13:27 ` Rob Herring
2017-05-11 7:22 ` Shawn Guo
2017-05-14 14:39 ` Guenter Roeck [this message]
2017-05-15 2:00 ` Shawn Guo
2017-05-15 2:30 ` Guenter Roeck
2017-05-14 14:40 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef75bcab-e179-1891-83f6-d26d057f8758@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@savoirfairelinux.com \
--cc=kris@embeddedarm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mark@embeddedarm.com \
--cc=robh@kernel.org \
--cc=sebastien.bourdelin@savoirfairelinux.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).