From: Roger Quadros <rogerq@kernel.org>
To: Tony Lindgren <tony@atomide.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] memory: omap-gpmc: Clear GPMC_CS_CONFIG7 register on restore if unused
Date: Fri, 30 Jul 2021 13:59:51 +0300 [thread overview]
Message-ID: <f0a0dfe8-a185-2b14-e12a-ebdd6e2c909f@kernel.org> (raw)
In-Reply-To: <20210727101034.32148-1-tony@atomide.com>
On 27/07/2021 13:10, Tony Lindgren wrote:
> We want to clear any unused GPMC_CS_CONFIG7 register on restore to
> ensure unused chip selects are not enabled.
>
> Cc: Roger Quadros <rogerq@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: Roger Quadros <rogerq@kernel.org>
Sorry if you got this twice. I got a bounce back on the previous Ack.
cheers,
-roger
> ---
> drivers/memory/omap-gpmc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -2595,6 +2595,8 @@ void omap3_gpmc_restore_context(void)
> gpmc_context.cs_context[i].config6);
> gpmc_cs_write_reg(i, GPMC_CS_CONFIG7,
> gpmc_context.cs_context[i].config7);
> + } else {
> + gpmc_cs_write_reg(i, GPMC_CS_CONFIG7, 0);
> }
> }
> }
>
prev parent reply other threads:[~2021-07-30 10:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 10:10 [PATCH 1/2] memory: omap-gpmc: Clear GPMC_CS_CONFIG7 register on restore if unused Tony Lindgren
2021-07-27 10:10 ` [PATCH 2/2] memory: omap-gpmc: Drop custom PM calls with cpu_pm notifier Tony Lindgren
2021-07-30 10:51 ` Roger Quadros
2021-07-29 8:08 ` [PATCH 1/2] memory: omap-gpmc: Clear GPMC_CS_CONFIG7 register on restore if unused Krzysztof Kozlowski
2021-07-30 10:59 ` Roger Quadros [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0a0dfe8-a185-2b14-e12a-ebdd6e2c909f@kernel.org \
--to=rogerq@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).