From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Bryan O'Donoghue <pure.logic@nexus-software.ie>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: greybus: loopback.c: do insertion in O(n) instead of O(n lg n)
Date: Thu, 11 Oct 2018 12:11:34 +0200 [thread overview]
Message-ID: <f20353cc-15d9-5816-b466-8d1e30df9a2d@rasmusvillemoes.dk> (raw)
In-Reply-To: <b59cc4bf-3c43-8d35-8d1c-0700f6b4c604@nexus-software.ie>
On 2018-10-11 01:03, Bryan O'Donoghue wrote:
> On 05/10/2018 15:28, Rasmus Villemoes wrote:
>> Signed-off-by: Rasmus Villemoes<linux@rasmusvillemoes.dk>
>> ---
>> I have no idea if the performance matters (it probably doesn't). Feel
>> free to ignore this and the followup cleanup.
>
> What's the problem you're fixing here ?
No problem, really, other than my inner Paul Hogan telling me "That's
not an insertion sort, ...".
> Is it tested ?
Compile-tested. As I said, if the performance (and inaccurate comment)
is irrelevant, just drop it.
Rasmus
next prev parent reply other threads:[~2018-10-11 10:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 14:28 [PATCH 1/3] staging: greybus: loopback.c: remove unused gb_loopback::lbid Rasmus Villemoes
2018-10-05 14:28 ` [PATCH 2/3] staging: greybus: loopback.c: do insertion in O(n) instead of O(n lg n) Rasmus Villemoes
2018-10-10 23:03 ` Bryan O'Donoghue
2018-10-11 10:11 ` Rasmus Villemoes [this message]
2018-10-23 16:20 ` Rasmus Villemoes
2018-10-23 22:30 ` Bryan O'Donoghue
2018-10-05 14:28 ` [PATCH 3/3] staging: greybus: loopback.c: simplify prototype of gb_loopback_bus_id_compare Rasmus Villemoes
2018-10-10 22:57 ` [PATCH 1/3] staging: greybus: loopback.c: remove unused gb_loopback::lbid Bryan O'Donoghue
2018-10-24 10:48 ` [PATCH v2] staging: greybus: loopback.c: remove unused lists Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f20353cc-15d9-5816-b466-8d1e30df9a2d@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).