From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754542AbcKCMWj (ORCPT ); Thu, 3 Nov 2016 08:22:39 -0400 Received: from lb3-smtp-cloud6.xs4all.net ([194.109.24.31]:45372 "EHLO lb3-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754218AbcKCMW2 (ORCPT ); Thu, 3 Nov 2016 08:22:28 -0400 Subject: Re: [PATCH 17/34] [media] DaVinci-VPFE-Capture: Improve another size determination in vpfe_enum_input() To: SF Markus Elfring , linux-media@vger.kernel.org, Hans Verkuil , "Lad, Prabhakar" , Mauro Carvalho Chehab References: <88b3de4c-5f3f-9f70-736b-039dca6b8a2e@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Hans Verkuil Message-ID: Date: Thu, 3 Nov 2016 13:22:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <88b3de4c-5f3f-9f70-736b-039dca6b8a2e@users.sourceforge.net> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/10/16 16:55, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 12 Oct 2016 10:33:42 +0200 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer. > > Signed-off-by: Markus Elfring > --- > drivers/media/platform/davinci/vpfe_capture.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c > index 8314c39..87ee35d 100644 > --- a/drivers/media/platform/davinci/vpfe_capture.c > +++ b/drivers/media/platform/davinci/vpfe_capture.c > @@ -1091,7 +1091,7 @@ static int vpfe_enum_input(struct file *file, void *priv, > return -EINVAL; > } > sdinfo = &vpfe_dev->cfg->sub_devs[subdev]; > - memcpy(inp, &sdinfo->inputs[index], sizeof(struct v4l2_input)); > + memcpy(inp, &sdinfo->inputs[index], sizeof(*inp)); If I am not mistaken this can be written as: *inp = sdinfo->inputs[index]; Much better. Regards, Hans > return 0; > } > >