From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Ivan Mikhaylov" <i.mikhaylov@yadro.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>
Cc: "Joel Stanley" <joel@jms.id.au>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
"Alexander Amelkin" <a.amelkin@yadro.com>,
openbmc@lists.ozlabs.org, "Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 4/4] dt-bindings/watchdog: Add access_cs0 option for alt-boot
Date: Tue, 27 Aug 2019 09:27:44 +0930 [thread overview]
Message-ID: <f33aa4b8-6d06-4226-8859-ce21a4b8728b@www.fastmail.com> (raw)
In-Reply-To: <20190826104636.19324-5-i.mikhaylov@yadro.com>
On Mon, 26 Aug 2019, at 20:17, Ivan Mikhaylov wrote:
> The option for the ast2400/2500 to get access to CS0 at runtime.
>
> Signed-off-by: Ivan Mikhaylov <i.mikhaylov@yadro.com>
> ---
> Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> index c5077a1f5cb3..023a9b578df6 100644
> --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> @@ -34,6 +34,13 @@ Optional properties:
> engine is responsible for this.
>
> - aspeed,alt-boot: If property is present then boot from alternate
> block.
> + At alternate side 'access_cs0' sysfs file
> provides:
Why are we talking about sysfs in the devicetree binding? This patch
doesn't seem right to me.
Also if we're not supporting the aspeed,alt-boot property we should
probably document it as deprecated rather than making it disappear,
unless you're going to fix the systems that are using it.
Andrew
next prev parent reply other threads:[~2019-08-26 23:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 10:46 [PATCH v2 0/4] add dual-boot support Ivan Mikhaylov
2019-08-26 10:46 ` [PATCH v2 1/4] vesnin: add wdt2 section with alt-boot option Ivan Mikhaylov
2019-08-26 10:46 ` [PATCH v2 2/4] vesnin: add secondary SPI flash chip Ivan Mikhaylov
2019-08-26 10:46 ` [PATCH v2 3/4] watchdog/aspeed: add support for dual boot Ivan Mikhaylov
2019-08-27 0:14 ` Guenter Roeck
2019-08-27 9:24 ` Ivan Mikhaylov
2019-08-27 13:06 ` Guenter Roeck
2019-08-26 10:46 ` [PATCH v2 4/4] dt-bindings/watchdog: Add access_cs0 option for alt-boot Ivan Mikhaylov
2019-08-26 23:57 ` Andrew Jeffery [this message]
2019-08-27 0:08 ` Guenter Roeck
2019-08-27 0:11 ` Andrew Jeffery
2019-08-29 22:56 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f33aa4b8-6d06-4226-8859-ce21a4b8728b@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=a.amelkin@yadro.com \
--cc=devicetree@vger.kernel.org \
--cc=i.mikhaylov@yadro.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).