From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Julien Thierry <julien.thierry@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>
Subject: Re: [PATCH 02/10] irqchip/gic-v3-its: Consolidate LPI_PENDBASE_SZ usage
Date: Mon, 24 Sep 2018 11:54:02 +0100 [thread overview]
Message-ID: <f37b69a8-64fd-490d-1680-9f6aef235e10@arm.com> (raw)
In-Reply-To: <cab043d8-c9bb-6975-8304-ff80dbe62027@arm.com>
On 24/09/18 11:50, Julien Thierry wrote:
> Hi,
>
> On 24/09/18 11:33, Suzuki K Poulose wrote:
>> Hi Marc,
>>
>> On 21/09/18 20:59, Marc Zyngier wrote:
>>> LPI_PENDING_SZ is always used in conjunction with a max(). Let's
>>> factor this in the definition of the macro, and simplify the rest
>>> of the code.
>>>
>>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>>> ---
>>> drivers/irqchip/irq-gic-v3-its.c | 12 ++++--------
>>> 1 file changed, 4 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/drivers/irqchip/irq-gic-v3-its.c
>>> b/drivers/irqchip/irq-gic-v3-its.c
>>> index c2df341ff6fa..ed6aab11e019 100644
>>> --- a/drivers/irqchip/irq-gic-v3-its.c
>>> +++ b/drivers/irqchip/irq-gic-v3-its.c
>>> @@ -62,7 +62,7 @@ static u32 lpi_id_bits;
>>> */
>>> #define LPI_NRBITS lpi_id_bits
>>> #define LPI_PROPBASE_SZ ALIGN(BIT(LPI_NRBITS), SZ_64K)
>>> -#define LPI_PENDBASE_SZ ALIGN(BIT(LPI_NRBITS) / 8, SZ_64K)
>>> +#define LPI_PENDBASE_SZ max_t(u32, SZ_64K,
>>> ALIGN(BIT(LPI_NRBITS) / 8, SZ_64K))
>>
>> minor nit: The ALIGN() already aligns the given value up to the required
>> alignment. So, if the LPI_NRBITS is guaranteed to be non-zero,
>> we could simply drop the max_t().
>>
>
> Hmmm, Doesn't ALIGN only aligns down? So if "BIT(LPI_NR_BITS) / 8 <
> SZ_64K" (i.e. LPI_NRBITS < 20) The ALIGN(..., SZ_64K) would give 0.
Isn't it the ALIGN_DOWN(), which aligns it down ? Following the kernel
definitions :
linux/kernel.h -> uapi/linux/kernel.h
ALIGN(x,a) => __ALIGN_KERNEL(x, a)
\ => __ALIGN_KERNEL_MASK(x, (a -1)
\ => (((x + (a - 1)) & ~ (a - 1))
Cheers
Suzuki
>
> Thanks,
>
>> Rest looks good to me.
>>
>> Suzuki
>>
>>> #define LPI_PROP_DEFAULT_PRIO 0xa0
>>> @@ -1924,12 +1924,9 @@ static int its_alloc_collections(struct
>>> its_node *its)
>>> static struct page *its_allocate_pending_table(gfp_t gfp_flags)
>>> {
>>> struct page *pend_page;
>>> - /*
>>> - * The pending pages have to be at least 64kB aligned,
>>> - * hence the 'max(LPI_PENDBASE_SZ, SZ_64K)' below.
>>> - */
>>> +
>>> pend_page = alloc_pages(gfp_flags | __GFP_ZERO,
>>> - get_order(max_t(u32, LPI_PENDBASE_SZ, SZ_64K)));
>>> + get_order(LPI_PENDBASE_SZ));
>>> if (!pend_page)
>>> return NULL;
>>> @@ -1941,8 +1938,7 @@ static struct page
>>> *its_allocate_pending_table(gfp_t gfp_flags)
>>> static void its_free_pending_table(struct page *pt)
>>> {
>>> - free_pages((unsigned long)page_address(pt),
>>> - get_order(max_t(u32, LPI_PENDBASE_SZ, SZ_64K)));
>>> + free_pages((unsigned long)page_address(pt),
>>> get_order(LPI_PENDBASE_SZ));
>>> }
>>> static void its_cpu_init_lpis(void)
>>>
>
next prev parent reply other threads:[~2018-09-24 10:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 19:59 [PATCH 00/10] GICv3 support for kexec/kdump on EFI systems Marc Zyngier
2018-09-21 19:59 ` [PATCH 01/10] irqchip/gic-v3-its: Change initialization ordering for LPIs Marc Zyngier
2018-09-24 10:49 ` Julien Thierry
2018-09-21 19:59 ` [PATCH 02/10] irqchip/gic-v3-its: Consolidate LPI_PENDBASE_SZ usage Marc Zyngier
2018-09-24 10:33 ` Suzuki K Poulose
2018-09-24 10:50 ` Julien Thierry
2018-09-24 10:54 ` Suzuki K Poulose [this message]
2018-09-24 10:55 ` Julien Thierry
2018-09-26 10:28 ` Marc Zyngier
2018-09-21 19:59 ` [PATCH 03/10] irqchip/gic-v3-its: Split property table clearing from allocation Marc Zyngier
2018-09-21 19:59 ` [PATCH 04/10] irqchip/gic-v3-its: Move pending table allocation to init time Marc Zyngier
2018-09-24 11:58 ` Julien Thierry
2018-09-26 10:39 ` Marc Zyngier
2018-09-21 19:59 ` [PATCH 05/10] irqchip/gic-v3-its: Keep track of property table's PA and VA Marc Zyngier
2018-09-21 19:59 ` [PATCH 06/10] irqchip/gic-v3-its: Allow use of pre-programmed LPI tables Marc Zyngier
2018-09-24 12:52 ` Julien Thierry
2018-09-21 19:59 ` [PATCH 07/10] irqchip/gic-v3-its: Use pre-programmed redistributor tables with kdump kernels Marc Zyngier
2018-09-21 19:59 ` [PATCH 08/10] irqchip/gic-v3-its: Check that all RDs have the same property table Marc Zyngier
2018-09-21 19:59 ` [PATCH 09/10] irqchip/gic-v3-its: Register LPI tables with EFI config table Marc Zyngier
2018-09-21 19:59 ` [PATCH 10/10] irqchip/gic-v3-its: Allow use of LPI tables in reserved memory Marc Zyngier
2018-09-25 18:48 ` [PATCH 00/10] GICv3 support for kexec/kdump on EFI systems Jeremy Linton
2018-09-27 9:55 ` Bhupesh Sharma
2018-09-27 13:01 ` Zhang, Lei
2018-09-27 21:10 ` Richard Ruigrok
2018-09-28 10:33 ` Marc Zyngier
[not found] ` <CACiNFG5r2Czfy_kXA2PPQa=xdyzq0vUgoQZ=XNME4d_h=O1oBw@mail.gmail.com>
2019-02-01 9:15 ` Marc Zyngier
2019-02-02 3:05 ` Xulin Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f37b69a8-64fd-490d-1680-9f6aef235e10@arm.com \
--to=suzuki.poulose@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=jason@lakedaemon.net \
--cc=jeremy.linton@arm.com \
--cc=jhugo@codeaurora.org \
--cc=julien.thierry@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).