linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Gladkov <legion@kernel.org>
To: LKML <linux-kernel@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>
Subject: [RFC PATCH v1 1/5] VT: Add KD_FONT_OP_GET_INFO operation
Date: Thu, 15 Feb 2024 15:37:20 +0000	[thread overview]
Message-ID: <f3fe608ece222f7782eff0fe714faf6439197090.1708011391.git.legion@kernel.org> (raw)
In-Reply-To: <cover.1708011391.git.legion@kernel.org>

Each driver has its own restrictions on font size. There is currently no
way to understand what the requirements are. The new operation allows
userspace to get the maximum font size values.

Signed-off-by: Alexey Gladkov <legion@kernel.org>
---
 drivers/tty/vt/vt.c       | 27 +++++++++++++++++++++++++++
 drivers/tty/vt/vt_ioctl.c |  2 +-
 include/linux/console.h   |  1 +
 include/uapi/linux/kd.h   |  1 +
 4 files changed, 30 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 156efda7c80d..e1d0f95ccba0 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -4628,6 +4628,31 @@ static int con_font_set(struct vc_data *vc, struct console_font_op *op)
 	return rc;
 }
 
+static int con_font_info(struct vc_data *vc, struct console_font_op *op)
+{
+	struct console_font font;
+	int rc = -EINVAL;
+
+	font.height = max_font_height;
+	font.width = max_font_width;
+	font.charcount = max_font_glyphs;
+
+	console_lock();
+	if (vc->vc_mode != KD_TEXT)
+		rc = -EINVAL;
+	else if (vc->vc_sw->con_font_info)
+		rc = vc->vc_sw->con_font_info(vc, &font);
+	else
+		rc = -ENOSYS;
+	console_unlock();
+
+	op->height = font.height;
+	op->width = font.width;
+	op->charcount = font.charcount;
+
+	return rc;
+}
+
 static int con_font_default(struct vc_data *vc, struct console_font_op *op)
 {
 	struct console_font font = {.width = op->width, .height = op->height};
@@ -4673,6 +4698,8 @@ int con_font_op(struct vc_data *vc, struct console_font_op *op)
 		return con_font_get(vc, op);
 	case KD_FONT_OP_SET_DEFAULT:
 		return con_font_default(vc, op);
+	case KD_FONT_OP_GET_INFO:
+		return con_font_info(vc, op);
 	case KD_FONT_OP_COPY:
 		/* was buggy and never really used */
 		return -EINVAL;
diff --git a/drivers/tty/vt/vt_ioctl.c b/drivers/tty/vt/vt_ioctl.c
index 8c685b501404..d6853d30ad19 100644
--- a/drivers/tty/vt/vt_ioctl.c
+++ b/drivers/tty/vt/vt_ioctl.c
@@ -469,7 +469,7 @@ static int vt_k_ioctl(struct tty_struct *tty, unsigned int cmd,
 
 		if (copy_from_user(&op, up, sizeof(op)))
 			return -EFAULT;
-		if (!perm && op.op != KD_FONT_OP_GET)
+		if (!perm && op.op != KD_FONT_OP_GET && op.op != KD_FONT_OP_GET_INFO)
 			return -EPERM;
 		ret = con_font_op(vc, &op);
 		if (ret)
diff --git a/include/linux/console.h b/include/linux/console.h
index 779d388af8a0..4afd9139d529 100644
--- a/include/linux/console.h
+++ b/include/linux/console.h
@@ -59,6 +59,7 @@ struct consw {
 			unsigned int lines);
 	int	(*con_switch)(struct vc_data *vc);
 	int	(*con_blank)(struct vc_data *vc, int blank, int mode_switch);
+	int	(*con_font_info)(struct vc_data *vc, struct console_font *font);
 	int	(*con_font_set)(struct vc_data *vc, struct console_font *font,
 			unsigned int vpitch, unsigned int flags);
 	int	(*con_font_get)(struct vc_data *vc, struct console_font *font,
diff --git a/include/uapi/linux/kd.h b/include/uapi/linux/kd.h
index 6b384065c013..21a1fb18dba0 100644
--- a/include/uapi/linux/kd.h
+++ b/include/uapi/linux/kd.h
@@ -180,6 +180,7 @@ struct console_font {
 #define KD_FONT_OP_COPY		3	/* Obsolete, do not use */
 #define KD_FONT_OP_SET_TALL	4	/* Set font with vpitch = height */
 #define KD_FONT_OP_GET_TALL	5	/* Get font with vpitch = height */
+#define KD_FONT_OP_GET_INFO	6
 
 #define KD_FONT_FLAG_DONT_RECALC 	1	/* Don't recalculate hw charcell size [compat] */
 
-- 
2.43.0


  reply	other threads:[~2024-02-15 15:37 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-15 15:37 [RFC PATCH v1 0/5] VT: Add ability to get font requirements Alexey Gladkov
2024-02-15 15:37 ` Alexey Gladkov [this message]
2024-02-15 15:37 ` [RFC PATCH v1 2/5] newport_con: Allow to get max font width and height Alexey Gladkov
2024-02-15 15:37 ` [RFC PATCH v1 3/5] sticon: " Alexey Gladkov
2024-02-16  7:10   ` Jiri Slaby
2024-02-16 13:03     ` Alexey Gladkov
2024-02-15 15:37 ` [RFC PATCH v1 4/5] vgacon: " Alexey Gladkov
2024-02-15 15:37 ` [RFC PATCH v1 5/5] fbcon: " Alexey Gladkov
2024-02-16  7:21 ` [RFC PATCH v1 0/5] VT: Add ability to get font requirements Jiri Slaby
2024-02-16 13:26   ` Alexey Gladkov
2024-02-16 13:45     ` Samuel Thibault
2024-02-16 14:40       ` Alexey Gladkov
2024-02-21  7:04     ` Jiri Slaby
2024-02-26 15:21 ` [RFC PATCH v2 " Alexey Gladkov
2024-02-26 15:21   ` [RFC PATCH v2 1/5] VT: Add KD_FONT_OP_GET_INFO operation Alexey Gladkov
2024-02-26 15:21   ` [RFC PATCH v2 2/5] newport_con: Allow to get max font width and height Alexey Gladkov
2024-02-26 15:21   ` [RFC PATCH v2 3/5] sticon: " Alexey Gladkov
2024-02-27  5:52     ` Greg Kroah-Hartman
2024-02-27 14:06       ` Alexey Gladkov
2024-02-26 15:21   ` [RFC PATCH v2 4/5] vgacon: " Alexey Gladkov
2024-02-26 15:21   ` [RFC PATCH v2 5/5] fbcon: " Alexey Gladkov
2024-03-12 14:23   ` [PATCH v3 0/2] VT: Add ability to get font requirements legion
2024-03-12 14:23     ` [PATCH v3 1/2] VT: Add KDFONTINFO ioctl legion
2024-03-15  9:15       ` Helge Deller
2024-03-12 14:23     ` [PATCH v3 2/2] VT: Allow to get max font width and height legion
2024-03-13 17:40       ` Oleg Bulatov
2024-04-02 11:09         ` Jiri Slaby
2024-03-15  9:16       ` Helge Deller
2024-04-02 10:32     ` [RESEND PATCH v3 0/2] VT: Add ability to get font requirements Alexey Gladkov
2024-04-02 10:32       ` [RESEND PATCH v3 1/2] VT: Add KDFONTINFO ioctl Alexey Gladkov
2024-04-02 11:02         ` Jiri Slaby
2024-04-02 13:19           ` Alexey Gladkov
2024-04-03  5:27             ` Jiri Slaby
2024-04-10 16:29               ` Alexey Gladkov
2024-04-10 17:11                 ` Greg Kroah-Hartman
2024-04-02 17:50           ` [PATCH v4 0/3] VT: Add ability to get font requirements Alexey Gladkov
2024-04-02 17:50             ` [PATCH v4 1/3] VT: Use macros to define ioctls Alexey Gladkov
2024-04-02 17:50             ` [PATCH v4 2/3] VT: Add KDFONTINFO ioctl Alexey Gladkov
2024-04-03  4:55               ` Greg Kroah-Hartman
2024-04-03  5:05               ` Jiri Slaby
2024-04-10 16:36                 ` Alexey Gladkov
2024-04-11  3:53                   ` Jiri Slaby
2024-04-02 17:50             ` [PATCH v4 3/3] VT: Allow to get max font width and height Alexey Gladkov
2024-04-17 17:37             ` [PATCH v5 0/3] VT: Add ability to get font requirements Alexey Gladkov
2024-04-17 17:37               ` [PATCH v5 1/3] VT: Use macros to define ioctls Alexey Gladkov
2024-04-18  6:18                 ` Greg Kroah-Hartman
2024-04-17 17:37               ` [PATCH v5 2/3] VT: Add KDFONTINFO ioctl Alexey Gladkov
2024-04-17 19:31                 ` Helge Deller
2024-04-18 10:45                   ` Alexey Gladkov
2024-04-25 10:33                     ` Helge Deller
2024-04-25 11:06                       ` Alexey Gladkov
2024-04-25 11:35                         ` Helge Deller
2024-04-18  6:18                 ` Greg Kroah-Hartman
2024-04-18 10:27                   ` Alexey Gladkov
2024-04-17 17:37               ` [PATCH v5 3/3] VT: Allow to get max font width and height Alexey Gladkov
2024-04-02 10:32       ` [RESEND PATCH v3 2/2] " Alexey Gladkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3fe608ece222f7782eff0fe714faf6439197090.1708011391.git.legion@kernel.org \
    --to=legion@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).