linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	joaodias@google.com, willy@infradead.org, david@redhat.com,
	surenb@google.com, John Hubbard <jhubbard@nvidia.com>,
	Nicolas Chauvet <kwizart@gmail.com>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v4] mm: cma: support sysfs
Date: Fri, 19 Mar 2021 20:41:40 +0300	[thread overview]
Message-ID: <f451e60c-750f-a6d8-e035-e665391f9261@gmail.com> (raw)
In-Reply-To: <82bde114-60c0-3fde-43f4-844522b80673@gmail.com>

19.03.2021 20:29, Dmitry Osipenko пишет:
> +void cma_sysfs_alloc_pages_count(struct cma *cma, size_t count)
> +{
> +	atomic64_add(count, &cma->nr_pages_succeeded);
> +}
> +
> +void cma_sysfs_fail_pages_count(struct cma *cma, size_t count)
> +{
> +	atomic64_add(count, &cma->nr_pages_failed);
> +}

The atomic looks good, but aren't CMA allocations already protected by
the CMA core? Do we really need to worry about racing here?

  reply	other threads:[~2021-03-19 17:42 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09  6:23 [PATCH v4] mm: cma: support sysfs Minchan Kim
2021-03-19 12:44 ` Dmitry Osipenko
2021-03-19 13:39   ` Dmitry Osipenko
2021-03-19 13:42     ` Greg Kroah-Hartman
2021-03-19 13:45       ` Dmitry Osipenko
2021-03-19 13:47         ` Greg Kroah-Hartman
2021-03-19 13:51           ` Dmitry Osipenko
2021-03-19 14:19             ` Dmitry Osipenko
2021-03-19 14:27               ` Greg Kroah-Hartman
2021-03-19 15:38                 ` Dmitry Osipenko
2021-03-19 15:50                   ` Greg Kroah-Hartman
2021-03-19 16:24                     ` Dmitry Osipenko
2021-03-19 16:30                       ` Minchan Kim
2021-03-19 17:29                         ` Dmitry Osipenko
2021-03-19 17:41                           ` Dmitry Osipenko [this message]
2021-03-19 17:44                             ` Dmitry Osipenko
2021-03-19 18:07                           ` Matthew Wilcox
2021-03-19 18:18                           ` Minchan Kim
2021-03-19 18:59                             ` Dmitry Osipenko
2021-03-19 19:00                             ` Dmitry Osipenko
2021-03-19 17:56                         ` Dmitry Osipenko
2021-03-19 18:21                           ` Minchan Kim
2021-03-19 18:48                             ` Dmitry Osipenko
2021-03-19 19:03                               ` Minchan Kim
2021-03-19 19:24                                 ` Dmitry Osipenko
2021-03-20  7:52                                   ` Greg Kroah-Hartman
2021-03-22 14:44                                     ` Dmitry Osipenko
2021-03-19 13:45     ` Dmitry Osipenko
  -- strict thread matches above, loose matches on Subject: below --
2021-03-04 16:17 Minchan Kim
2021-03-05 17:34 ` David Hildenbrand
2021-03-05 20:34   ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f451e60c-750f-a6d8-e035-e665391f9261@gmail.com \
    --to=digetx@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jhubbard@nvidia.com \
    --cc=joaodias@google.com \
    --cc=kwizart@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=surenb@google.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).