From: Barret Rhoden <brho@google.com>
To: Borislav Petkov <bp@alien8.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Josh Bleecher Snyder <josharian@gmail.com>,
"Rik van Riel\"" <riel@surriel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
ian@airs.com
Subject: Re: [PATCH] x86/fpu: Don't cache access to fpu_fpregs_owner_ctx
Date: Wed, 27 Nov 2019 13:42:47 -0500 [thread overview]
Message-ID: <f4d5ca28-a388-c382-4b1a-4b65c9f9e6e7@google.com> (raw)
In-Reply-To: <20191127140754.GB3812@zn.tnic>
>> Use this_cpu_read() instead this_cpu_read_stable() to avoid caching of
>> fpu_fpregs_owner_ctx during preemption points.
>>
>> Fixes: 5f409e20b7945 ("x86/fpu: Defer FPU state load until return to userspace")
>
> Or
>
> a352a3b7b792 ("x86/fpu: Prepare copy_fpstate_to_sigframe() for TIF_NEED_FPU_LOAD")
>
> maybe, which adds the fpregs_unlock() ?
Using this_cpu_read_stable() (or some variant) seems to go back quite a
while; not sure when exactly it became a problem. If it helps, commit
d9c9ce34ed5c ("x86/fpu: Fault-in user stack if
copy_fpstate_to_sigframe() fails") was the one that popped up the most
during Austin's bisection.
>> Also I would like to add
>> Debugged-by: Ian Lance Taylor
>
> Yes, pls. CCed.
To close the loop on this, here's what Austin wrote on the bugzilla:
> --- Comment #2 from Austin Clements (austin@google.com) ---
> I can confirm that the patch posted by Sebastian Andrzej Siewior at
> https://lkml.org/lkml/2019/11/27/304 fixes the issue both in our C reproducer
> and in our original Go reproducer. (Sorry, I'm not subscribed to LKML, so I
> can't reply there, and I'm on an airplane, so it's hard to get subscribed :)
>
> Regarding the question about the "Debugged-by" line in the patch, debugging was
> a joint effort between myself (Austin Clements <austin@google.com>), David
> Chase <drchase@golang.org>, and Ian Lance Taylor <ian@airs.com>.
Thanks,
Barret
next prev parent reply other threads:[~2019-11-27 18:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 19:49 AVX register corruption from signal delivery Barret Rhoden
2019-11-26 20:20 ` Sebastian Andrzej Siewior
2019-11-26 21:23 ` Barret Rhoden
2019-11-26 22:13 ` Borislav Petkov
2019-11-26 22:30 ` Andy Lutomirski
2019-11-26 23:00 ` Borislav Petkov
2019-11-27 12:42 ` [PATCH] x86/fpu: Don't cache access to fpu_fpregs_owner_ctx Sebastian Andrzej Siewior
2019-11-27 14:07 ` Borislav Petkov
2019-11-27 18:42 ` Barret Rhoden [this message]
2019-11-28 8:53 ` [PATCH v2] " Sebastian Andrzej Siewior
2019-11-28 9:22 ` [tip: x86/urgent] " tip-bot2 for Sebastian Andrzej Siewior
2019-11-29 16:57 ` [PATCH v2] " David Laight
2019-11-29 17:08 ` 'Sebastian Andrzej Siewior'
2019-11-27 15:46 ` [PATCH] " Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4d5ca28-a388-c382-4b1a-4b65c9f9e6e7@google.com \
--to=brho@google.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=ian@airs.com \
--cc=josharian@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=riel@surriel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).