From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E45FC433EF for ; Sat, 4 Sep 2021 08:19:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F047F61051 for ; Sat, 4 Sep 2021 08:19:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236231AbhIDIUS (ORCPT ); Sat, 4 Sep 2021 04:20:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233631AbhIDIUQ (ORCPT ); Sat, 4 Sep 2021 04:20:16 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6409AC061575 for ; Sat, 4 Sep 2021 01:19:14 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id z4so1861691wrr.6 for ; Sat, 04 Sep 2021 01:19:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gLBqd1uqKEOE9KnJQN01qkPds0zXVAe53OV7TgbrXgA=; b=fWyxRih6F6782YcktuzoocJ0uacfs/jeSAfvGpLXrrbJcz7HmuW2GlA3rTZlqao8a/ 4j4xj8ZFUUnyXTWvxNwx4qsp9DS9BR61Pbuvaims8eZ/x+40FtS1JidM7EUIFYwyxNMU hmPHg+4n3m9U2o1FB8vAsm9hOsOFozcta2OEoVZF9KEJ1cJovfXwVGblBUy+SeWL046B nmwu/j7JbvnOXTAY8ZW34nOnmsJsAyfsUnEsfbVrQa4uF976xmKlgt9KSqC8Y6T1azSn JnlUcHQNnCoHLrkDcGp6KSXOSe2igjGQrd8zqLPDneFuEheKTVz4FF3R/7xwThWiq0Ao i3Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gLBqd1uqKEOE9KnJQN01qkPds0zXVAe53OV7TgbrXgA=; b=VNgHEjLNEpp25cc85Mfx3y/dIwivHoQwuW5S5iIO1vkbmmGXekNSr9Nk+6b8/lxAqY DUBGaGzz5IIDUUbhOmBWA4MNqnGUU26W/u6pTvt6lBuog+eGvaBWd5AUXLUz6GfDMztx 5NqnWvgeNDE7i5S2e6kpo/4qq5wpTv2ZcrMOzR/kvNO2ZNEsecaZOJBi6J0AjpqspcmP LXIVJgP1qZl6E4Cq7Gsmxk85nsdxnYSpr6kwZkb/2ce9ZFz1ibmIgStOJadi1Ia2oyDM Pz0fADvkiYzPRlYckYtkK5q6ZFDpr9LNTI1LnGmCPa2kz/MbT1dQsQ3pz8w+/2V8XB4N XZ7A== X-Gm-Message-State: AOAM530F5FIhvpR/zX2vFJhsxfgoU/3XKUkv+phXw3oprj8PKF7ZVdRL hTjc2QbKoLxBufvvBas6ikdoWxUqDCrSPUoO X-Google-Smtp-Source: ABdhPJxTEfi7wo48onKasC03NgWdpJOuY26UgR1Fto5iye7w4jFN5E8MbCcW7loCUeF2JdytRQFNIQ== X-Received: by 2002:adf:f884:: with SMTP id u4mr2753396wrp.411.1630743552456; Sat, 04 Sep 2021 01:19:12 -0700 (PDT) Received: from ?IPv6:2001:861:44c0:66c0:24ba:d992:7a87:1fae? ([2001:861:44c0:66c0:24ba:d992:7a87:1fae]) by smtp.gmail.com with ESMTPSA id g143sm1444019wme.16.2021.09.04.01.19.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Sep 2021 01:19:11 -0700 (PDT) Subject: Re: [PATCH v2 3/3] arm64: dts: meson-axg: add support for JetHub D1 To: Vyacheslav Bocharov , Kevin Hilman Cc: linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210903060035.844758-1-adeep@lexina.in> <20210903060035.844758-4-adeep@lexina.in> From: Neil Armstrong Message-ID: Date: Sat, 4 Sep 2021 10:19:10 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210903060035.844758-4-adeep@lexina.in> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Le 03/09/2021 à 08:00, Vyacheslav Bocharov a écrit : > JetHome Jethub D1 (http://jethome.ru/jethub-d1) is a home automation controller with the following features: > - DIN Rail Mounting > - Amlogic A113X (ARM Cortex-A53) quad-core up to 1.5GHz > - no video out > - 512Mb/1GB LPDDR4 > - 8/16GB eMMC flash > - 1 x USB 2.0 > - 1 x 10/100Mbps ethernet > - WiFi / Bluetooth AMPAK AP6255 (Broadcom BCM43455) IEEE 802.11a/b/g/n/ac, Bluetooth 4.2. > - TI CC2538 + CC2592 Zigbee Wireless Module with up to 20dBm output power and Zigbee 3.0 support. > - 2 x gpio LEDS > - GPIO user Button > - 1 x 1-Wire > - 2 x RS-485 > - 4 x dry contact digital GPIO inputs > - 3 x relay GPIO outputs > - DC source with a voltage of 9 to 56 V / Passive POE > > Signed-off-by: Vyacheslav Bocharov > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../amlogic/meson-axg-jethome-jethub-j100.dts | 348 ++++++++++++++++++ > 2 files changed, 349 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > index 2c3ce7c401a5..3ba6f58b9833 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > dtb-$(CONFIG_ARCH_MESON) += meson-axg-s400.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-axg-jethome-jethub-j100.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-g12a-sei510.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-g12a-u200.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts > new file mode 100644 > index 000000000000..f94babe5ae49 > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts > @@ -0,0 +1,348 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2021 Vyacheslav Bocharov > + * Copyright (c) 2020 JetHome > + * Author: Aleksandr Kazantsev > + * Author: Alexey Shevelkin > + * Author: Vyacheslav Bocharov > + */ > + > +/dts-v1/; > + > +#include "meson-axg.dtsi" > +#include > +#include > + > +/ { > + aliases { > + serial0 = &uart_AO; /* Console */ > + serial1 = &uart_AO_B; /* External UART (Wireless Module) */ > + ethernet0 = ðmac; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + /* 1024MB RAM */ > + memory@0 { > + device_type = "memory"; > + reg = <0x0 0x0 0x0 0x40000000>; > + }; > + > + reserved-memory { > + linux,cma { > + size = <0x0 0x400000>; > + }; > + }; > + > + emmc_pwrseq: emmc-pwrseq { > + compatible = "mmc-pwrseq-emmc"; > + reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>; > + }; > + > + vcc_3v3: regulator-vcc_3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "VCC_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&vddao_3v3>; > + regulator-always-on; > + }; > + > + vcc_5v: regulator-vcc_5v { > + compatible = "regulator-fixed"; > + regulator-name = "VCC5V"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-always-on; > + }; > + > + vddao_3v3: regulator-vddao_3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "VDDAO_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&vcc_5v>; > + regulator-always-on; > + }; > + > + vddio_ao18: regulator-vddio_ao18 { > + compatible = "regulator-fixed"; > + regulator-name = "VDDIO_AO18"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vddao_3v3>; > + regulator-always-on; > + }; > + > + vddio_boot: regulator-vddio_boot { > + compatible = "regulator-fixed"; > + regulator-name = "VDDIO_BOOT"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vddao_3v3>; > + regulator-always-on; > + }; > + > + usb_pwr: regulator-usb_pwr { > + compatible = "regulator-fixed"; > + regulator-name = "USB_PWR"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + vin-supply = <&vcc_5v>; > + regulator-always-on; > + }; > + > + sdio_pwrseq: sdio-pwrseq { > + compatible = "mmc-pwrseq-simple"; > + reset-gpios = <&gpio GPIOX_7 GPIO_ACTIVE_LOW>; > + clocks = <&wifi32k>; > + clock-names = "ext_clock"; > + }; > + > + wifi32k: wifi32k { > + compatible = "pwm-clock"; > + #clock-cells = <0>; > + clock-frequency = <32768>; > + pwms = <&pwm_ab 0 30518 0>; /* PWM_A at 32.768KHz */ > + }; > + > + thermal-zones { > + cpu_thermal: cpu-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <&scpi_sensors 0>; > + trips { > + cpu_passive: cpu-passive { > + temperature = <70000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "passive"; > + }; > + cpu_hot: cpu-hot { > + temperature = <80000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "hot"; > + }; > + cpu_critical: cpu-critical { > + temperature = <100000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "critical"; > + }; > + }; > + }; > + cpu_cooling_maps: cooling-maps { > + map0 { > + trip = <&cpu_passive>; > + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + map1 { > + trip = <&cpu_hot>; > + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > +}; Clould you add blank lines between the nodes and between the attributes and nodes ? > + > +&efuse { > + sn: sn@14 { > + reg = <0x14 0x10>; > + }; > + eth_mac: eth_mac@0 { > + reg = <0x0 0x6>; > + }; > + bt_mac: bt_mac@6 { > + reg = <0x6 0x6>; > + }; > + wifi_mac: wifi_mac@c { > + reg = <0xc 0x6>; > + }; > + bid: bid@12 { > + reg = <0x12 0x20>; > + }; > + serial: serial@32 { > + reg = <0x32 0x20>; > + }; > +}; Same here > + > +ðmac { > + status = "okay"; > + pinctrl-0 = <ð_rmii_x_pins>; > + pinctrl-names = "default"; > + phy-handle = <ð_phy0>; > + phy-mode = "rmii"; > + > + mdio { > + compatible = "snps,dwmac-mdio"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* ICPlus IP101A/G Ethernet PHY (vendor_id=0x0243, model_id=0x0c54) */ > + eth_phy0: ethernet-phy@0 { > + /* compatible = "ethernet-phy-id0243.0c54";*/ > + max-speed = <100>; > + reg = <0>; > + > + reset-assert-us = <10000>; > + reset-deassert-us = <10000>; > + reset-gpios = <&gpio GPIOZ_5 GPIO_ACTIVE_LOW>; > + }; > + }; > +}; > + > +/* Internal I2C bus (on CPU module) */ > +&i2c1 { > + status = "okay"; > + pinctrl-0 = <&i2c1_z_pins>; > + pinctrl-names = "default"; > + > + /* RTC */ > + pcf8563: pcf8563@51 { > + compatible = "nxp,pcf8563"; > + reg = <0x51>; > + status = "okay"; > + }; > +}; > + > +/* Peripheral I2C bus (on motherboard) */ > +&i2c_AO { > + status = "okay"; > + pinctrl-0 = <&i2c_ao_sck_10_pins>, <&i2c_ao_sda_11_pins>; > + pinctrl-names = "default"; > +}; > + > +&pwm_ab { > + status = "okay"; > + pinctrl-0 = <&pwm_a_x20_pins>; > + pinctrl-names = "default"; > +}; > + > +/* wifi module */ > +&sd_emmc_b { > + status = "okay"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + pinctrl-0 = <&sdio_pins>; > + pinctrl-1 = <&sdio_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + > + bus-width = <4>; > + cap-sd-highspeed; > + sd-uhs-sdr104; > + max-frequency = <200000000>; > + non-removable; > + disable-wp; > + > + mmc-pwrseq = <&sdio_pwrseq>; > + > + vmmc-supply = <&vddao_3v3>; > + vqmmc-supply = <&vddio_boot>; > + > + brcmf: wifi@1 { > + reg = <1>; > + compatible = "brcm,bcm4329-fmac"; > + }; > +}; > + > +/* emmc storage */ > +&sd_emmc_c { > + status = "okay"; > + pinctrl-0 = <&emmc_pins>, <&emmc_ds_pins>; > + pinctrl-1 = <&emmc_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + > + bus-width = <8>; > + cap-mmc-highspeed; > + max-frequency = <200000000>; > + non-removable; > + disable-wp; > + mmc-ddr-1_8v; > + mmc-hs200-1_8v; > + > + mmc-pwrseq = <&emmc_pwrseq>; > + > + vmmc-supply = <&vcc_3v3>; > + vqmmc-supply = <&vddio_boot>; > +}; > + > +/* UART Bluetooth */ > +&uart_B { > + status = "okay"; > + pinctrl-0 = <&uart_b_z_pins>, <&uart_b_z_cts_rts_pins>; > + pinctrl-names = "default"; > + uart-has-rtscts; > + > + bluetooth { > + compatible = "brcm,bcm43438-bt"; > + shutdown-gpios = <&gpio GPIOZ_7 GPIO_ACTIVE_HIGH>; > + }; > +}; > + > +/* UART Console */ > +&uart_AO { > + status = "okay"; > + pinctrl-0 = <&uart_ao_a_pins>; > + pinctrl-names = "default"; > +}; > + > +/* UART Wireless module */ > +&uart_AO_B { > + status = "okay"; > + pinctrl-0 = <&uart_ao_b_pins>; > + pinctrl-names = "default"; > +}; > + > +&usb { > + status = "okay"; > + phy-supply = <&usb_pwr>; > +}; > + > +&spicc1 { > + status = "okay"; > +}; > + > +&gpio { > + gpio-line-names = > + "", "", "", "", "", // 0 - 4 > + "", "", "", "", "", // 5 - 9 > + "UserButton", "", "", "", "", // 10 - 14 > + "", "", "", "", "", // 15 - 19 > + "", "", "", "", "", // 20 - 24 > + "", "LEDRED", "LEDGREEN", "Output3", "Output2", // 25 - 29 Maybe those deserves leds nodes ? > + "Output1", "", "", "", "", // 30 - 34 > + "", "ZigBeeBOOT", "", "", "", // 35 - 39 > + "", "ZigBeeRESET", "", "Input4", "Input3", // 40 - 44 > + "Input2", "Input1", "", "", "", // 45 - 49 > + "", "", "", "", "", // 50 - 54 > + "", "", "", "", "", // 55 - 59 > + "", "", "", "", "", // 60 - 64 > + "", "", "", "", "", // 65 - 69 > + "", "", "", "", "", // 70 - 74 > + "", "", "", "", "", // 75 - 79 > + "", "", "", "", "", // 80 - 84 > + "", ""; // 85-86 > +}; > + > +&cpu0 { > + #cooling-cells = <2>; > +}; > + > +&cpu1 { > + #cooling-cells = <2>; > +}; > + > +&cpu2 { > + #cooling-cells = <2>; > +}; > + > +&cpu3 { > + #cooling-cells = <2>; > +}; > + > Thanks, Neil