From: David Laight <David.Laight@ACULAB.COM>
To: 'Matthew Wilcox' <willy@infradead.org>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Matteo Croce <mcroce@linux.microsoft.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Arnd Bergmann <arnd@kernel.org>, "Christoph Hellwig" <hch@lst.de>
Subject: RE: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems
Date: Fri, 16 Apr 2021 07:32:35 +0000 [thread overview]
Message-ID: <f51e1aa98cb94880a236d58c75c20994@AcuMS.aculab.com> (raw)
In-Reply-To: <20210415222211.GG2531743@casper.infradead.org>
From: Matthew Wilcox <willy@infradead.org>
> Sent: 15 April 2021 23:22
>
> On Thu, Apr 15, 2021 at 09:11:56PM +0000, David Laight wrote:
> > Isn't it possible to move the field down one long?
> > This might require an explicit zero - but this is not a common
> > code path - the extra write will be noise.
>
> Then it overlaps page->mapping. See emails passim.
The rules on overlaps make be wonder if every 'long'
should be in its own union.
The comments would need to say when each field is used.
It would, at least, make these errors less common.
That doesn't solve the 64bit dma_addr though.
Actually rather that word-swapping dma_addr on 32bit BE
could you swap over the two fields it overlays with.
That might look messy in the .h, but it doesn't require
an accessor function to do the swap - easily missed.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-04-16 7:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 20:52 [PATCH 0/1] Fix struct page layout on 32-bit systems Matthew Wilcox (Oracle)
2021-04-10 20:52 ` [PATCH 1/1] mm: " Matthew Wilcox (Oracle)
2021-04-11 9:43 ` Jesper Dangaard Brouer
2021-04-11 10:33 ` Matthew Wilcox
2021-04-12 1:15 ` Matthew Wilcox
2021-04-14 8:10 ` Jesper Dangaard Brouer
2021-04-14 11:50 ` Matthew Wilcox
2021-04-14 11:56 ` Ilias Apalodimas
2021-04-14 15:52 ` David Laight
2021-04-14 19:13 ` Jesper Dangaard Brouer
2021-04-14 21:35 ` Matthew Wilcox
2021-04-14 21:56 ` David Laight
2021-04-15 18:08 ` Jesper Dangaard Brouer
2021-04-15 18:21 ` Matthew Wilcox
2021-04-15 21:11 ` David Laight
2021-04-15 22:22 ` Matthew Wilcox
2021-04-16 7:32 ` David Laight [this message]
2021-04-16 11:05 ` Matthew Wilcox
2021-04-16 15:27 ` Matthew Wilcox
2021-04-16 17:08 ` Jesper Dangaard Brouer
2021-04-17 3:19 ` Matthew Wilcox
2021-04-17 10:31 ` Arnd Bergmann
2021-04-17 13:56 ` Matthew Wilcox
2021-04-17 17:30 ` Arnd Bergmann
2021-04-17 10:59 ` David Laight
2021-04-19 6:34 ` Christoph Hellwig
2021-04-19 7:15 ` Ilias Apalodimas
2021-04-12 18:23 ` Matthew Wilcox
2021-04-13 8:21 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f51e1aa98cb94880a236d58c75c20994@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=arnd@kernel.org \
--cc=brouer@redhat.com \
--cc=grygorii.strashko@ti.com \
--cc=hch@lst.de \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mcroce@linux.microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).