From: Gavin Shan <gshan@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
alexander.duyck@gmail.com, david@redhat.com,
akpm@linux-foundation.org, anshuman.khandual@arm.com,
catalin.marinas@arm.com, will@kernel.org, shan.gavin@gmail.com
Subject: Re: [PATCH v5 0/4] mm/page_reporting: Make page reporting work on arm64 with 64KB page size
Date: Fri, 25 Jun 2021 16:17:22 +1000 [thread overview]
Message-ID: <f5f3a7df-6a20-2835-7d49-9c3f10ef8978@redhat.com> (raw)
In-Reply-To: <20210625015826-mutt-send-email-mst@kernel.org>
On 6/25/21 3:58 PM, Michael S. Tsirkin wrote:
> On Fri, Jun 25, 2021 at 12:21:46PM +0800, Gavin Shan wrote:
>> The page reporting threshold is currently equal to @pageblock_order, which
>> is 13 and 512MB on arm64 with 64KB base page size selected. The page
>> reporting won't be triggered if the freeing page can't come up with a free
>> area like that huge. The condition is hard to be met, especially when the
>> system memory becomes fragmented.
>>
>> This series intends to solve the issue by having page reporting threshold
>> as 5 (2MB) on arm64 with 64KB base page size. The patches are organized as:
>>
>> PATCH[1/4] Fix some coding style in __page_reporting_request().
>> PATCH[2/4] Represents page reporting order with variable so that it can
>> be exported as module parameter.
>> PATCH[3/4] Allows the device driver (e.g. virtio_balloon) to specify
>> the page reporting order when the device info is registered.
>> PATCH[4/4] Specifies the page reporting order to 5, corresponding to
>> 2MB in size on ARM64 when 64KB base page size is used.
>
> I sent comments on v4. They still apply I think. Want me to repeat them
> here?
>
Thanks for your comments, Michael. I've replied to your comments
through v4. There are some future work as Alex and David pointed
out before: In order to remove the hack in virtio-memballoon, the
VMM needs to report the page reporting order. I will keep working
on this when I have spare time.
Thanks,
Gavin
>> Changelog
>> =========
>> v5:
>> * Restore @page_reporting_order to @pageblock_order when
>> device is registered in PATCH[2/4] to keep "git bisect"
>> friendly at least. (Alex)
>> v4:
>> * Set @page_reporting_order to MAX_ORDER. Its value is
>> specified by the driver or falls back to @pageblock_order
>> when page reporting device is registered. (Alex)
>> * Include "module.h" in page_reporting.c (Andrew)
>> v3:
>> * Avoid overhead introduced by function all (Alex)
>> * Export page reporting order as module parameter (Gavin)
>> v2:
>> * Rewrite the patches as Alex suggested (Alex)
>>
>> Gavin Shan (4):
>> mm/page_reporting: Fix code style in __page_reporting_request()
>> mm/page_reporting: Export reporting order as module parameter
>> mm/page_reporting: Allow driver to specify reporting
>> virtio_balloon: Specify page reporting order if needed
>>
>> .../admin-guide/kernel-parameters.txt | 6 +++++
>> drivers/virtio/virtio_balloon.c | 17 ++++++++++++++
>> include/linux/page_reporting.h | 3 +++
>> mm/page_reporting.c | 22 +++++++++++++++----
>> mm/page_reporting.h | 5 ++---
>> 5 files changed, 46 insertions(+), 7 deletions(-)
>>
>> --
>> 2.23.0
>
next prev parent reply other threads:[~2021-06-25 6:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 4:21 [PATCH v5 0/4] mm/page_reporting: Make page reporting work on arm64 with 64KB page size Gavin Shan
2021-06-25 4:21 ` [PATCH v5 1/4] mm/page_reporting: Fix code style in __page_reporting_request() Gavin Shan
2021-06-25 4:21 ` [PATCH v5 2/4] mm/page_reporting: Export reporting order as module parameter Gavin Shan
2021-06-25 4:21 ` [PATCH v5 3/4] mm/page_reporting: Allow driver to specify reporting Gavin Shan
2021-06-25 4:21 ` [PATCH v5 4/4] virtio_balloon: Specify page reporting order if needed Gavin Shan
2021-06-25 5:58 ` [PATCH v5 0/4] mm/page_reporting: Make page reporting work on arm64 with 64KB page size Michael S. Tsirkin
2021-06-25 6:17 ` Gavin Shan [this message]
2021-06-25 14:18 ` Alexander Duyck
2021-06-28 9:45 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5f3a7df-6a20-2835-7d49-9c3f10ef8978@redhat.com \
--to=gshan@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=shan.gavin@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).