From: Dan Murphy <dmurphy@ti.com>
To: Luca Weiss <luca@z3ntu.xyz>, <linux-leds@vger.kernel.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] leds: add sgm3140 driver
Date: Thu, 5 Mar 2020 06:54:10 -0600 [thread overview]
Message-ID: <f61133d9-be0f-366a-7b77-1f366d2cd8d6@ti.com> (raw)
In-Reply-To: <11515555.O9o76ZdvQC@g550jk>
Luca
On 3/5/20 5:01 AM, Luca Weiss wrote:
> On Donnerstag, 27. Februar 2020 20:50:40 CET Dan Murphy wrote:
>> Luca
>>
>> On 2/27/20 12:50 PM, Luca Weiss wrote:
>>> Add a driver for the SGMICRO SGM3140 Buck/Boost Charge Pump LED driver.
>>>
>>> This device is controller by two GPIO lines, one for enabling the LED
>>> and the second one for switching between torch and flash mode.
>>>
>>> The device will automatically switch to torch mode after being in flash
>>> mode for about 250-300ms, so after that time the driver will turn the
>>> LED off again automatically.
>>>
>>> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
>>> ---
>> You seem to be missing the devictree bindings doc for the GPIOs.
> As written in the initial email:
>
>> I will also write dt bindings for the driver once I have "strobe"
>> working.
NACK.
We review bindings as part of the code. And we want to understand what
bindings the code will be using
You will get better guidance if the patch set contains the documentation
so we can understand what is being proposed.
Dan
next prev parent reply other threads:[~2020-03-05 12:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 18:50 [RFC PATCH] leds: add sgm3140 driver Luca Weiss
2020-02-27 19:50 ` Dan Murphy
2020-03-05 11:01 ` Luca Weiss
2020-03-05 12:54 ` Dan Murphy [this message]
2020-03-05 21:09 ` Jacek Anaszewski
2020-03-08 11:32 ` Luca Weiss
2020-03-08 16:47 ` Jacek Anaszewski
2020-03-08 16:55 ` Luca Weiss
2020-03-08 17:21 ` Jacek Anaszewski
2020-03-08 12:08 ` Pavel Machek
2020-03-08 12:31 ` Luca Weiss
2020-03-08 17:07 ` Jacek Anaszewski
2020-03-08 12:11 ` Pavel Machek
2020-03-08 12:37 ` Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f61133d9-be0f-366a-7b77-1f366d2cd8d6@ti.com \
--to=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).