From: Guenter Roeck <linux@roeck-us.net>
To: Badhri Jagan Sridharan <badhri@google.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] usb: typec: tcpm: Update vbus_vsafe0v on init
Date: Fri, 11 Dec 2020 07:15:26 -0800 [thread overview]
Message-ID: <f6196a7e-0953-d458-a7d7-75e30446b407@roeck-us.net> (raw)
In-Reply-To: <20201211071911.2205197-1-badhri@google.com>
On 12/10/20 11:19 PM, Badhri Jagan Sridharan wrote:
> During init, vbus_vsafe0v does not get updated till the first
> connect as a sink. This causes TCPM to be stuck in SRC_ATTACH_WAIT
> state while booting with a sink (For instance: a headset) connected.
>
> [ 1.429168] Start toggling
> [ 1.439907] CC1: 0 -> 0, CC2: 0 -> 0 [state TOGGLING, polarity 0, disconnected]
> [ 1.445242] CC1: 0 -> 0, CC2: 0 -> 0 [state TOGGLING, polarity 0, disconnected]
> [ 53.358528] CC1: 0 -> 0, CC2: 0 -> 2 [state TOGGLING, polarity 0, connected]
> [ 53.358564] state change TOGGLING -> SRC_ATTACH_WAIT [rev1 NONE_AMS]
>
> Fix this by updating vbus_vsafe0v based on vbus_present status
> on boot.
>
> Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index cedc6cf82d61..58a6302c549f 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -4794,6 +4794,24 @@ static void tcpm_init(struct tcpm_port *port)
> if (port->vbus_present)
> port->vbus_never_low = true;
>
> + /*
> + * 1. When vbus_present is true, voltage on VBUS is already at VSAFE5V.
> + * So implicitly vbus_vsafe0v = false.
> + *
> + * 2. When vbus_present is false and TCPC does NOT support querying
> + * vsafe0v status, then, it's best to assume vbus is at VSAFE0V i.e.
> + * vbus_vsafe0v is true.
> + *
> + * 3. When vbus_present is false and TCPC does support querying vsafe0v,
> + * then, query tcpc for vsafe0v status.
> + */
> + if (port->vbus_present)
> + port->vbus_vsafe0v = false;
> + else if (!port->tcpc->is_vbus_vsafe0v)
> + port->vbus_vsafe0v = true;
> + else
> + port->vbus_vsafe0v = port->tcpc->is_vbus_vsafe0v(port->tcpc);
> +
> tcpm_set_state(port, tcpm_default_state(port), 0);
>
> if (port->tcpc->get_cc(port->tcpc, &cc1, &cc2) == 0)
>
prev parent reply other threads:[~2020-12-11 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 7:19 [PATCH v1] usb: typec: tcpm: Update vbus_vsafe0v on init Badhri Jagan Sridharan
2020-12-11 8:43 ` Heikki Krogerus
2020-12-11 15:15 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6196a7e-0953-d458-a7d7-75e30446b407@roeck-us.net \
--to=linux@roeck-us.net \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).