From: Robin Murphy <robin.murphy@arm.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Vivek Gautam <vivek.gautam@codeaurora.org>,
"list@263.net:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>,
Joerg Roedel <joro@8bytes.org>,
joro@8bytes.org, robh+dt <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will.deacon@arm.com>,
Rob Clark <robdclark@gmail.com>,
"list@263.net:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>,
Joerg Roedel <joro@8bytes.org>,
iommu@lists.linux-foundation.org, devicetree@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
Tomasz Figa <tfiga@chromium.org>,
jcrouse@codeaurora.org, Stephen Boyd <sboyd@codeaurora.org>,
Sricharan R <sricharan@codeaurora.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Archit Taneja <architt@codeaurora.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v8 4/5] iommu/arm-smmu: Add the device_link between masters and smmu
Date: Fri, 9 Mar 2018 12:34:42 +0000 [thread overview]
Message-ID: <f6822915-8921-c9cc-218a-f094ac5ed032@arm.com> (raw)
In-Reply-To: <CAFp+6iFzGYWZMLkNrN1ZJJ2xH4CxQsiU6oYboHDzL0jDwm+4VQ@mail.gmail.com>
On 09/03/18 07:11, Vivek Gautam wrote:
> On Thu, Mar 8, 2018 at 10:29 AM, Vivek Gautam
> <vivek.gautam@codeaurora.org> wrote:
>> On Wed, Mar 7, 2018 at 6:17 PM, Robin Murphy <robin.murphy@arm.com> wrote:
>>> On 02/03/18 10:10, Vivek Gautam wrote:
>>>>
>>>> From: Sricharan R <sricharan@codeaurora.org>
>>>>
>>>> Finally add the device link between the master device and
>>>> smmu, so that the smmu gets runtime enabled/disabled only when the
>>>> master needs it. This is done from add_device callback which gets
>>>> called once when the master is added to the smmu.
>>>>
>>>> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
>>>> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
>>>> ---
>>>> drivers/iommu/arm-smmu.c | 21 +++++++++++++++++++++
>>>> 1 file changed, 21 insertions(+)
>>>>
>>>> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
>>>> index 3d6a1875431f..bb1ea82c1003 100644
>>>> --- a/drivers/iommu/arm-smmu.c
>>>> +++ b/drivers/iommu/arm-smmu.c
>>>> @@ -217,6 +217,9 @@ struct arm_smmu_device {
>>>> /* IOMMU core code handle */
>>>> struct iommu_device iommu;
>>>> +
>>>> + /* runtime PM link to master */
>>>> + struct device_link *link;
>>>
>>>
>>> Just the one?
>
> we will either have to count all the devices that are present on the
> iommu bus, or
> maintain a list to which all the links can be added.
> But to add the list, we will have to initialize a LIST_HEAD in struct
> device_link
> as well.
>
> Or, I think we don't even need to maintain a pointer to link with smmu.
> In arm_smmu_remove_device(), we can find out the correct link, and delete it.
>
> list_for_each_entry(link, &dev->links.suppliers, c_node)
> if (link->supplier == smmu->dev);
> device_link_del(link);
>
> Should that be fine?
>
> Rafael, does the above snippet looks right to you? Context: smmu->dev
> is the supplier, and dev is the consumer. We want to find the link,
> and delete it.
Actually, looking at the existing code, it seems like device_link_add()
will in fact look up and return any existing link between a given
supplier and consumer - is that intentional API behaviour that users may
rely on to avoid keeping track of explicit link pointers? (or
conversely, might it be reasonable to factor out a device_link_find()
function?)
Robin.
next prev parent reply other threads:[~2018-03-09 12:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 10:10 [PATCH v8 0/5] iommu/arm-smmu: Add runtime pm/sleep support Vivek Gautam
2018-03-02 10:10 ` [PATCH v8 1/5] iommu/arm-smmu: Destroy domain context in failure path Vivek Gautam
2018-03-07 12:20 ` Robin Murphy
2018-03-08 5:32 ` Vivek Gautam
2018-03-02 10:10 ` [PATCH v8 2/5] iommu/arm-smmu: Add pm_runtime/sleep ops Vivek Gautam
2018-03-02 10:10 ` [PATCH v8 3/5] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device Vivek Gautam
2018-03-07 12:38 ` Robin Murphy
2018-03-07 13:52 ` Tomasz Figa
2018-03-07 16:58 ` Robin Murphy
2018-03-08 4:33 ` Tomasz Figa
2018-03-08 12:12 ` Robin Murphy
2018-03-09 4:50 ` Tomasz Figa
2018-03-09 17:36 ` Robin Murphy
2018-03-02 10:10 ` [PATCH v8 4/5] iommu/arm-smmu: Add the device_link between masters and smmu Vivek Gautam
2018-03-07 12:47 ` Robin Murphy
2018-03-08 4:59 ` Vivek Gautam
2018-03-09 7:11 ` Vivek Gautam
2018-03-09 12:34 ` Robin Murphy [this message]
2018-03-12 10:21 ` Vivek Gautam
2018-03-09 10:40 ` Vivek Gautam
2018-03-02 10:10 ` [PATCH v8 5/5] iommu/arm-smmu: Add support for qcom,smmu-v2 variant Vivek Gautam
2018-03-05 13:25 ` [PATCH v8 0/5] iommu/arm-smmu: Add runtime pm/sleep support Tomasz Figa
2018-03-05 17:19 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6822915-8921-c9cc-218a-f094ac5ed032@arm.com \
--to=robin.murphy@arm.com \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jcrouse@codeaurora.org \
--cc=joro@8bytes.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sricharan@codeaurora.org \
--cc=tfiga@chromium.org \
--cc=vivek.gautam@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).