From: Hans de Goede <hdegoede@redhat.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Matan Ziv-Av <matan@svgalib.org>,
Mark Gross <mgross@linux.intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 2/2] acpi: pnp: remove duplicated BRI0A49 and BDP3336 entries
Date: Tue, 21 Sep 2021 14:51:53 +0200 [thread overview]
Message-ID: <f78523c5-df88-a768-3b9a-d542bbd73a1c@redhat.com> (raw)
In-Reply-To: <20210916170054.136790-2-krzysztof.kozlowski@canonical.com>
Hi,
On 9/16/21 7:00 PM, Krzysztof Kozlowski wrote:
> BRI0A49 and BDP3336 are already on the list.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Rafael, I've picked up 1/2 since that applies to a drivers/platform/x86
driver. I'll leave picking this one up to you.
Regards,
Hans
> ---
> drivers/acpi/acpi_pnp.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
> index 8f2dc176bb41..ffdcfcd4a10d 100644
> --- a/drivers/acpi/acpi_pnp.c
> +++ b/drivers/acpi/acpi_pnp.c
> @@ -156,8 +156,6 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = {
> {"BRI0A49"}, /* Boca Complete Ofc Communicator 14.4 Data-FAX */
> {"BRI1400"}, /* Boca Research 33,600 ACF Modem */
> {"BRI3400"}, /* Boca 33.6 Kbps Internal FD34FSVD */
> - {"BRI0A49"}, /* Boca 33.6 Kbps Internal FD34FSVD */
> - {"BDP3336"}, /* Best Data Products Inc. Smart One 336F PnP Modem */
> {"CPI4050"}, /* Computer Peripherals Inc. EuroViVa CommCenter-33.6 SP PnP */
> {"CTL3001"}, /* Creative Labs Phone Blaster 28.8 DSVD PnP Voice */
> {"CTL3011"}, /* Creative Labs Modem Blaster 28.8 DSVD PnP Voice */
>
next prev parent reply other threads:[~2021-09-21 12:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 17:00 [PATCH 1/2] platform: lg-laptop: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
2021-09-16 17:00 ` [PATCH 2/2] acpi: pnp: remove duplicated BRI0A49 and BDP3336 entries Krzysztof Kozlowski
2021-09-21 12:51 ` Hans de Goede [this message]
2021-09-21 13:08 ` Rafael J. Wysocki
2021-09-24 16:13 ` Rafael J. Wysocki
2021-09-21 12:50 ` [PATCH 1/2] platform: lg-laptop: drop unneeded MODULE_ALIAS Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f78523c5-df88-a768-3b9a-d542bbd73a1c@redhat.com \
--to=hdegoede@redhat.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matan@svgalib.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).