linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
	Dave Hansen <dave.hansen@linux.intel.com>
Cc: dave@sr71.net, Dan Williams <dan.j.williams@intel.com>,
	Dave Jiang <dave.jiang@intel.com>,
	zwisler@kernel.org, vishal.l.verma@intel.com,
	thomas.lendacky@amd.com,
	Andrew Morton <akpm@linux-foundation.org>,
	mhocko@suse.com, linux-nvdimm@lists.01.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, Huang Ying <ying.huang@intel.com>,
	Wu Fengguang <fengguang.wu@intel.com>,
	Borislav Petkov <bp@suse.de>,
	baiyaowei@cmss.chinamobile.com, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 4/4] dax: "Hotplug" persistent memory for use like normal RAM
Date: Wed, 16 Jan 2019 13:53:03 -0800	[thread overview]
Message-ID: <f786481c-d38d-5129-318b-cb61b6251c47@intel.com> (raw)
In-Reply-To: <CAErSpo55j7odYf-B-KSoogabD9Qqt605oUGYe6td9wZdYNq_Hg@mail.gmail.com>

On 1/16/19 1:16 PM, Bjorn Helgaas wrote:
>> +       /*
>> +        * Set flags appropriate for System RAM.  Leave ..._BUSY clear
>> +        * so that add_memory() can add a child resource.
>> +        */
>> +       new_res->flags = IORESOURCE_SYSTEM_RAM;
> IIUC, new_res->flags was set to "IORESOURCE_MEM | ..." in the
> devm_request_mem_region() path.  I think you should keep at least
> IORESOURCE_MEM so the iomem_resource tree stays consistent.

I went to look at fixing this.  It looks like "IORESOURCE_SYSTEM_RAM"
includes IORESOURCE_MEM:

> #define IORESOURCE_SYSTEM_RAM           (IORESOURCE_MEM|IORESOURCE_SYSRAM)

Did you want the patch to expand this #define, or did you just want to
ensure that IORESORUCE_MEM got in there somehow?

  parent reply	other threads:[~2019-01-16 21:53 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16 18:18 [PATCH 0/4] Allow persistent memory to be used like normal RAM Dave Hansen
2019-01-16 18:19 ` [PATCH 1/4] mm/resource: return real error codes from walk failures Dave Hansen
2019-01-16 20:38   ` Bjorn Helgaas
2019-01-16 18:19 ` [PATCH 2/4] mm/memory-hotplug: allow memory resources to be children Dave Hansen
2019-01-16 19:16   ` Jerome Glisse
2019-01-16 23:01     ` Dave Hansen
2019-01-16 23:38       ` Jerome Glisse
2019-01-23 20:03         ` Dave Hansen
2019-01-23 20:15           ` Jerome Glisse
2019-01-18 19:58     ` Dave Hansen
2019-01-18 20:26       ` Jerome Glisse
2019-01-23 17:05   ` Michal Hocko
2019-01-16 18:19 ` [PATCH 3/4] dax/kmem: let walk_system_ram_range() search child resources Dave Hansen
2019-01-16 18:19 ` [PATCH 4/4] dax: "Hotplug" persistent memory for use like normal RAM Dave Hansen
2019-01-16 21:16   ` Bjorn Helgaas
2019-01-16 21:40     ` Dave Hansen
2019-01-16 21:44       ` Bjorn Helgaas
2019-01-16 22:06       ` Dan Williams
2019-01-16 21:53     ` Dave Hansen [this message]
2019-01-16 21:59       ` Bjorn Helgaas
2019-01-16 21:31   ` Dan Williams
2019-01-17  5:21   ` Du, Fan
2019-01-17 16:56     ` Dan Williams
2019-01-17  8:19   ` Yanmin Zhang
2019-01-17 15:17     ` Dave Hansen
2019-01-18  7:47       ` Yanmin Zhang
2019-01-18 15:20         ` Dave Hansen
2019-01-17 16:29 ` [PATCH 0/4] Allow persistent memory to be used " Jeff Moyer
2019-01-17 16:47   ` Keith Busch
2019-01-17 17:20     ` Jeff Moyer
2019-01-17 19:34       ` Keith Busch
2019-01-17 21:57         ` Jeff Moyer
2019-01-18 11:48       ` Fengguang Wu
2019-01-17 16:50   ` Dan Williams
2019-01-17 22:43   ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f786481c-d38d-5129-318b-cb61b6251c47@intel.com \
    --to=dave.hansen@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=baiyaowei@cmss.chinamobile.com \
    --cc=bhelgaas@google.com \
    --cc=bp@suse.de \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@sr71.net \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=mhocko@suse.com \
    --cc=thomas.lendacky@amd.com \
    --cc=tiwai@suse.de \
    --cc=vishal.l.verma@intel.com \
    --cc=ying.huang@intel.com \
    --cc=zwisler@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).