linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: Pravin Shelar <pshelar@ovn.org>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>, ovs dev <dev@openvswitch.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/2] openvswitch: support asymmetric conntrack
Date: Mon, 25 Nov 2019 10:38:56 -0500	[thread overview]
Message-ID: <f7t7e3o9d9r.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <f7twobwyl53.fsf@dhcp-25.97.bos.redhat.com> (Aaron Conole's message of "Mon, 18 Nov 2019 15:39:20 -0500")

Aaron Conole <aconole@redhat.com> writes:

> Pravin Shelar <pshelar@ovn.org> writes:
>
>> On Fri, Nov 8, 2019 at 1:07 PM Aaron Conole <aconole@redhat.com> wrote:
>>>
>>> The openvswitch module shares a common conntrack and NAT infrastructure
>>> exposed via netfilter.  It's possible that a packet needs both SNAT and
>>> DNAT manipulation, due to e.g. tuple collision.  Netfilter can support
>>> this because it runs through the NAT table twice - once on ingress and
>>> again after egress.  The openvswitch module doesn't have such capability.
>>>
>>> Like netfilter hook infrastructure, we should run through NAT twice to
>>> keep the symmetry.
>>>
>>> Fixes: 05752523e565 ("openvswitch: Interface with NAT.")
>>> Signed-off-by: Aaron Conole <aconole@redhat.com>
>>
>> The patch looks ok. But I am not able apply it. can you fix the encoding.
>
> Hrrm.  I didn't make any special changes (just used git send-email).  I
> will look at spinning a second patch.

Pravin,

I tried the following:

  10:36:59 aconole@dhcp-25 {(312434617cb1...)} ~/git/linux$ curl http://patchwork.ozlabs.org/patch/1192219/mbox/ > test.patch
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
  100  4827  100  4827    0     0   8824      0 --:--:-- --:--:-- --:--:--  8808
  10:37:21 aconole@dhcp-25 {(312434617cb1...)} ~/git/linux$ git am test.patch
  Applying: openvswitch: support asymmetric conntrack
  10:37:24 aconole@dhcp-25 {(f759cc2b7323...)} ~/git/linux$ 


Can you check your mailer settings?  The patchwork mbox worked fine, and
I was able to apply from my own mbox as well.

-Aaron


  reply	other threads:[~2019-11-25 15:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08 21:07 [PATCH net 1/2] openvswitch: support asymmetric conntrack Aaron Conole
2019-11-08 21:07 ` [PATCH net 2/2] act_ct: " Aaron Conole
2019-11-14 14:22   ` Roi Dayan
2019-11-14 14:24     ` Paul Blakey
2019-11-18 21:24       ` Aaron Conole
2019-11-14 16:29   ` Marcelo Ricardo Leitner
2019-11-18 21:21     ` Aaron Conole
2019-11-18 22:40       ` Marcelo Ricardo Leitner
2019-11-22 20:39         ` Aaron Conole
2019-11-22 20:43           ` Marcelo Ricardo Leitner
2019-11-09 22:15 ` [PATCH net 1/2] openvswitch: " Pravin Shelar
2019-11-18 20:39   ` Aaron Conole
2019-11-25 15:38     ` Aaron Conole [this message]
2019-11-26  4:07       ` Pravin Shelar
2019-11-12  8:52 ` Nicolas Dichtel
2019-11-18 21:19   ` Aaron Conole
2019-11-28  8:22     ` Nicolas Dichtel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7t7e3o9d9r.fsf@dhcp-25.97.bos.redhat.com \
    --to=aconole@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@ovn.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).