From: Chanwoo Choi <cw00.choi@samsung.com>
To: "Dmitry Osipenko" <digetx@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"MyungJoo Ham" <myungjoo.ham@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
"Peter Geis" <pgwipeout@gmail.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 15/18] PM / devfreq: Add new interrupt_driven flag for governors
Date: Mon, 4 Nov 2019 11:48:06 +0900 [thread overview]
Message-ID: <f86d35dc-1749-ad29-2023-7d69366bd0d1@samsung.com> (raw)
In-Reply-To: <20191103204130.2172-16-digetx@gmail.com>
Hi Dmitry,
Sorry for the additional comment of this patch.
I think that you better to change the 'interrupt_driven' checking
style as following in order to keep the consistency of governor
flag checking style.
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 27de8ddeaaa8..fe409fc1bcc4 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -410,9 +410,11 @@ static void devfreq_monitor(struct work_struct *work)
*/
void devfreq_monitor_start(struct devfreq *devfreq)
{
+ if (devfreq->governor->interrupt_driven)
+ return;
+
INIT_DEFERRABLE_WORK(&devfreq->work, devfreq_monitor);
if (devfreq->profile->polling_ms &&
- !devfreq->governor->interrupt_driven)
queue_delayed_work(devfreq_wq, &devfreq->work,
msecs_to_jiffies(devfreq->profile->polling_ms));
}
@@ -475,12 +477,15 @@ void devfreq_monitor_resume(struct devfreq *devfreq)
if (!devfreq->stop_polling)
goto out;
+ if (devfreq->governor->interrupt_driven)
+ goto out_update;
+
if (!delayed_work_pending(&devfreq->work) &&
devfreq->profile->polling_ms &&
- !devfreq->governor->interrupt_driven)
queue_delayed_work(devfreq_wq, &devfreq->work,
msecs_to_jiffies(devfreq->profile->polling_ms));
+out_update:
devfreq->last_stat_updated = jiffies;
devfreq->stop_polling = false;
If you edit it as following, feel free to add my reviewed-by tag:
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
On 19. 11. 4. 오전 5:41, Dmitry Osipenko wrote:
> Currently interrupt-driven governors (like NVIDIA Tegra30 ACTMON governor)
> are used to set polling_ms=0 in order to avoid periodic polling of device
> status by devfreq core. This means that polling interval can't be changed
> by userspace for such governors.
>
> The new governor flag allows interrupt-driven governors to convey that
> devfreq core shouldn't perform polling of device status and thus generic
> devfreq polling interval could be supported by these governors now.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/devfreq/devfreq.c | 9 +++++++--
> drivers/devfreq/governor.h | 3 +++
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index b905963cea7d..a711a76d386e 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -410,7 +410,8 @@ static void devfreq_monitor(struct work_struct *work)
> void devfreq_monitor_start(struct devfreq *devfreq)
> {
> INIT_DEFERRABLE_WORK(&devfreq->work, devfreq_monitor);
> - if (devfreq->profile->polling_ms)
> + if (devfreq->profile->polling_ms &&
> + !devfreq->governor->interrupt_driven)
> queue_delayed_work(devfreq_wq, &devfreq->work,
> msecs_to_jiffies(devfreq->profile->polling_ms));
> }
> @@ -474,7 +475,8 @@ void devfreq_monitor_resume(struct devfreq *devfreq)
> goto out;
>
> if (!delayed_work_pending(&devfreq->work) &&
> - devfreq->profile->polling_ms)
> + devfreq->profile->polling_ms &&
> + !devfreq->governor->interrupt_driven)
> queue_delayed_work(devfreq_wq, &devfreq->work,
> msecs_to_jiffies(devfreq->profile->polling_ms));
>
> @@ -509,6 +511,9 @@ void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay)
> if (devfreq->stop_polling)
> goto out;
>
> + if (devfreq->governor->interrupt_driven)
> + goto out;
> +
> /* if new delay is zero, stop polling */
> if (!new_delay) {
> mutex_unlock(&devfreq->lock);
> diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
> index bbe5ff9fcecf..dc7533ccc3db 100644
> --- a/drivers/devfreq/governor.h
> +++ b/drivers/devfreq/governor.h
> @@ -31,6 +31,8 @@
> * @name: Governor's name
> * @immutable: Immutable flag for governor. If the value is 1,
> * this govenror is never changeable to other governor.
> + * @interrupt_driven: Devfreq core won't schedule polling work for this
> + * governor if value is set to 1.
> * @get_target_freq: Returns desired operating frequency for the device.
> * Basically, get_target_freq will run
> * devfreq_dev_profile.get_dev_status() to get the
> @@ -49,6 +51,7 @@ struct devfreq_governor {
>
> const char name[DEVFREQ_NAME_LEN];
> const unsigned int immutable;
> + const unsigned int interrupt_driven;
> int (*get_target_freq)(struct devfreq *this, unsigned long *freq);
> int (*event_handler)(struct devfreq *devfreq,
> unsigned int event, void *data);
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2019-11-04 2:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-03 20:41 [PATCH v8 00/18] More improvements for Tegra30 devfreq driver Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 01/18] PM / devfreq: tegra30: Change irq type to unsigned int Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 02/18] PM / devfreq: tegra30: Keep interrupt disabled while governor is stopped Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 03/18] PM / devfreq: tegra30: Handle possible round-rate error Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 04/18] PM / devfreq: tegra30: Drop write-barrier Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 05/18] PM / devfreq: tegra30: Fix integer overflow on CPU's freq max out Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 06/18] PM / devfreq: tegra30: Use kHz units uniformly in the code Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 07/18] PM / devfreq: tegra30: Use CPUFreq notifier Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 08/18] PM / devfreq: tegra30: Move clk-notifier's registration to governor's start Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 09/18] PM / devfreq: tegra30: Reset boosting on startup Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 10/18] PM / devfreq: tegra30: Don't enable consecutive-down interrupt " Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 11/18] PM / devfreq: tegra30: Constify structs Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 12/18] PM / devfreq: tegra30: Include appropriate header Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 13/18] PM / devfreq: tegra30: Don't enable already enabled consecutive interrupts Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 14/18] PM / devfreq: tegra30: Disable consecutive interrupts when appropriate Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 15/18] PM / devfreq: Add new interrupt_driven flag for governors Dmitry Osipenko
2019-11-04 2:48 ` Chanwoo Choi [this message]
2019-11-04 14:15 ` Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 16/18] PM / devfreq: tegra30: Support variable polling interval Dmitry Osipenko
2019-11-04 2:53 ` Chanwoo Choi
2019-11-04 14:36 ` Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 17/18] PM / devfreq: tegra30: Tune up MCCPU boost-down coefficient Dmitry Osipenko
2019-11-03 20:41 ` [PATCH v8 18/18] PM / devfreq: tegra20/30: Add Dmitry as a maintainer Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f86d35dc-1749-ad29-2023-7d69366bd0d1@samsung.com \
--to=cw00.choi@samsung.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=myungjoo.ham@samsung.com \
--cc=pgwipeout@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).