From: Faiz Abbas <faiz_abbas@ti.com>
To: Chunyan Zhang <zhang.lyra@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>
Cc: Chunyan Zhang <zhang.chunyan@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>, <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Sekhar Nori <nsekhar@ti.com>
Subject: Re: [PATCH V4 1/3] mmc: sdhci: add support for using external DMA devices
Date: Wed, 2 Jan 2019 13:56:25 +0530 [thread overview]
Message-ID: <f8adce24-99eb-7b65-a2f6-79536686511c@ti.com> (raw)
In-Reply-To: <CAAfSe-tHu5m3Of6=KBCxBBH1T8=4tgN8aZP_7QaGERctECZPoQ@mail.gmail.com>
Adrian,
On 27/12/18 1:32 PM, Chunyan Zhang wrote:
> On Thu, 27 Dec 2018 at 15:44, Adrian Hunter <adrian.hunter@intel.com> wrote:
>>
>> On 11/12/18 11:12 AM, Chunyan Zhang wrote:
>>> Some standard SD host controllers can support both external dma
>>> controllers as well as ADMA/SDMA in which the SD host controller
>>> acts as DMA master. TI's omap controller is the case as an example.
>>>
>>> Currently the generic SDHCI code supports ADMA/SDMA integrated in
>>> the host controller but does not have any support for external DMA
>>> controllers implemented using dmaengine, meaning that custom code is
>>> needed for any systems that use an external DMA controller with SDHCI.
>>>
>>> Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
>>
>> FYI, I am waiting on successful testing before reviewing these patches again.
>
> Yeah, that makes sense, thanks Adrian!
>
> I intend to send out another new patchset after the holidays.
> After had another look at omap_hsmmc, I knew something need to be
> modified (emailed Faiz about this privately), but I was still not sure
> if it can fix the problem Faiz found.
>
I am currently working on moving am335 and am43 devices from omap_hsmmc
to sdhci-omap driver. External DMA would be an integral part of this.
The plan is to post these patches as a part of my series after testing
on all those devices.
Thanks,
Faiz
next prev parent reply other threads:[~2019-01-02 8:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 9:12 [PATCH V4 0/3] Add support for using external dma in SDHCI Chunyan Zhang
2018-12-11 9:12 ` [PATCH V4 1/3] mmc: sdhci: add support for using external DMA devices Chunyan Zhang
2018-12-13 12:07 ` Faiz Abbas
2018-12-27 7:42 ` Adrian Hunter
2018-12-27 8:02 ` Chunyan Zhang
2019-01-02 8:26 ` Faiz Abbas [this message]
2018-12-11 9:12 ` [PATCH V4 2/3] mmc: sdhci-omap: Add using external dma Chunyan Zhang
2018-12-11 9:12 ` [PATCH V4 3/3] dt-bindings: sdhci-omap: Add example for " Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8adce24-99eb-7b65-a2f6-79536686511c@ti.com \
--to=faiz_abbas@ti.com \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=ulf.hansson@linaro.org \
--cc=zhang.chunyan@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).