From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
Milian Wolff <milian.wolff@kdab.com>,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples
Date: Mon, 24 Jul 2017 10:51:58 +0900 [thread overview]
Message-ID: <f8fa9e2d-f55f-512c-4637-eefc4dd646c9@gmail.com> (raw)
In-Reply-To: <20170721112420.GE4134@kernel.org>
Hi Arnaldo,
Sorry, I'm too late.
On 07/21/2017 08:24 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jul 21, 2017 at 06:41:29PM +0900, Taeung Song escreveu:
>> On 07/21/2017 04:19 AM, Arnaldo Carvalho de Melo wrote:
>>> Em Thu, Jul 20, 2017 at 06:36:55AM +0900, Taeung Song escreveu:
>>>> Currently the --show-total-period option of perf-annotate
>>>> is different from perf-report's.
>
>>>> For example, perf-report ordinarily shows period and number of samples.
>
>>>> # Overhead Samples Period Command Shared Object Symbol
>>>> 9.83% 102 84813704 test test [.] knapsack
>
>>> But this is not what this patch does, it is still doing too many things,
>>> it should first add sample to those function signatures, leaving the
>>> "meat" to a followup patch, where we will not be distracted with
>>> infrastructure needed to do what you describe in the changelog.
>
>>> I'm doing it here this time, please look at the result, later.
>
>> ok, I'm waiting for it.
>> And if you give me some sketchy code, that's fine.
>> If you do, I'll remake this patch based on the result. :)
>
> Take a look at the acme/tmp_perf/core, that is where I got yesterday.
>
> - Arnaldo
>
I fetched all branch of your repository, but it don't seem to be pushed.
$ git remote get-url acme
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git
$ git branch -a | grep acme | grep tmp | grep core
remotes/acme/tmp.perf/core
remotes/acme/tmp_perf.core
$ git show tmp.perf/core | head -3
commit 4827c52cd001e208704ab733a389c96ae2e70e5b
Author: Andi Kleen <ak@linux.intel.com>
Date: Fri Jul 21 12:25:57 2017 -0700
$ git show tmp_perf.core | head -3
commit 3331778eb08a50cec959da933c040bd7fbdde396
Author: Adrian Hunter <adrian.hunter@intel.com>
Date: Thu Jul 31 09:00:56 2014 +0300
Thanks,
Taeung
next prev parent reply other threads:[~2017-07-24 1:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 21:36 [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples Taeung Song
2017-07-20 19:19 ` Arnaldo Carvalho de Melo
2017-07-21 9:41 ` Taeung Song
2017-07-21 11:24 ` Arnaldo Carvalho de Melo
2017-07-24 1:51 ` Taeung Song [this message]
2017-07-24 17:37 ` Arnaldo Carvalho de Melo
2017-07-24 21:28 ` Taeung Song
2017-07-25 14:42 ` Arnaldo Carvalho de Melo
2017-07-25 15:53 ` Taeung Song
2017-07-25 16:17 ` Arnaldo Carvalho de Melo
2017-07-26 11:57 ` Taeung Song
2017-07-26 20:17 ` Arnaldo Carvalho de Melo
2017-07-27 15:14 ` Taeung Song
2017-07-26 17:27 ` [tip:perf/core] perf annotate stdio: Fix column header when using --show-total-period tip-bot for Taeung Song
2017-07-21 14:47 ` [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples Arnaldo Carvalho de Melo
2017-07-22 22:46 ` Namhyung Kim
2017-07-23 15:46 ` Andi Kleen
2017-07-24 17:34 ` Arnaldo Carvalho de Melo
2017-07-24 17:46 ` Andi Kleen
2017-07-24 18:07 ` Arnaldo Carvalho de Melo
2017-07-26 17:20 ` [tip:perf/core] perf hists: Pass perf_sample to __symbol__inc_addr_samples() tip-bot for Taeung Song
2017-07-26 17:20 ` [tip:perf/core] perf annotate: Store the sample period in each histogram bucket tip-bot for Taeung Song
2017-07-26 17:20 ` [tip:perf/core] perf annotate: Do not overwrite sample->period tip-bot for Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8fa9e2d-f55f-512c-4637-eefc4dd646c9@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).