From: robin <robin@protonic.nl>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>, Miguel Ojeda <ojeda@kernel.org>,
Paul Burton <paulburton@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/17] dt-bindings: auxdisplay: ht16k33: Document Adafruit segment displays
Date: Tue, 23 Mar 2021 10:12:50 +0100 [thread overview]
Message-ID: <fb42abb0e79a57e2aab123468d95ff7e@protonic.nl> (raw)
In-Reply-To: <20210322144848.1065067-3-geert@linux-m68k.org>
On 2021-03-22 15:48, Geert Uytterhoeven wrote:
> The Holtek HT16K33 LED controller is not only used for driving
> dot-matrix displays, but also for driving segment displays.
>
> Document compatible values for the Adafruit 7-segment[1] and
> 14-segment[2] FeatherWing expansion boards with red displays.
> According
> to the schematics, all other Adafruit 7-segment and 14-segment display
> backpack and FeatherWing expansion boards (including bare boards and
> boards fitted with displays) are compatible with these two boards.
> Add a "color" property to support the different color variants.
>
> [1] https://www.adafruit.com/product/3108
> [2] https://www.adafruit.com/product/3130
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Alternatives I considered:
> 1. Document the attached display type in a child node.
> I.e. specify segment type, number of characters, and wiring.
> Especially the latter would become really complex, due to the
> sheer
> amount of possible wiring combinations.
> Using this method, you also loose the ability to just connect a
> display to an i2c bus, and instantiate the device from sysfs,
> without using DT:
>
> echo adafruit,3130 0x70 > /sys/class/i2c/i2c-adapter/.../new_device
>
> 2. Do not use the "color" property, but document all Adafruit
> 7-segment and 14-segment display backpack and FeatherWing
> expansion
> boards.
> This would lead to a myriad of compatible values:
>
> - items:
> - enum:
> - adafruit,878 # 0.56" 4-Digit 7-Segment Display Backpack
> (Red)
> - adafruit,879 # 0.56" 4-Digit 7-Segment Display Backpack
> (Yellow)
> - adafruit,880 # 0.56" 4-Digit 7-Segment Display Backpack
> (Green)
> - adafruit,881 # 0.56" 4-Digit 7-Segment Display Backpack
> (Blue)
> - adafruit,1002 # 0.56" 4-Digit 7-Segment Display Backpack
> (White)
> - const: adafruit,877 # 0.56" 4-Digit 7-Segment Backpack
> - const: holtek,ht16k33
>
> - items:
> - enum:
> - adafruit,1268 # 1.2" 4-Digit 7-Segment Display Backpack
> (Green)
> - adafruit,1269 # 1.2" 4-Digit 7-Segment Display Backpack
> (Yellow)
> - adafruit,1270 # 1.2" 4-Digit 7-Segment Display Backpack
> (Red)
> - const: adafruit,1271 # 1.2" 4-Digit 7-Segment Backpack
> - const: holtek,ht16k33
>
> - items:
> - enum:
> - adafruit,1911 # 0.54" Quad Alphanumeric Display Backpack
> (Red)
> - adafruit,1912 # 0.54" Quad Alphanumeric Display Backpack
> (Blue)
> - adafruit,2157 # 0.54" Quad Alphanumeric Display Backpack
> (White)
> - adafruit,2158 # 0.54" Quad Alphanumeric Display Backpack
> (Yellow)
> - adafruit,2159 # 0.54" Quad Alphanumeric Display Backpack
> (Yellow-Green)
> - adafruit,2160 # 0.54" Quad Alphanumeric Display Backpack
> (Green)
> - const: adafruit,1910 # 0.54" Quad 14-segment Alphanumeric
> Backpack
> - const: holtek,ht16k33
>
> - items:
> - enum:
> - adafruit,3106 # 0.56" 4-Digit 7-Segment FeatherWing
> Display (Blue)
> - adafruit,3107 # 0.56" 4-Digit 7-Segment FeatherWing
> Display (Green)
> - adafruit,3108 # 0.56" 4-Digit 7-Segment FeatherWing
> Display (Red)
> - adafruit,3109 # 0.56" 4-Digit 7-Segment FeatherWing
> Display (White)
> - adafruit,3110 # 0.56" 4-Digit 7-Segment FeatherWing
> Display (Yellow)
> - const: adafruit,3088 # 0.56" 4-Digit 7-Segment FeatherWing
> - const: holtek,ht16k33
>
> - items:
> - enum:
> - adafruit,3127 # 0.54" Quad Alphanumeric FeatherWing
> Display (White)
> - adafruit,3128 # 0.54" Quad Alphanumeric FeatherWing
> Display (Blue)
> - adafruit,3129 # 0.54" Quad Alphanumeric FeatherWing
> Display (Green)
> - adafruit,3130 # 0.54" Quad Alphanumeric FeatherWing
> Display (Red)
> - adafruit,3131 # 0.54" Quad Alphanumeric FeatherWing
> Display (Yellow)
> - adafruit,3132 # 0.54" Quad Alphanumeric FeatherWing
> Display (Yellow-Green)
> - const: adafruit,3089 # 0.54" Quad 14-segment Alphanumeric
> FeatherWing
> - const: holtek,ht16k33
> ---
> .../bindings/auxdisplay/holtek,ht16k33.yaml | 22 ++++++++++++++++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
> b/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
> index 64ffff460026040f..4380a5177a67d2e2 100644
> --- a/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
> +++ b/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
> @@ -14,14 +14,23 @@ allOf:
>
> properties:
> compatible:
> - const: holtek,ht16k33
> + oneOf:
> + - items:
> + - const: adafruit,3108 # 0.56" 4-Digit 7-Segment
> FeatherWing Display (Red)
> + - const: holtek,ht16k33
> +
> + - items:
> + - const: adafruit,3130 # 0.54" Quad Alphanumeric
> FeatherWing Display (Red)
> + - const: holtek,ht16k33
> +
> + - const: holtek,ht16k33 # Generic 16*8 LED controller with
> dot-matrix display
>
> reg:
> maxItems: 1
>
> refresh-rate-hz:
> maxItems: 1
> - description: Display update interval in Hertz
> + description: Display update interval in Hertz for dot-matrix
> displays
The above should be included in patch 16
>
> interrupts:
> maxItems: 1
> @@ -41,10 +50,17 @@ properties:
> default: 16
> description: Initial brightness level
>
> + color: true
> + description:
> + Color of the display. Use one of the LED_COLOR_ID_* prefixed
> definitions
> + from the header include/dt-bindings/leds/common.h. The default
> is red.
> + minimum: 0
> + maximum: 9
> + default: 1
> +
The above should be included in patch 17
> required:
> - compatible
> - reg
> - - refresh-rate-hz
'refresh-rate-hz' is still a required property for the dot-matrix /
fbdev setup.
If it can no longer be listed here than maybe its nice to mention that
it's required
somewhere else (in it's description?).
Rob?
Groetjes / Kind regards,
Robin van der Gracht
next prev parent reply other threads:[~2021-03-23 9:13 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 14:48 [PATCH 00/17] auxdisplay: ht16k33: Add character display support Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 01/17] uapi: Add <linux/map_to_14segment.h> Geert Uytterhoeven
2021-03-22 17:05 ` Miguel Ojeda
2021-03-22 17:51 ` Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 02/17] dt-bindings: auxdisplay: ht16k33: Document Adafruit segment displays Geert Uytterhoeven
2021-03-22 17:38 ` Rob Herring
2021-03-23 9:12 ` robin [this message]
2021-05-18 14:35 ` Geert Uytterhoeven
2021-05-19 10:37 ` Robin van der Gracht
2021-05-19 11:02 ` Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 03/17] auxdisplay: img-ascii-lcd: Fix lock-up when displaying empty string Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 04/17] auxdisplay: img-ascii-lcd: Add helper variable dev Geert Uytterhoeven
2021-03-22 16:59 ` Miguel Ojeda
2021-03-22 17:53 ` Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 05/17] auxdisplay: img-ascii-lcd: Convert device attribute to sysfs_emit() Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 06/17] auxdisplay: Extract character line display core support Geert Uytterhoeven
2021-03-23 8:18 ` robin
2021-03-23 8:52 ` Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 07/17] auxdisplay: linedisp: Use kmemdup_nul() helper Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 08/17] auxdisplay: linedisp: Add support for changing scroll rate Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 09/17] auxdisplay: ht16k33: Use HT16K33_FB_SIZE in ht16k33_initialize() Geert Uytterhoeven
2021-03-23 7:59 ` robin
2021-03-22 14:48 ` [PATCH 10/17] auxdisplay: ht16k33: Remove unneeded error check in keypad probe() Geert Uytterhoeven
2021-03-23 8:08 ` robin
2021-03-22 14:48 ` [PATCH 11/17] auxdisplay: ht16k33: Convert to simple i2c probe function Geert Uytterhoeven
2021-03-23 8:31 ` robin
2021-03-22 14:48 ` [PATCH 12/17] auxdisplay: ht16k33: Add helper variable dev Geert Uytterhoeven
2021-03-23 8:57 ` robin
2021-03-22 14:48 ` [PATCH 13/17] auxdisplay: ht16k33: Move delayed work Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 14/17] auxdisplay: ht16k33: Extract ht16k33_brightness_set() Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 15/17] auxdisplay: ht16k33: Extract frame buffer probing Geert Uytterhoeven
2021-03-22 14:48 ` [PATCH 16/17] auxdisplay: ht16k33: Add support for segment displays Geert Uytterhoeven
2021-03-29 7:08 ` Robin van der Gracht
2021-03-29 7:15 ` Geert Uytterhoeven
2021-03-29 7:30 ` Robin van der Gracht
2021-03-22 14:48 ` [PATCH 17/17] auxdisplay: ht16k33: Add segment display LED support Geert Uytterhoeven
2021-03-23 10:08 ` Robin van der Gracht
2021-03-23 12:32 ` Geert Uytterhoeven
2021-03-23 20:40 ` Pavel Machek
2021-03-24 8:31 ` Geert Uytterhoeven
2021-03-27 22:19 ` Pavel Machek
2021-06-25 12:39 ` Geert Uytterhoeven
2021-03-22 17:03 ` [PATCH 00/17] auxdisplay: ht16k33: Add character display support Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb42abb0e79a57e2aab123468d95ff7e@protonic.nl \
--to=robin@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=paulburton@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).