Re: [PATCH v2 12/12] dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML

From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Maxime Ripard <maxime@cerno.tech>,
	Florian Fainelli <f.fainelli@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	"maintainer:BROADCOM IPROC ARM ARCHITECTURE" 
	<bcm-kernel-feedback-list@broadcom.com>,
	Sugaya Taichi <sugaya.taichi@socionext.com>,
	Andrew Jeffery <andrew@aj.id.au>, Arnd Bergmann <arnd@arndb.de>,
	Joel Stanley <joel@jms.id.au>, Vinod Koul <vkoul@kernel.org>,
	"james.tai" <james.tai@realtek.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
	<linux-rpi-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 12/12] dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML
Date: Mon, 23 Mar 2020 11:42:16 +0100	[thread overview]
Message-ID: <fc5bcca4feed54de243b3e24228ef1ad99430c4c.camel@suse.de> (raw)
In-Reply-To: <20200323084044.dziwbk7pugoy73yh@gilmour.lan>

[-- Attachment #1: Type: text/plain, Size: 3519 bytes --]

On Mon, 2020-03-23 at 09:40 +0100, Maxime Ripard wrote:
> Hi Florian,
> 
> On Sun, Mar 22, 2020 at 02:35:17PM -0700, Florian Fainelli wrote:
> > 
> > On 2/6/2020 11:23 AM, Rob Herring wrote:
> > > On Tue, Feb 04, 2020 at 03:55:52PM -0800, Florian Fainelli wrote:
> > > > Convert the Raspberry Pi BCM2835 firmware binding document to YAML.
> > > > Verified with dt_binding_check and dtbs_check.
> > > > 
> > > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > > > ---
> > > >  .../arm/bcm/raspberrypi,bcm2835-firmware.txt  | 14 --------
> > > >  .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 33 +++++++++++++++++++
> > > >  2 files changed, 33 insertions(+), 14 deletions(-)
> > > >  delete mode 100644
> > > > Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-
> > > > firmware.txt
> > > >  create mode 100644
> > > > Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-
> > > > firmware.yaml
> > > > 
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-
> > > > firmware.txt
> > > > b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-
> > > > firmware.txt
> > > > deleted file mode 100644
> > > > index 6824b3180ffb..000000000000
> > > > --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-
> > > > firmware.txt
> > > > +++ /dev/null
> > > > @@ -1,14 +0,0 @@
> > > > -Raspberry Pi VideoCore firmware driver
> > > > -
> > > > -Required properties:
> > > > -
> > > > -- compatible:		Should be "raspberrypi,bcm2835-firmware"
> > > > -- mboxes:		Phandle to the firmware device's Mailbox.
> > > > -			  (See: ../mailbox/mailbox.txt for more
> > > > information)
> > > > -
> > > > -Example:
> > > > -
> > > > -firmware {
> > > > -	compatible = "raspberrypi,bcm2835-firmware";
> > > > -	mboxes = <&mailbox>;
> > > > -};
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-
> > > > firmware.yaml
> > > > b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-
> > > > firmware.yaml
> > > > new file mode 100644
> > > > index 000000000000..db355d970f2b
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-
> > > > firmware.yaml
> > > > @@ -0,0 +1,33 @@
> > > > +# SPDX-License-Identifier: GPL-2.0
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: 
> > > > http://devicetree.org/schemas/arm/bcm/raspberrypi,bcm2835-firmware.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Raspberry Pi VideoCore firmware driver
> > > > +
> > > > +maintainers:
> > > > +  - Eric Anholt <eric@anholt.net>
> > > > +  - Stefan Wahren <wahrenst@gmx.net>
> > > > +
> > > > +properties:
> > > > +  compatible:
> > > > +    const: raspberrypi,bcm2835-firmware simple-bus
> > >                                           ^
> > > 
> > > I need to check for spaces with the meta-schema...
> > 
> > I believe I had tried to use:
> > 
> > const: raspberrypi,bcm2835-firmware
> > const: simple-bus
> > 
> > but this did not work, and I had to resort to doing this.
> 
> That would be:
> 
> compatible:
>   items:
>     - const: raspberrypi,bcm2835-firmware
>     - const: simple-bus
> 
> It changes slightly from what the initial binding was saying though,
> since it wasn't mentionning simple-bus at all? Is that on purpose?

I guess we failed to update the binding after starting to use the firmware
device as a bus.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]